From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id NAPBK7XR115KJgAA0tVLHw (envelope-from ) for ; Wed, 03 Jun 2020 16:37:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ENkcJ7XR115AIQAA1q6Kng (envelope-from ) for ; Wed, 03 Jun 2020 16:37:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0AD0694066A for ; Wed, 3 Jun 2020 16:37:09 +0000 (UTC) Received: from localhost ([::1]:48056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgWO3-0000mw-DX for larch@yhetil.org; Wed, 03 Jun 2020 12:37:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgWNy-0000mq-EU for guix-patches@gnu.org; Wed, 03 Jun 2020 12:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32943) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgWNy-0001CZ-5C for guix-patches@gnu.org; Wed, 03 Jun 2020 12:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jgWNy-0004T5-1n for guix-patches@gnu.org; Wed, 03 Jun 2020 12:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41360] [PATCH v3 1/9] gnu: java-openjfx-build: Add helpful patch. Resent-From: Alexey Abramov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Jun 2020 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41360 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Julien Lepiller Cc: 41360@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 41360-submit@debbugs.gnu.org id=B41360.159120220617153 (code B ref 41360); Wed, 03 Jun 2020 16:37:02 +0000 Received: (at 41360) by debbugs.gnu.org; 3 Jun 2020 16:36:46 +0000 Received: from localhost ([127.0.0.1]:44489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgWNh-0004Sb-Tq for submit@debbugs.gnu.org; Wed, 03 Jun 2020 12:36:46 -0400 Received: from mx4.mail.mmer.org ([178.22.66.29]:50720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgWNe-0004SR-Ia for 41360@debbugs.gnu.org; Wed, 03 Jun 2020 12:36:44 -0400 Received: from delta (92-109-1-225.cable.dynamic.v4.ziggo.nl [92.109.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx4.mail.mmer.org (Postfix) with ESMTPSA id EC9EE9CC41; Wed, 3 Jun 2020 16:05:52 +0000 (UTC) From: Alexey Abramov References: <20200517132829.1553311-1-levenson@mmer.org> <20200530170951.1649-1-levenson@mmer.org> <87pnagkv1t.fsf@gnu.org> <0F005145-C408-4B05-86C2-750219F7F2E3@lepiller.eu> Date: Wed, 03 Jun 2020 18:36:34 +0200 In-Reply-To: <0F005145-C408-4B05-86C2-750219F7F2E3@lepiller.eu> (Julien Lepiller's message of "Wed, 03 Jun 2020 12:24:58 -0400") Message-ID: <877dwoyulp.fsf@mmer.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 8h4NPGj6OFRk Hi Julien, Ludo, Julien Lepiller writes: > Le 3 juin 2020 11:50:38 GMT-04:00, "Ludovic Court=C3=A8s" = a =C3=A9crit : >>Alexey Abramov skribis: >> >>> +++ b/gnu/packages/patches/java-openjfx-build-jdk_version.patch > >>> @@ -0,0 +1,27 @@ >>> +Subject: [PATCH] openjfx: Determine the version of Java in JDK_HOME >>> + >>> +Icedtea contains guix in its version, so build.gradle failes to run. >>Openjfx >>> +packaging is not trivial, so you will probably need to try build it >>with >>> +gradlew. >>> + >>> +--- >>> + build.gradle | 5 ++--- >>> + 1 file changed, 2 insertions(+), 3 deletions(-) >> >>This patch also made me realize that we=E2=80=99re using Gradle here, but >>there=E2=80=99s no Gradle package in Guix. That means we must be using a >>pre-built jar somewhere, though I didn=E2=80=99t find it. Any idea where= that >>comes from? Julien, any idea? >> >>(The problem existed before your patches.) >> >>Thanks, >>Ludo=E2=80=99. > > From what I understand, this patcg helps build openjfx with gradle on > guix, if you use the guix source in an environment, but reading the > other patches, it doesn't look like gradle is actually used anywhere. > > It looks like this patch is helpful in the sense that it allows users to = manually build the package outside of guix, but is not used at all during t= he build of openjfx by guix itself. > > Alexey, can you confirm? Yes, you are right. I am not using gradle. The reason for this patch was to be able to debug the building process openjfx. I had to run gradlew multiple times, so I decided to just patch it. --=20 Alexey