From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4aFuOM1Z3V5gagAA0tVLHw (envelope-from ) for ; Sun, 07 Jun 2020 21:19:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GBjnM81Z3V4NVgAAbx9fmQ (envelope-from ) for ; Sun, 07 Jun 2020 21:19:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 87241940607 for ; Sun, 7 Jun 2020 21:19:09 +0000 (UTC) Received: from localhost ([::1]:54838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ji2hA-0003Eg-Hr for larch@yhetil.org; Sun, 07 Jun 2020 17:19:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ji2h4-0003EL-Om for guix-patches@gnu.org; Sun, 07 Jun 2020 17:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43570) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ji2h4-0006gG-G9 for guix-patches@gnu.org; Sun, 07 Jun 2020 17:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ji2h4-0005Y2-CH for guix-patches@gnu.org; Sun, 07 Jun 2020 17:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41679] [PATCH] gnu: Update protonvpn-cli to 2.2.4 Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 07 Jun 2020 21:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41679 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ryan Prior Cc: 41679@debbugs.gnu.org Received: via spool by 41679-submit@debbugs.gnu.org id=B41679.159156471421292 (code B ref 41679); Sun, 07 Jun 2020 21:19:02 +0000 Received: (at 41679) by debbugs.gnu.org; 7 Jun 2020 21:18:34 +0000 Received: from localhost ([127.0.0.1]:55116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji2gc-0005XL-2u for submit@debbugs.gnu.org; Sun, 07 Jun 2020 17:18:34 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:43139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji2ga-0005X7-E4 for 41679@debbugs.gnu.org; Sun, 07 Jun 2020 17:18:33 -0400 X-Originating-IP: 78.237.113.178 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 88B3F60003; Sun, 7 Jun 2020 21:18:25 +0000 (UTC) From: Brice Waegeneire In-Reply-To: <20200602234337.11487-1-rprior@protonmail.com> (Ryan Prior's message of "Tue, 02 Jun 2020 23:43:48 +0000") References: <20200602234337.11487-1-rprior@protonmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Date: Sun, 07 Jun 2020 23:18:21 +0200 Message-ID: <877dwilgma.fsf@waegenei.re> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: x5DVS0xqYdOo Hello Ryan, Thank you for the patch! Ryan Prior writes: > * gnu/packages/vpn.scm (protonvpn-cli): Update to 2.2.4 > --- > gnu/packages/vpn.scm | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) The update is fine, but that package is missing several dependencies, at least: python-jinja2, coreutils and iproute. Try running it in a pure environment and it will crash =E2=80=9Cguix environment --pure --container --ad-hoc protonvpn-cli -- protonvpn -h=E2=80=9D. Searching the source for =E2=80=9Csubprocess.run=E2=80=9D I find call to ot= her binaries which aren't listed as dependencies. Could you wrap the =E2=80=9Cprotonvpn= =E2=80=9D binary with the =E2=80=9CPATH=E2=80=9D of all the binaries it uses to avoid= propagating a whole lot of packages. Probably only =E2=80=9Cpython-jinja2=E2=80=9D shou= ld be propagated. - Brice