unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 41718-done@debbugs.gnu.org,
	Katherine Cox-Buday <cox.katherine.e@gmail.com>
Subject: [bug#41718] [PATCH] Update StumpWM Contrib Package Names and Add New Ones
Date: Wed, 10 Jun 2020 00:00:39 +0200	[thread overview]
Message-ID: <877dwfq4qg.fsf@nckx> (raw)
In-Reply-To: <875zc09hrt.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]

Katherine, Oleg,

Thanks for the patches and testing!  I pushed a bug-fix in commit 
9bb102dc1c47275d2906a9f4e0b813e1940176d3:

+(define-public stumpish
+  (package
+    (inherit stumpwm-contrib)
+    (name "stumpish")
+    (inputs
+     `(("bash" ,bash)
+       ("rlwrap" ,rlwrap)))
+    (build-system trivial-build-system)
+    (arguments
+     '(#:modules ((guix build utils))
+       #:tests? #f

The ‘tests?’ keyword isn't understood by the trivial build system, 
and broke ‘guix pull’.

Oleg Pykhalov 写道：
> Thank you!  I successfully tested my StumpWM config on a virtual 
> machine
> with current changes and pushed them to master.

It's interesting that this didn't throw an error.  I guess the 
only way to test such things is to ‘guix pull’ yourself, which can 
be tedious and slow.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2020-06-09 22:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04 22:44 [bug#41718] [PATCH] Update StumpWM Contrib Package Names and Add New Ones Katherine Cox-Buday
2020-06-09 19:11 ` bug#41718: " Oleg Pykhalov
2020-06-09 22:00   ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2020-06-09 22:46     ` [bug#41718] " Katherine Cox-Buday

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dwfq4qg.fsf@nckx \
    --to=guix-patches@gnu.org \
    --cc=41718-done@debbugs.gnu.org \
    --cc=cox.katherine.e@gmail.com \
    --cc=go.wigust@gmail.com \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).