unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 43208@debbugs.gnu.org
Cc: timhowes@lavabit.com
Subject: [bug#43208] [PATCH] gnu: emacs-ess: Update to 20200903.1516.
Date: Sat, 05 Sep 2020 15:35:04 +0200	[thread overview]
Message-ID: <877dt8tkhj.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20200904235023.11193-1-timhowes@lavabit.com> (Tim Howes via Guix-patches via's message of "Fri, 4 Sep 2020 16:50:23 -0700")

Hello,

Tim Howes via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/statistics.scm (emacs-ess): Update to 20200903.1516.
> [version]: Use latest commit, assign version based on commit date.
> [source]: Fix snippet for removing julia-mode.  Remove snippet to modify
> roxy-preview-Rd-test.  Add snippet to modify r-help-mode test.  Add
> snippet to fix install target to install files to correct directories.
> [arguments]: Add flag to specify INFODIR.  Remove patch modifying
> SHELL.

Thank you.

> This updates emacs-ess to the current version on github and resolves
> bugs #43093 and #42259.
>
>  gnu/packages/statistics.scm | 43 ++++++++++++++++---------------------
>  1 file changed, 19 insertions(+), 24 deletions(-)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index c1cefa8c41..aa14e2887f 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -5805,29 +5805,24 @@ Java package that provides routines for various statistical distributions.")
>  (define-public emacs-ess
>    (package
>      (name "emacs-ess")
> -    (version "18.10.2")
> +    ;; Use version number based on commit date and time (UTC), similar to melpa.
> +    (version "20200903.1516")

I don't think this numbering is great because it makes it difficult to
switch to the official one once it is increased. Usually, we add
a revision number to the version, see, e.g., emacs-ansi.

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2020-09-05 13:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04 23:50 [bug#43208] [PATCH] gnu: emacs-ess: Update to 20200903.1516 Tim Howes via Guix-patches via
2020-09-05 13:35 ` Nicolas Goaziou [this message]
2020-09-05 17:58   ` Tim Howes via Guix-patches via
2020-09-05 21:45   ` [bug#43208] [PATCH] gnu: emacs-ess: Update to 20.09 Tim Howes via Guix-patches via
2020-09-06  8:02     ` Nicolas Goaziou
2020-09-08 19:22       ` Tim Howes via Guix-patches via
2020-09-24 15:20         ` Ludovic Courtès
2020-09-26  9:40       ` [bug#43208] [PATCH v3] gnu: emacs-ess: Update to 18.10.2-0.24da603 Tim Howes via Guix-patches via
2020-09-26 11:02         ` bug#43208: " Nicolas Goaziou
2020-09-06  0:57   ` [bug#43208] [PATCH] gnu: emacs-ess: Update to 20.09 Tim Howes via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dt8tkhj.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=43208@debbugs.gnu.org \
    --cc=timhowes@lavabit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).