From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Joseph LaFreniere <joseph@lafreniere.xyz>
Cc: 44165@debbugs.gnu.org
Subject: [bug#44165] [PATCH] gnu: Add emacs-xonsh-mode.
Date: Mon, 26 Oct 2020 09:41:53 +0100 [thread overview]
Message-ID: <877drd5qge.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87tuulag92.fsf@odyssey.lafreniere.xyz> (Joseph LaFreniere's message of "Thu, 22 Oct 2020 20:22:01 -0500")
Hello,
Joseph LaFreniere <joseph@lafreniere.xyz> writes:
> Patch file is attached.
Thank you. Some comments follow.
> + ;; There is no tagged release yet.
> + (let ((tag "0.0.0")
The version is actually "O" according to the "Version" keyword in the
Elisp file, not "0.0.0".
> + (commit "7fa581524533a9b6b770426e4445e571a69e469d")
> + (revision "0"))
> + (package
> + (name "emacs-xonsh-mode")
> + (version (git-version tag revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/seanfarley/xonsh-mode.git")
> + (commit commit)))
> + (sha256
> + (base32 "0lfi2372clkkzi4a940fwparsfhxxzb7bmysfd50n1myakgldri5"))))
> + (build-system emacs-build-system)
> + (home-page "https://github.com/seanfarley/xonsh-mode")
> + (synopsis "Major mode for editing @code{xonsh} files")
Emacs major mode for editing @file{xonshrc} files
seems slightly more accurate.
> + (description
> + "This package implements a major mode for xonsh scripts. The basic
Mind the two spaces after the full stop above.
> +functionality includes syntax highlight for xonsh operators. Files with the
> +.xonshrc or .xsh extension are automatically opened with this mode.")
@file{.xonshrc} or @file{.xsh} extension
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-10-26 8:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 1:22 [bug#44165] [PATCH] gnu: Add emacs-xonsh-mode Joseph LaFreniere
2020-10-26 8:41 ` Nicolas Goaziou [this message]
2020-10-28 19:37 ` Joseph LaFreniere
2023-04-25 7:39 ` Hilton Chain via Guix-patches via
2023-04-25 9:51 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877drd5qge.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=44165@debbugs.gnu.org \
--cc=joseph@lafreniere.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).