unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Niklas Eklund <niklas.eklund@posteo.net>
Cc: 44024@debbugs.gnu.org, Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: [bug#44024] [PATCH] gnu: emacs-request: Update to latest commit.
Date: Wed, 18 Nov 2020 23:09:14 +0100	[thread overview]
Message-ID: <877dqijp11.fsf@gnu.org> (raw)
In-Reply-To: <87v9f78iki.fsf@posteo.net> (Niklas Eklund's message of "Sun, 18 Oct 2020 21:01:17 +0200")

Hi,

Niklas Eklund <niklas.eklund@posteo.net> skribis:

> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> Hello,
>>
>> Niklas Eklund <niklas.eklund@posteo.net> writes:
>>
>>> This patch updates emacs-request to the latest commit on git. The reason for
>>> updating the package is that early this year a patch was merged which allowed
>>> emacs-request to utilize the auth-source package providing a more convenient
>>> experience for users and package developers.
>>
>> Thank you.
>>
>> Could you add a comment explaining the above at the top of the package
>> definition and send it again?
>>
>> Regards,
>> -- 
>> Nicolas Goaziou
>
> Absolutely, I wasn't sure if I were to put it in the code or not, but
> now I know for the future.

[...]

> +(define-public emacs-gcmh
> +  (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
> +        (revision "0"))

Looks like you forgot the comment.  :-)

Could you send an updated patch?  (Else we can do it for you.)

Thanks,
Ludo’.




  reply	other threads:[~2020-11-18 22:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 20:31 [bug#44024] [PATCH] gnu: emacs-request: Update to latest commit Niklas Eklund
2020-10-15 21:54 ` Nicolas Goaziou
2020-10-18 19:01   ` Niklas Eklund
2020-11-18 22:09     ` Ludovic Courtès [this message]
2020-11-19  8:58       ` Niklas Eklund
2020-11-19 20:28         ` bug#44024: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dqijp11.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=44024@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=niklas.eklund@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).