[bug#44977] [PATCH] gnu: bc: Fix readline support.

[bug#44977] [PATCH] gnu: bc: Fix readline support.

[dftxbs3e]

[-- Attachment #1: Type: text/plain, Size: 121 bytes --]

Hello!

Someone on IRC complained they could not use arrow keys in GNU Guix's
bc, turns out there was a bug.

Thank you!

[-- Attachment #2: 0001-gnu-bc-Fix-readline-support.patch --]
[-- Type: text/x-patch, Size: 1021 bytes --]

From 85566761f612330be749e05f15eda6e62b8891c8 Mon Sep 17 00:00:00 2001
From: John Doe <dftxbs3e@free.fr>
Date: Tue, 1 Dec 2020 02:15:20 +0100
Subject: [PATCH] gnu: bc: Fix readline support.

--with-readline is given to configure but there's no readline input
present so it is not effective. Probably bc's configure should fail when
that is the case but that's another story.

* gnu/packages/albegra.scm (bc)[inputs]: Add readline.
---
 gnu/packages/algebra.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
index 5b391449a0..ea2ec6f1ef 100644
--- a/gnu/packages/algebra.scm
+++ b/gnu/packages/algebra.scm
@@ -710,6 +710,8 @@ binary.")
                "0amh9ik44jfg66csyvf4zz1l878c4755kjndq9j0270akflgrbb2"))
              (patches (search-patches "bc-fix-cross-compilation.patch"))))
     (build-system gnu-build-system)
+    (inputs
+     `(("readline" ,readline)))
     (native-inputs
      `(("automake" ,automake)
        ("autoconf" ,autoconf)
-- 
2.28.0

[bug#44977] [PATCH] gnu: bc: Fix readline support.

[dftxbs3e]

[-- Attachment #1: Type: text/plain, Size: 18 bytes --]

Fix typo in path.

[-- Attachment #2: 0001-gnu-bc-Fix-readline-support.patch --]
[-- Type: text/x-patch, Size: 1021 bytes --]

From ba427730bb61e7d8270a3c71ce36f631d8227bbd Mon Sep 17 00:00:00 2001
From: John Doe <dftxbs3e@free.fr>
Date: Tue, 1 Dec 2020 02:15:20 +0100
Subject: [PATCH] gnu: bc: Fix readline support.

--with-readline is given to configure but there's no readline input
present so it is not effective. Probably bc's configure should fail when
that is the case but that's another story.

* gnu/packages/algebra.scm (bc)[inputs]: Add readline.
---
 gnu/packages/algebra.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm
index 5b391449a0..ea2ec6f1ef 100644
--- a/gnu/packages/algebra.scm
+++ b/gnu/packages/algebra.scm
@@ -710,6 +710,8 @@ binary.")
                "0amh9ik44jfg66csyvf4zz1l878c4755kjndq9j0270akflgrbb2"))
              (patches (search-patches "bc-fix-cross-compilation.patch"))))
     (build-system gnu-build-system)
+    (inputs
+     `(("readline" ,readline)))
     (native-inputs
      `(("automake" ,automake)
        ("autoconf" ,autoconf)
-- 
2.28.0

bug#44977: gnu: bc: Fix readline support.

[Tobias Geerinckx-Rice via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 68 bytes --]

Pushed as e76867e285710d06b319145e0acdb6208e1af811.

Thanks!

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]