unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Matthew Kraai <kraai@ftbfs.org>
Cc: 46058@debbugs.gnu.org
Subject: [bug#46058] [PATCH] gnu: Test rust-juniper-codegen.
Date: Sun, 24 Jan 2021 10:20:21 +0100	[thread overview]
Message-ID: <877do2elnu.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20210123213047.31750-1-kraai@ftbfs.org> (Matthew Kraai's message of "Sat, 23 Jan 2021 13:30:47 -0800")

Hello,

Matthew Kraai <kraai@ftbfs.org> writes:

> * gnu/packages/patches/rust-juniper-codegen-use-__private.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/crates-io.scm (rust-juniper-codegen-0.14)[source]: Use it.
>   [arguments]: Do not set #:tests? to #false.

Thank you for fixing my FIXME. :)

However, I ponder if this is going in the right direction. IIUC, the
goal for Rust packaging is to automatically fetch and build inputs and
development inputs, using the importer, i.e., maybe writing something like

     #:cargo-inputs (("instant" "0.1")
                     ("lock-api" "0.4")
                     ("parking-lot-core" "0.8"))

and let the crate importer deal with it without providing the packages
ourselves.

In this case, why bother, since any non-leaf package will be expected to
#:skip-build anyway. What about doing it here, too?

WDYT?

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2021-01-24  9:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-23 21:30 [bug#46058] [PATCH] gnu: Test rust-juniper-codegen Matthew Kraai
2021-01-24  9:20 ` Nicolas Goaziou [this message]
2021-01-24 13:06   ` Matthew Kraai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877do2elnu.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=46058@debbugs.gnu.org \
    --cc=kraai@ftbfs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).