From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2VHoGuvZFmDGVQAA0tVLHw (envelope-from ) for ; Sun, 31 Jan 2021 16:25:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yI49FuvZFmBWQQAAB5/wlQ (envelope-from ) for ; Sun, 31 Jan 2021 16:25:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E27CD94042F for ; Sun, 31 Jan 2021 16:25:14 +0000 (UTC) Received: from localhost ([::1]:40000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6FXF-0002zL-Th for larch@yhetil.org; Sun, 31 Jan 2021 11:25:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6FX4-0002zA-5k for guix-patches@gnu.org; Sun, 31 Jan 2021 11:25:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46260) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6FX3-0002ui-UC for guix-patches@gnu.org; Sun, 31 Jan 2021 11:25:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l6FX3-0007pl-Pe for guix-patches@gnu.org; Sun, 31 Jan 2021 11:25:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44178] [PATCH] Create importer for Go modules Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 31 Jan 2021 16:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44178 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: JOULAUD =?UTF-8?Q?Fran=C3=A7ois?= Received: via spool by 44178-submit@debbugs.gnu.org id=B44178.161211025130051 (code B ref 44178); Sun, 31 Jan 2021 16:25:01 +0000 Received: (at 44178) by debbugs.gnu.org; 31 Jan 2021 16:24:11 +0000 Received: from localhost ([127.0.0.1]:57806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6FWE-0007od-Qx for submit@debbugs.gnu.org; Sun, 31 Jan 2021 11:24:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6FWB-0007oP-JI for 44178@debbugs.gnu.org; Sun, 31 Jan 2021 11:24:09 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35099) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6FW5-0002cG-Kn; Sun, 31 Jan 2021 11:24:01 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=50408 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l6FW5-0004dh-5Z; Sun, 31 Jan 2021 11:24:01 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210123212742.m2thdeuzdvgpkgeo@fjo-extia-HPdeb.example.avalenn.eu> <87r1mb6zu9.fsf@gmail.com> <20210125205910.qvmcusm5w5n4pawy@fjo-extia-HPdeb.example.avalenn.eu> <87sg6mmolg.fsf@gmail.com> <87czxpp4wy.fsf@gnu.org> <20210129163945.irrdlm3updejkcsg@fjo-extia-HPdeb.example.avalenn.eu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 =?UTF-8?Q?Pluvi=C3=B4se?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 31 Jan 2021 17:23:59 +0100 In-Reply-To: <20210129163945.irrdlm3updejkcsg@fjo-extia-HPdeb.example.avalenn.eu> ("JOULAUD =?UTF-8?Q?Fran=C3=A7ois?="'s message of "Fri, 29 Jan 2021 16:43:02 +0000") Message-ID: <877dntnkgw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "44178@debbugs.gnu.org" <44178@debbugs.gnu.org>, Katherine Cox-Buday Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E27CD94042F X-Spam-Score: -2.86 X-Migadu-Scanner: scn0.migadu.com X-TUID: Pd+8mqOQm12K Hi, JOULAUD Fran=C3=A7ois skribis: > On Thu, Jan 28, 2021 at 02:27:57PM +0100, Ludovic Court=C3=A8s wrote: >> I think whoever among you is available to work on it these days could >> take the lead and prepare a final version of the patches. It looks like >> it=E2=80=99s approaching a first =E2=80=9Ccommittable=E2=80=9D version (= perhaps just missing an >> addition to doc/guix.texi and test cases like we have =E2=80=98tests/cpa= n.scm=E2=80=99 & >> co.) > > I thought I would be able to send a working v2 of this patch today but > it seems I was too optimistic. > > I found that some go.mod out there uses quoted string > which our ad-hoc parser don't know how to parse. cf. > https://github.com/go-yaml/yaml/blob/496545a6307b2a7d7a710fd516e5e16e8ab6= 2dbc/go.mod > > I don't know if this is a blocker for a merge or not. Your call; if it=E2=80=99s an infrequent problem, we could commit it and le= ave a FIXME in the code. We could also use guile-yaml (or maybe some Go code?) to parse it correctly. > Apart from that I don't know how to add guile-lib to the dependencies of > Guix (in order to use htmlprag). Help needed. So =E2=80=98xml->sxml=E2=80=99 isn=E2=80=99t good enough? (If we can avoid= the guile-lib dependency, the better.) To depend on Guile-Lib, you would: 1. Add it to (guix self) =E2=80=94 this is the code used by =E2=80=98guix= pull=E2=80=99; 2. Add it to the =E2=80=98inputs=E2=80=99 field of the =E2=80=98guix=E2= =80=99 package; 3. Maybe add a configure check in =E2=80=98configure.ac=E2=80=99, though = it would be best if we could arrange to make it an optional dependency. > I tested it recursively with github.com/hashicorp/consul (which was one > of those with the most dependencies I found) and it mostly works. Yay, sounds promising! Thanks, Ludo=E2=80=99.