unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mike Gerwitz <mtg@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 47789@debbugs.gnu.org
Subject: [bug#47789] [PATCH 4/6] gnu: Add java-jline-terminal.
Date: Thu, 15 Apr 2021 20:55:54 -0400	[thread overview]
Message-ID: <877dl3kpyd.fsf@gnu.org> (raw)
In-Reply-To: <5bcade8103a4995b6ba2fe64572c230bcbf52f82.camel@telenet.be> (Maxime Devos's message of "Thu, 15 Apr 2021 10:13:03 +0200")

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

On Thu, Apr 15, 2021 at 10:13:03 +0200, Maxime Devos wrote:
> On Thu, 2021-04-15 at 00:26 -0400, Mike Gerwitz wrote:
>> +         (add-after 'unpack 'patch-paths
>> +           (lambda _
>> +             (substitute* "terminal/src/main/java/org/jline/utils/OSUtils.java"
>> +               (("= \"(s?tty|infocmp)\"" _ cmd)
>> +                (string-append "= \"" (which cmd) "\"")))
>
> (which cmd) is most likely incorrect when cross-compiling,
> as when cross-compiling, only the inputs in "native-inputs" contribute
> towards PATH, and "inputs" does not contribute towards PATH (IIUC).
>
> You will need something like
> (lambda* (#:key inputs #:allow-other-keys)
>   ...
>   ... (string-append "= \"" (assoc-ref "ncurses" inputs) "/bin/ncurses")

Thanks.  There are some other Java packages that do this as well.  I'll
include these changes in the new series.

> (TODO to self: define a variant which/target which looks at the build inputs
> instead of native-inputs when cross-compiling.) 

+1

-- 
Mike Gerwitz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2021-04-16  1:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15  4:22 [bug#47789] [PATCH 0/6] Add TLA+ Tools (tla2tools) Mike Gerwitz
2021-04-15  4:25 ` [bug#47789] [PATCH 1/6] gnu: Add java-gson-2.8.6 Mike Gerwitz
2021-04-15  8:06   ` Maxime Devos
2021-04-16  1:13     ` Mike Gerwitz
2021-04-15 10:46   ` Julien Lepiller
2021-04-16  0:27     ` Mike Gerwitz
2021-04-15  4:26 ` [bug#47789] [PATCH 2/6] gnu: Add java-eclipse-xtext-xbase-lib Mike Gerwitz
2021-04-15  4:26 ` [bug#47789] [PATCH 3/6] gnu: Add java-eclipse-lsp4j packages Mike Gerwitz
2021-04-15  4:26 ` [bug#47789] [PATCH 4/6] gnu: Add java-jline-terminal Mike Gerwitz
2021-04-15  8:13   ` Maxime Devos
2021-04-16  0:55     ` Mike Gerwitz [this message]
2021-04-15  4:27 ` [bug#47789] [PATCH 5/6] gnu: Add java-jline-reader Mike Gerwitz
2021-04-15  4:27 ` [bug#47789] [PATCH 6/6] gnu: Add tla2tools Mike Gerwitz
2021-04-15  8:17   ` Maxime Devos
2021-04-16  0:57     ` Mike Gerwitz
2021-04-16  1:12     ` Mike Gerwitz
2021-04-16  1:23 ` [bug#47789] [PATCH 1/6] gnu: Add java-gson-2.8.6 Mike Gerwitz
2021-04-16  1:23 ` [bug#47789] [PATCH 2/6] gnu: Add java-eclipse-xtext-xbase-lib Mike Gerwitz
2021-04-16  1:24 ` [bug#47789] [PATCH 3/6] gnu: Add java-eclipse-lsp4j packages Mike Gerwitz
2021-04-16  1:24 ` [bug#47789] [PATCH 4/6] gnu: Add java-jline-terminal Mike Gerwitz
2021-04-16  1:24 ` [bug#47789] [PATCH 5/6] gnu: Add java-jline-reader Mike Gerwitz
2021-04-16  1:24 ` [bug#47789] [PATCH 6/6] gnu: Add tla2tools Mike Gerwitz
2021-05-05 15:02   ` bug#47789: [PATCH 0/6] Add TLA+ Tools (tla2tools) Ludovic Courtès
2021-04-16  1:29 ` [bug#47789] " Mike Gerwitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dl3kpyd.fsf@gnu.org \
    --to=mtg@gnu.org \
    --cc=47789@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).