From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mE44BMuV8mDZcAEAgWs5BA (envelope-from ) for ; Sat, 17 Jul 2021 10:33:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yKOUO8qV8mDVCQAA1q6Kng (envelope-from ) for ; Sat, 17 Jul 2021 08:33:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0F7FA112FC for ; Sat, 17 Jul 2021 10:33:14 +0200 (CEST) Received: from localhost ([::1]:57640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4fl2-0008EA-Cy for larch@yhetil.org; Sat, 17 Jul 2021 04:33:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4fks-0008Du-4g for guix-patches@gnu.org; Sat, 17 Jul 2021 04:33:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41287) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m4fkr-0001Hm-Rd for guix-patches@gnu.org; Sat, 17 Jul 2021 04:33:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m4fkr-00060s-LY for guix-patches@gnu.org; Sat, 17 Jul 2021 04:33:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#39258] [PATCH v6 1/2] DRAFT packages: Add fields to packages cache. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 17 Jul 2021 08:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39258 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: zimoun , 39258@debbugs.gnu.org Cc: ludo@gnu.org, zimoun Received: via spool by 39258-submit@debbugs.gnu.org id=B39258.162651074623071 (code B ref 39258); Sat, 17 Jul 2021 08:33:01 +0000 Received: (at 39258) by debbugs.gnu.org; 17 Jul 2021 08:32:26 +0000 Received: from localhost ([127.0.0.1]:52833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4fkI-000603-0P for submit@debbugs.gnu.org; Sat, 17 Jul 2021 04:32:26 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:37690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m4fkF-0005zt-2P for 39258@debbugs.gnu.org; Sat, 17 Jul 2021 04:32:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9XHhE3oRkVKbYEVFBv116tBS1PpoUsm4abu55KSjdFA=; b=bLnmOToenaHnjudm+XNDAK7YgL Kwhz7T/H0UCU1qVSDsZZxrR5qVRQydKaa3xX2T17eWgG87rAZVqdDqxWHw+1Qq2wY75ZnCrbYd56X n/hauZQWyc8BXFcMPech70e0fN+jBAUXRxiYrs/J8vNCi3p0q4UeyRrtt+f7JBN1eQaQAINj5i0D7 ih/Bpwil+U53TGwtrExni2oBnjbRP+/0G44Lc3ZcqLEVf0ygRbFybLsLYipPhE3JxUwWduXjD85Yc qikSmnaHxe6WOvWFm+lKRnrnjcZhQ5bKYKlSEVGmWTp66n6OtDvnqownZiAZ2s3FwcMPAvE+XktVG D368bsDg==; Received: from [192.168.2.1] (helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m4fk0-000Bej-Po; Sat, 17 Jul 2021 14:02:08 +0530 From: Arun Isaac In-Reply-To: <20210715073328.212123-2-zimon.toutoune@gmail.com> References: <20210715073328.212123-1-zimon.toutoune@gmail.com> <20210715073328.212123-2-zimon.toutoune@gmail.com> Date: Sat, 17 Jul 2021 14:01:45 +0530 Message-ID: <877dhpmjda.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626510794; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=9XHhE3oRkVKbYEVFBv116tBS1PpoUsm4abu55KSjdFA=; b=ZC/UBhzOiSY5tFBQeMAxtpYnV4bpQe9bZ2JFaL72/bwb/aBCqz+TCHo1T8EYc/Ejc2abkv 0Kr5qVyYfXWmTlzerXysxWuVk53zMg71qA3keoFSRo3G1/8LqE0nzvHezLuAEKZiVIyeYO /OMVge82Rwp+OetVgKIjriliWoVD0G8HMsxyxU+O7G/syNCJjoG1bIwvuxyt9dfiSJyA+1 MQkYAjej/ms72xHZPuwde3ogpjOfstQEH7Wvu/KZWsvthuzH5AxoHNHTsGwQytqm62fpT6 jNmVW7f2uePe/4KL4JmEOJDy0BB3wMwvAZCj0+roJHBXsas1Hkg3mLksHHsPfg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626510794; a=rsa-sha256; cv=none; b=X0oXpnTI0eKR6VWf6aNFGNIOCZizEGD0sKmJe6R1bwoBwh4eXzsbhYJLbEN+CUL3l6Jc4b wy5CXW5uejTi3VcFmIGVDROL3yD3J6TOKQqvjMBu9SBsfBX8PpI1xXtuK8I1Nzj5Jz0oAx wTYc9J9+7dp8mrB8C7+skXwzto4Qi6Tdla/iGIOKq8FJieCtUh1u7dUSoUqzoSY/fKa5CW V9iwiBGlfeHBanB44mCaTMvJKJYcKpnbYhfoIPuUKvbmyMe3sykWIm9WFIqaI9DTOB0HC8 iojFaNIQI0AztuyiIm28hHKIlPwYoT7R24osKrHM/b+AZBTovKZsfZwkdxjaFQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=bLnmOToe; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.91 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=bLnmOToe; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0F7FA112FC X-Spam-Score: -1.91 X-Migadu-Scanner: scn1.migadu.com X-TUID: u442Ns1VVawB --=-=-= Content-Type: text/plain Hi Simon, I understand that one of the things you are trying to do is to have a common interface for the cache and no-cache cases. To achieve this, I think fold-available-packages and fold-packages should have the same function signature. They should both pass a object to PROC. Currently, fold-packages is passing a object whereas fold-available-packages is passing the fields of the object as individual parameters. If fold-packages and fold-available-packages have the same function signature, then the changes in your [PATCH v6 2/2] would be way simpler. Also, why do we need two separate functions---fold-available-packages and fold-packages? Can't fold-available-packages do everything fold-packages can and thus totally replace it? > * gnu/packages.scm (generate-package-cache)[expand-cache]: Add synopsis and > description. > (load-package-cache, find-packages-by-names, find-packages-locations): Adapt > accordingly. A couple of typos here: find-packages-by-names -> find-packages-by-name find-packages-locations -> find-package-locations Regards, Arun --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFPBAEBCAA5FiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAmDylXEbHGFydW5pc2Fh Y0BzeXN0ZW1yZWJvb3QubmV0AAoJEC4l7othgCuze+0H/RN+fBuGpE+4lRyvgxS5 uGLsQ3Y4jmg3pW/SzlFY2yBVg2AehMr06S/sxmT9HK81tKGkkxwYXD/bJz8/aWwu cv51Y0aKRBtVOtv849fByqacQ0aEhETCgF3xw/6cwH8mjfX0YHZmL8dx4flYuYrS fdpkUuRBfYVl1zxDr37IHK6eUtifsBUuRkh/4mDTHJJ2I78rfX58qOITgrRinMZX oqkhOUpJ6MXMMK1YDzwUN4ljgvvUt3FzJM/sz3zBNEKUbRGObi/qv0OCtz40/077 Bqm5hJBUNUKZt4qDZ+ANzk0rpAVx5N5ioQLiX42Yd0HeWrUMnT4NTnGuAHRP9Deg RcA= =+QtZ -----END PGP SIGNATURE----- --=-=-=--