unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Guillaume Le Vaillant <glv@posteo.net>
To: jgart <jgart@dismail.de>
Cc: bil@ccrma.Stanford.EDU, Pierre Neidhardt <mail@ambrevar.xyz>,
	51903@debbugs.gnu.org
Subject: [bug#51903] cmn license etc
Date: Mon, 22 Nov 2021 10:10:08 +0000	[thread overview]
Message-ID: <877dd0mqth.fsf@kitej> (raw)
In-Reply-To: <20211121193045.GB7334@gac.attlocal.net>


[-- Attachment #1.1: Type: text/plain, Size: 618 bytes --]

jgart <jgart@dismail.de> skribis:

> Hi everyone,
>
> It's great that this was able to be resolved.
>
> I'm looking forward to having a cmn package for guix.
>
> Guillaume would you be so kind to send your patch to Bill?
>
> Bill, would that be helpful?
>
> I can then update the guix package to use the newer version of cmn once it is released and avoid 
> having to patch the asd file.
>
> all the best,
>
> jgart

The patches I used are in attachment. Concerning the first one, it fixes
the type issue, but I don't know how to test wether running this code
produces a correct result or not.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-cmn-fix-type-issue.patch --]
[-- Type: text/x-patch, Size: 664 bytes --]

diff -Naur cmn/cmn2.lisp cmn-new/cmn2.lisp
--- cmn/cmn2.lisp	2019-01-01 15:40:00.000000000 +0100
+++ cmn-new/cmn2.lisp	2021-11-22 11:00:26.894007683 +0100
@@ -4156,7 +4156,7 @@
 			      (push (list object note-name) tied-to-notes)
 			      (format s "~%      (setf ~A ~A)" note-name (identify object)))
 			  (let ((tied-note-name (second (find (stem-tie object) tied-to-notes :test #'eq :key #'first)))
-				(tied-tag (find :tied-to (store-data object))))
+				(tied-tag (find :tied-to (store-data object) :key #'car)))
 			    (if (not tied-tag)
 				(push (list :tied-to tied-note-name) (store-data object))
 			      (setf (second tied-tag) tied-note-name))

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.3: 0002-cmn-asdf-system.patch --]
[-- Type: text/x-patch, Size: 1050 bytes --]

diff -Naur cmn/cmn.asd cmn-new/cmn.asd
--- cmn/cmn.asd	2021-11-21 15:06:47.000000000 +0100
+++ cmn-new/cmn.asd	2021-11-22 11:04:03.193342791 +0100
@@ -19,5 +19,25 @@
   :description "Common Music Notation"
   :author "William Schottstaedt <bil (at) ccmra (dot) stanford (dot) edu>"
   :licence "MIT"
-  :components ((:file "cmn-all" )))
-
+  :serial t
+  :components ((:file "cmn-init")
+               (:file "cmn-utils")
+               (:file "cmn-objects")
+               (:file "cmn0")
+               (:file "cmn-grfx")
+               (:file "cmn-glyphs")
+               (:file "cmn1")
+               (:file "cmn2")
+               (:file "cmn3")
+               (:file "cmn4")
+               (:file "rqq")
+               (:file "wedge")
+               (:file "accent")
+               (:file "pedal")
+               (:file "percussion")
+               (:file "ring")
+               (:file "rests")
+               (:file "lyrics")
+               (:file "transpose")
+               (:file "pmn")
+               (:file "quarter")))

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2021-11-22 10:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17  1:52 [bug#51903] [PATCH] gnu: Add cl-cmn jgart via Guix-patches via
2021-11-17  7:49 ` Pierre Neidhardt
2021-11-17  8:50   ` jgart via Guix-patches via
2021-11-17  9:24     ` Pierre Neidhardt
2021-11-17  8:55 ` [bug#51903] [PATCH v2] " jgart via Guix-patches via
2021-11-17 10:39 ` [bug#51903] cmn license etc bil
2021-11-21 12:51   ` Guillaume Le Vaillant
2021-11-21 14:16     ` bil
2021-11-21 16:20       ` Guillaume Le Vaillant
2021-11-21 17:45         ` bil
2021-11-21 17:54           ` Guillaume Le Vaillant
2021-11-21 19:22             ` bil
2021-11-22  0:30               ` jgart via Guix-patches via
2021-11-22 10:10                 ` Guillaume Le Vaillant [this message]
2021-11-22 14:13                 ` bil
2021-11-22 18:35 ` [bug#51903] [PATCH v3] gnu: Add cl-cmn jgart via Guix-patches via
2021-11-22 19:45   ` bug#51903: " Guillaume Le Vaillant
2021-11-22 20:11     ` [bug#51903] " jgart via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dd0mqth.fsf@kitej \
    --to=glv@posteo.net \
    --cc=51903@debbugs.gnu.org \
    --cc=bil@ccrma.Stanford.EDU \
    --cc=jgart@dismail.de \
    --cc=mail@ambrevar.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).