From: Xinglu Chen <public@yoctocell.xyz>
To: 52607@debbugs.gnu.org
Cc: Guix Together <jgart@dismail.de>,
Jorge Acereda <jacereda@gmail.com>,
Raghav Gururajan <rg@raghavgururajan.name>
Subject: [bug#52607] [PATCH] gnu: Add myrddin.
Date: Thu, 23 Dec 2021 14:32:18 +0100 [thread overview]
Message-ID: <877dbvcuql.fsf@yoctocell.xyz> (raw)
In-Reply-To: <20211218201635.17995-1-jgart@dismail.de>
[-- Attachment #1: Type: text/plain, Size: 4969 bytes --]
Hi,
jgart via schrieb am Samstag der 18. Dezember 2021 um 15:16 -05:
> Hi Guixers,
>
> This is one of the packages that we worked on in the packaging meetup today.
>
> all best,
>
> jgart
This part should go under the “---” line, otherwise they will be part of
the commit message.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add myrddin.scm.
> * gnu/packages/myrddin.scm: New file.
>
> Co-authored-by: jgart <jgart@dismail.de>
> Co-authored-by: Jorge Acereda <jacereda@gmail.com>
> Co-authored-by: Raghav Gururajan <rg@raghavgururajan.name>
> ---
> gnu/local.mk | 1 +
> gnu/packages/myrddin.scm | 66 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 67 insertions(+)
> create mode 100644 gnu/packages/myrddin.scm
>
> diff --git a/gnu/packages/myrddin.scm b/gnu/packages/myrddin.scm
> new file mode 100644
> index 0000000000..0633fb4fb2
> --- /dev/null
> +++ b/gnu/packages/myrddin.scm
> @@ -0,0 +1,66 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2021 Guix Together <jgart@dismail.de>
I am not a laywer, but is “Guix Together” a legal entity? It’s probably
better to put the authors’ names here instead.
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages myrddin)
> + #:use-module (guix build-system gnu)
> + #:use-module (guix utils)
> + #:use-module (guix download)
> + #:use-module (guix git-download)
> + #:use-module (gnu packages bison)
> + #:use-module (gnu packages pkg-config)
> + #:use-module ((guix licenses) #:prefix license:)
> + #:use-module (guix packages))
> +
> +(define-public myrddin
> + (package
> + (name "myrddin")
> + (version "0.3.1")
> + (source
> + (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/oridb/mc")
> + (commit (string-append "r" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "0acqqz74ypmjvi1yqz7g1ymyk3mmkzwqgmdd3s7s287bdy4a72gc"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:make-flags
> + (list
> + (string-append "CC=" ,(cc-for-target))
> + (string-append "PREFIX=" %output))
Nitpick: The new Gexp style could be used instead.
--8<---------------cut here---------------start------------->8---
(list
#:make-flags
#~(list (string-append "CC=" #$(cc-for-target))
(string-append "PREFIX=" #$output))
#:phases
'(modify-phases %standard-phases
(replace 'build
(lambda* (#:key make-flags #:allow-other-keys)
(apply invoke "make" "bootstrap" make-flags)
(apply invoke "make" make-flags)))))
--8<---------------cut here---------------end--------------->8---
> + #:phases
> + (modify-phases %standard-phases
> + (replace 'build
> + (lambda* (#:key make-flags #:allow-other-keys)
> + (apply invoke "make" "bootstrap" make-flags)
> + (apply invoke "make" make-flags))))))
The ‘parallel-build?’ flag should also be respected.
> + (native-inputs
> + (list bison pkg-config))
> + (home-page "https://myrlang.org")
> + (synopsis "Systems language that is both powerful and fun to use")
This sounds like an advert; I suggest
“Programming language that aims for control and simplicity”
> + (description
> +"Myrddin is a systems language that is both powerful and fun to
> +use. It aims for C like low level control, a lightweight high quality
Again, “fun” is probably not the best word. “high quality” is
subjective and as a user, it doesn’t really tell me anything.
> +implementation, and features you may find familiar from languages like
> +like rust and ocaml. This combination makes Myrddin suitable for anything
Capitalize “Rust” and “OCaml”.
Package builds fine!
--8<---------------cut here---------------start------------->8---
Result of running `guix review 20211218201635.17995-1-jgart@dismail.de': (still a WIP)
Successfully built 1 out of 1 package(s).
No lint warnings were emitted.
--8<---------------cut here---------------end--------------->8---
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]
next prev parent reply other threads:[~2021-12-23 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-18 20:16 [bug#52607] [PATCH] gnu: Add myrddin jgart via Guix-patches via
2021-12-23 13:32 ` Xinglu Chen [this message]
2022-01-14 21:17 ` Nicolas Goaziou
2022-01-14 21:26 ` jgart via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dbvcuql.fsf@yoctocell.xyz \
--to=public@yoctocell.xyz \
--cc=52607@debbugs.gnu.org \
--cc=jacereda@gmail.com \
--cc=jgart@dismail.de \
--cc=rg@raghavgururajan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).