From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gIpQNu3S6WFm/QAAgWs5BA (envelope-from ) for ; Thu, 20 Jan 2022 22:23:57 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EKaYM+3S6WFr6AAA9RJhRA (envelope-from ) for ; Thu, 20 Jan 2022 22:23:57 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 70080103CF for ; Thu, 20 Jan 2022 22:23:57 +0100 (CET) Received: from localhost ([::1]:51722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAeuR-0002YY-SQ for larch@yhetil.org; Thu, 20 Jan 2022 16:23:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAZZa-0004cv-V6 for guix-patches@gnu.org; Thu, 20 Jan 2022 10:42:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37852) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAZZa-0007mf-Jd for guix-patches@gnu.org; Thu, 20 Jan 2022 10:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nAZZa-0003xI-9H for guix-patches@gnu.org; Thu, 20 Jan 2022 10:42:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46848] [PATCHES] [core-updates] PEP 517 python-build-system Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 20 Jan 2022 15:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46848 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun , 46848@debbugs.gnu.org Cc: Maxim Cournoyer Received: via spool by 46848-submit@debbugs.gnu.org id=B46848.164269328115151 (code B ref 46848); Thu, 20 Jan 2022 15:42:02 +0000 Received: (at 46848) by debbugs.gnu.org; 20 Jan 2022 15:41:21 +0000 Received: from localhost ([127.0.0.1]:58988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAZYv-0003wI-A3 for submit@debbugs.gnu.org; Thu, 20 Jan 2022 10:41:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAZYt-0003w2-Hk for 46848@debbugs.gnu.org; Thu, 20 Jan 2022 10:41:19 -0500 Received: from [2001:470:142:3::e] (port=44102 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAZYn-0007ij-46; Thu, 20 Jan 2022 10:41:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=LrMVRFT79ZQXzhLae5b0vtznC1CRQ1FY/7CqxPMFd2U=; b=dLMEWUYAGNMd9SpgCb1I vR5V3tqCNkz20IkoNjuhq0Exucfof4ipGmbU0wUdew3iWmTsynICVbRy79SeJD2AoGynbfJ4LP2e9 +zPbXJtyiyzGHpczp8DvkqYeKPyaPlpCWZ2zl/ySLEDSKkhKMmpQa5TETsKHGMZ2nvznkKp1UjCQW yRMx2PNMMXIKd8rurWZh1T+2qT8UnFZkpLcoegYVA0/zxYcaZlkEi73rxZAiNwOhKBip79RtEBZMc 2K9wVQAaS/GGfuty6weja/nHvzgC5hRg7qLiyapb0dQevs7G+JCE9aYtEDOf6oC45dYWnEKHzSQ36 dhPpepxJHpCTBg==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:59886 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAZYn-0001ed-0o; Thu, 20 Jan 2022 10:41:13 -0500 From: Marius Bakke In-Reply-To: References: Date: Thu, 20 Jan 2022 16:41:09 +0100 Message-ID: <877daubeju.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642713837; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=LrMVRFT79ZQXzhLae5b0vtznC1CRQ1FY/7CqxPMFd2U=; b=NgziwL/j2kaAK1ZbtAdqU6sxJjh4qUBTfoflnyZoNrBLB2VoF3CcmaI7iXwfNKJKI8ziKF fzUSuJec9YRIQpwu7IqeVie2rUFYC5IUz7lVd2G7gVT4WVqCqo3mGb8gluUN2Y3KiehUZS WUaA5bsrYq3mqYGhFU/gk/A/x8APGkWG3I0UjkawMM7vbmogcRi6nqC9bgAx7/4LxHnlBq 7KrfCihLHR4uDAO35dnIKlTeprGbcnnIxD7DWwT0nY1/0QItfQmNp4TCpmNN/eBpNT+uEO Vtl9KSEQ3KBcKBsfa29CeQXyeDKuqkp1SFIbmM3rFbzyUvlTLf46+iPkZ/8cqQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642713837; a=rsa-sha256; cv=none; b=TzOKGzA1n7SCarFYRr0gCjaIDYPHiB9ybTG5dxktgyWUzS15FEwrqbiy+iX9DfD8n6rpiN uvAWwPmsptJ/ZUdXerIq6NVsX3XbXnWbiJYPaRvZwZuE7oA6ZVyqu8+d7ZJvbrrBdIEf5V Jqq8aqYbVetQ82OvXDbGehYNlmXuLwPNFq+I2TQ8gp5LdU2+dj90wWW3RD2O+G1Zp1JCBb L1tJd8zmZFj1uGxKwFkY/THSn28Xw4jtNi1G5py53J7fKrKpw2QSBsDQmGEcbDPy1fyrCH SFzltZ7FTtYxltEjY3umx171JL8usjGLdg+ovhrMKvVj4hGfRozU0kPaAXCgtg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=dLMEWUYA; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.52 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=dLMEWUYA; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 70080103CF X-Spam-Score: -6.52 X-Migadu-Scanner: scn0.migadu.com X-TUID: pEh/bzsm4Odh --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Lars-Dominik Braun skriver: > I pushed the 3rd version of my new PEP 517-based python-build-system > into wip-python-pep517. I removed the dependency on python-pypa-build > for building packages and instead implemented building with a single > python invokation. This simplifies bootstrapping Python. The 'install > phase also learned how to create scripts in bin/ from an entry points > specification. This is great, thank you. > Currently 600 of 2212 packages using python-build-system are failing to > build. That=E2=80=99s alot, but most failures so far were related to test= suites, > which were not enabled correctly previously because 'check was not > replaced manually. And some fail because upstream does not separate > sources and tests and a name clash occurs. This also happens when C > extensions are build and there does not seem to be a workaround. Can you elaborate on the name clash issue? > This number does not include Python 2 packages, which will probably > break with this new build system. Since Python 2 is EOL anyway I suggest > to entirely remove Python 2 support before merging this changeset. After > merging we should upgrade the entire Python ecosystem, because alot of > packages are already years old. Unfortunately we need Python 2 for some time still. It is used to bootstrap old versions of GHC, Node, and probably other things. Do you think it is feasible to provide this as a new build system, say pep517-build-system, during a transitional period? Then we can a) start using it right away for the increasing amount of packages that lack a setup.py; and b) flesh out most bugs before eventually merging it back (possibly piecemeal) into python-build-system. I've had a cursory look and it looks good overall. A few comments: * Zipping a wheel just to unpack it afterwards is weird, but there seems to be no way around it. * I also think trying "python setup.py test" is unnecessary. * It would be nice to support the "no tests" case without having to add explicit #:tests? everywhere. Perhaps along the lines of... (match use-test-backend ('pytest (apply invoke ...)) [...] (_ (match (find-files "." "^test_.*\\.py$") (() (format #t "no tests found~%")) (_ (apply invoke `("python" "-m" "unittest" ,@test-flags)))))) WDYT? Great work, and apologies for not chiming in earlier! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYemClQ8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHekigD/fOVOE7lCfRW0OuNWk9gGTLOZOQpqO8+MmiJI CaWULd4A/3mf5Srz1hublc4NlZMb5NanVzduIrpl7YlBn1XN2NMJ =JNtc -----END PGP SIGNATURE----- --=-=-=--