From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GLQgO6Sh82HHkAAAgWs5BA (envelope-from ) for ; Fri, 28 Jan 2022 08:56:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id IKGxN6Sh82HGEAEAauVa8A (envelope-from ) for ; Fri, 28 Jan 2022 08:56:20 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6B13816A0B for ; Fri, 28 Jan 2022 08:56:20 +0100 (CET) Received: from localhost ([::1]:33222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDM7G-0002g1-Gp for larch@yhetil.org; Fri, 28 Jan 2022 02:56:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDM70-0002eK-Oh for guix-patches@gnu.org; Fri, 28 Jan 2022 02:56:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36056) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDM70-0001n1-ES for guix-patches@gnu.org; Fri, 28 Jan 2022 02:56:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nDM6z-0000lk-Vg for guix-patches@gnu.org; Fri, 28 Jan 2022 02:56:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53472] [PATCH v4] gnu: Add emacs-nim-mode Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 28 Jan 2022 07:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53472 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53472@debbugs.gnu.org Cc: paren@disroot.org X-Debbugs-Original-To: "(unmatched-parenthesis via Guix-patches" via X-Debbugs-Original-Cc: 53472@debbugs.gnu.org, "\(unmatched-parenthesis" Received: via spool by submit@debbugs.gnu.org id=B.16433565522941 (code B ref -1); Fri, 28 Jan 2022 07:56:01 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jan 2022 07:55:52 +0000 Received: from localhost ([127.0.0.1]:57192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDM6q-0000lM-2Q for submit@debbugs.gnu.org; Fri, 28 Jan 2022 02:55:52 -0500 Received: from lists.gnu.org ([209.51.188.17]:35258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDM6o-0000lF-Tr for submit@debbugs.gnu.org; Fri, 28 Jan 2022 02:55:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDM6l-0002cB-9S for guix-patches@gnu.org; Fri, 28 Jan 2022 02:55:50 -0500 Received: from [2001:4b98:dc4:8::232] (port=47593 helo=relay12.mail.gandi.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDM6h-0001mJ-UX for guix-patches@gnu.org; Fri, 28 Jan 2022 02:55:46 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay12.mail.gandi.net (Postfix) with ESMTPSA id BD4F8200002; Fri, 28 Jan 2022 07:55:27 +0000 (UTC) From: Nicolas Goaziou References: <20220123133837.1035-1-paren@disroot.org> <20220124201247.30159-1-paren@disroot.org> Date: Fri, 28 Jan 2022 08:55:26 +0100 In-Reply-To: <20220124201247.30159-1-paren@disroot.org> (guix-patches@gnu.org's message of "Mon, 24 Jan 2022 20:12:47 +0000") Message-ID: <877dakxpjl.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4b98:dc4:8::232 (failed) Received-SPF: pass client-ip=2001:4b98:dc4:8::232; envelope-from=mail@nicolasgoaziou.fr; helo=relay12.mail.gandi.net X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643356580; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=osxAk8eEZE+ZHYjbaRycf4q0EjUR3qJC5Hcgg4vz4E0=; b=HS7wXZDzAnGLGJx2PbZBu0dUO0EmmeB7FJUTnQ2eWXDsYQ9hJO//sbjhZ64WSkAfvdt8t7 ywG5Jka7KuZS29p6fg+Ic/hO1qrh7V0qddQBZwVB3h3LChR9M6XpsRoNV3x6mv54iK4Zv/ JstzQz2RjFuQWh+pI+NGyw2YgNvlqvh2hWLCgGIHDriW+p9gZ4D86ae4XCXBCJzqBD8Z+b +3oknl78NFDIN5rEY/fcUcDgkWeo8CGyyGvcNixxLlAJy6U6c+fRZplPuPC0+YuqXAVbGe u2PxclEDwC3vSx24/7lzsE89rIrGajeHs9LsbXDbPmHoZB7tuEwjbXpmOqyaGQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643356580; a=rsa-sha256; cv=none; b=lzQ4EVUU0bFarNIAVigcgxmRlrNf6KAG2jQ1+/Sz9l5P9Z+hpV0dMjFgBonZq6TcfKxhAE lQZn/2Hn9q7tZ5ie+n59zrhclJ4DqQXrAIx6I1Y8K7e8O9OxBHznt66Yj8v8WqzCMzwdp2 jdn/Yljsf6B6bte1VeACrhZE4FMKdx5DQXpxMJbEaO0vCnAQku5VvR/GOWAYFG847Anth9 b0YMEB2lUVIzkjoWllXf5PjmotgmyhXA3GefIYEIlsRIj+TFFT6y3xqCBTD9RkMQhzFg22 SruHHAeHF/1AceR1PWlPa4mhXdZaceRoB2CvXT/IU6ego4SuzYRxkJij5QQbPg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.33 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6B13816A0B X-Spam-Score: -3.33 X-Migadu-Scanner: scn1.migadu.com X-TUID: jWHv0RcXumQN Hello, "(unmatched-parenthesis via Guix-patches" via writes: > * gnu/packages/emacs-xyz.scm(emacs-nim-mode): New variable. Thank you. You add both emacs-nim-mode and emacs-commenter. Could you split the patch into two parts? > + (uri (string-append "https://github.com/yuutayamada/commenter/archive/refs/tags/v" version ".tar.gz")) These URI are not stable. You should use git-fetch with commit (string-append "v" version) instead. > + (sha256 > + (base32 "1n9m8f4gflb0c3nh98nkmsqzscyf5d1p1gcz8apskkmf7z0z0q2j")))) > + (build-system emacs-build-system) > + (home-page "https://github.com/yuutayamada/commenter") > + (synopsis "Allows you to set both single and multi line comment variables like @code{comment-start} or @code{comment-end} etc.") The synopsis is too long: "Set both single- and multi-line comment variables in Emacs" > + (description "This package allows you to set both single and multi line comment variables like @code{comment-start} or @code{comment-end} etc.") I suggest to drop the "etc." since there is "like" before. "This Emacs package sets both single- and multi-line comment variables like @code{comment-start} or @code{comment-end}." > +(define-public emacs-nim-mode > + (let ((commit "744e076f0bea1c5ddc49f92397d9aa98ffa7eff8") > + (revision "0")) Since you're not using a tagged commit, could you put a comment above the let binding explaining why? > + (synopsis "Major mode for editing Nim source code") I would add "Emacs": "Emacs major mode for editing Nim source code" > + (description "This package provides major modes for Nim: > ++@itemize > ++@item Syntax highlighting for Nim code, Nimble configuration files, and nim.cfg > ++@item `M-x nim-compile`, which can also be invoked with `C-c C-c` inside a Nim source file > ++@item File outline by procedures > ++@item Indentation and line breaking (alpha) > ++@item Integration with nimsuggest, the Nim linting and completion server (alpha, both nimsuggest-mode and nimsuggest itself are currently VERY unstable and may make emacs much less responsive) > ++@end itemize") I suggest: This package includes major modes for Nim. In particular, it provides syntax highlighting for Nim code, Nimble configuration files, and @file{nim.cfg}, outlining features, a dedicated compilation command, indentation and line breaking. It also implements integration with @code{nimsuggest}, the Nim linting and completion server, although this is currently unstable. > + (license license:gpl3+)))) Could you send an updated patch? Regards, -- Nicolas Goaziou