unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 53930@debbugs.gnu.org
Subject: [bug#53930] [PATCH] gnu: Add emacs-nyan-mode.
Date: Thu, 10 Feb 2022 23:58:09 +0100	[thread overview]
Message-ID: <877da2uy66.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <84aaa5ac2f6e4399fae554b274742c776c26fccf.camel@gmail.com> (Liliana Marie Prikler's message of "Thu, 10 Feb 2022 21:56:49 +0100")

Hello,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-nyan-mode): New variable.

And I thought Guix was a serious distribution… ;)

> +(define-public emacs-nyan-mode
> +  (package
> +    (name "emacs-nyan-mode")
> +    (version "1.1.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://stable.melpa.org/packages/nyan-mode-"
> +             version
> +             ".tar"))

Using anything MELPA is generally frowned upon. What are the reasons for
not using upstream releases instead?

> +       (sha256
> +        (base32 "1hd3g1lnwsg7z3g9qvshlmlirgzyja4hjxxgdfpkaakafm87n58c"))))
> +    (build-system emacs-build-system)
> +    (arguments (list #:include #~(cons* "img/" "mus/" %default-include)))
> +    (home-page "https://github.com/TeMPOraL/nyan-mode/")
> +    (synopsis "Nyan Cat as position indicator")

Maybe: Nyan Cat as position indicator in a buffer

> +    (description
> +     "Nyan Mode is an analog indicator of your position in the buffer.  

I know the project name is "nyan mode" but still:

Nitpick: Nyan mode is…

Otherwise LGTM.

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2022-02-10 23:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 20:56 [bug#53930] [PATCH] gnu: Add emacs-nyan-mode Liliana Marie Prikler
2022-02-10 22:58 ` Nicolas Goaziou [this message]
2022-02-11  5:10   ` Liliana Marie Prikler
2022-02-11  9:19     ` Nicolas Goaziou
2022-02-11 20:22       ` Liliana Marie Prikler
2022-02-11 20:23         ` bug#53930: " Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877da2uy66.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=53930@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).