From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aJPuHxDja2KcrwAAbAwnHQ (envelope-from ) for ; Fri, 29 Apr 2022 15:07:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id IF9SHxDja2LwswAAG6o9tA (envelope-from ) for ; Fri, 29 Apr 2022 15:07:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0B2A6242B7 for ; Fri, 29 Apr 2022 15:07:27 +0200 (CEST) Received: from localhost ([::1]:32974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkQLH-0000kN-0P for larch@yhetil.org; Fri, 29 Apr 2022 09:07:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkQKs-0000Ts-7h for guix-patches@gnu.org; Fri, 29 Apr 2022 09:07:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nkQKr-0000q9-VO for guix-patches@gnu.org; Fri, 29 Apr 2022 09:07:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nkQKr-0000kg-QM for guix-patches@gnu.org; Fri, 29 Apr 2022 09:07:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54796] [PATCH v3 00/22] Add importer for hex.pm and rebar3 build-system for Erlang Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 Apr 2022 13:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54796 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 54796@debbugs.gnu.org Received: via spool by 54796-submit@debbugs.gnu.org id=B54796.16512375892850 (code B ref 54796); Fri, 29 Apr 2022 13:07:01 +0000 Received: (at 54796) by debbugs.gnu.org; 29 Apr 2022 13:06:29 +0000 Received: from localhost ([127.0.0.1]:51213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nkQKL-0000jt-Fy for submit@debbugs.gnu.org; Fri, 29 Apr 2022 09:06:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nkQKK-0000jh-3H for 54796@debbugs.gnu.org; Fri, 29 Apr 2022 09:06:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48098) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkQKE-0000iP-7W; Fri, 29 Apr 2022 09:06:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=jKhwj/TFdSpE/qVYevCJ0j4TP/iLoT+9qm/wexprU44=; b=fGLA8YOVZoJkO1szIWkT d/vHbD6X30BUFRSiELkbTH2lE5BcK6P6Ys+h+Ax6NrRnJKwxwkc5VOguTVifEmfFBRxSqMSp6bS7z 3tLjTxTayD016+GPL7uSn93T7in1fb0OOEqfxwbpPxBmeyVSI1ctno378vonXuy3gTZTtnNcbBvEi OIVffwkrBvUECBNwPuGkedbzS2PtUIPTnbkyD5pG4EKLSg3nkolXzc8fUZ0/Znos614z4v7nA1A/6 kqViaH2XfSoGiASvKvh7kpiSUruhpEoNOAHoyPfvX6QbbHll5OrWCsZQBRYbdL/KW1FWhqoQ49fKP wxr1VblKwoAAdQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=48970 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkQKB-0005xJ-I0; Fri, 29 Apr 2022 09:06:22 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Fri, 29 Apr 2022 15:06:16 +0200 In-Reply-To: (Hartmut Goebel's message of "Sun, 10 Apr 2022 20:57:00 +0200") Message-ID: <877d7882ev.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651237648; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jKhwj/TFdSpE/qVYevCJ0j4TP/iLoT+9qm/wexprU44=; b=K9GCDi90LLBTfDJ2wOQt/eqZoWwEyCyfJ0F83zj3iP5jHBWSycwdiM/4AMh4LvrNIjuWYR lKs1mOqS5KJl7IUnyYA/tFJdykOG+TGvK91nMQGKKSN8ATweoPip/HdRSqFWtT/rIZNqjW 8Cl0linlrAC4aNi9To96XwArKEwXDnpvH2Sz2f5Y2eNMRkrJcLZdHcgbctCAjEDt0JUOD2 aGC81rPjTtKrfJiuT8nwCUV9DEHQ60C80Vkl27Pv5ZHSNUOU/LofFL7eUl3aObLLFpAWAk VXroa5BS2p9d2hVFrd2DyQsxDH9uJg7K9G25pUxNtffkVyRuIZNnRUw7Qy7sGg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651237648; a=rsa-sha256; cv=none; b=AqzaMqzHdt0fHiTQiJ3MpREdP97XvIkDdpFESSB7ufZpDOUHdqA6D5HeF1eSVKBtUTRgcP 8DSZuXFkgtZfxhwkUSMWaFy0zMNYndNyeuwCllokdqh+i5Te1hlTe6SSlvXeRqqJOXi4JE BXG/exlUqA5YJPF0UTB4isbsJhFmqnwM7LA/HfwSqNSD9abMw+VZV/mlwhwcOf0m6WRc+9 K7d1j/JXhEmUFIomIS8IcOPUZaD1m1pNQhiJDUYkhoZW87IbhAny3xQD8dIKflhVkpPcrC qOr5W1++1um2bDmIZPmMr9/y0RNaZvIgQgo58hRl+DG+uA6/uZ9BnNbYCxMheg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=fGLA8YOV; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.90 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=fGLA8YOV; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0B2A6242B7 X-Spam-Score: -3.90 X-Migadu-Scanner: scn1.migadu.com X-TUID: 2kYnL3ifYAb+ Hi, Hartmut Goebel skribis: > * guix/build-system/rebar3.scm, guix/build/rebar3-build-system.scm: New f= iles. > * Makefile.am (MODULES): Add them. Please mention the guix.texi changes here. > +@defvr {Scheme Variable} rebar3-build-system > +This variable is exported by @code{(guix build-system rebar3)}. It > +implements a build procedure around @code{rebar3}. Please provide a bit more context, like: =E2=80=9C[=E2=80=A6] around @uref{http://example.org,rebar3}, a build system for programs written in the Erlang language.=E2=80=9D > +source. If this file exists, it will be unpacked, too. This eases > +handling of package hosted by @i{hex.pm}. Rather: =E2=80=9Chosted at @uref{https://hex.pm/}, the Erlang package repository.=E2=80=9D > + (lambda (*) > + (for-each > + (lambda (dirname) > + (let ((src-dir (string-append lib-dir "/" * "/" dirname)) > + (dst-dir (string-append pkg-dir "/" dirname))) > + (when (file-exists? src-dir) > + (copy-recursively src-dir dst-dir #:follow-symlinks? #t)) > + (false-if-exception > + (delete-file (string-append dst-dir "/.gitignore"))))) > + '("ebin" "include" "priv"))) =E2=80=9Cebin=E2=80=9D and =E2=80=9Cpriv=E2=80=9D are non-standard director= y names. It would be ideal to avoid them, unless this is a hard requirement for Erlang/rebar3? Otherwise LGTM! Thanks, Ludo=E2=80=99.