unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: "Erik Šabič" <erik.sab@gmail.com>
Cc: 55558-done@debbugs.gnu.org, guix-patches@gnu.org
Subject: bug#55558: [PATCH] gnu: emacs-list-utils: update to latest commit
Date: Thu, 26 May 2022 21:49:22 +0200	[thread overview]
Message-ID: <877d686oyv@nckx> (raw)
In-Reply-To: <20220521100117.7776-1-erik.sab@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]

Erik,

Thank you!

This build failure was bugging a lot of people, so I pushed your 
fix as commit c5d68c6d12e691bceba60bc9537ea499bb50273d, with a 
message matching out conventions.
Please take a look.

For example, we use a specific ‘gnu: foo: Update to $VERSION.’ 
title, and again in the changelog section.

Erik Šabič 写道：
> * gnu/packages/emacs-xyz.scm (emacs-list-utils): [version] The 
> latest
> commit (0dec8c02962d2591766739e37c5714ba21133093) contains both 
> the
> patch-require-cl, which I removed, and calls to 
> define-obsolete-function-alias
> are made with 3 arguments instead of 2, which is necessary to 
> compile with
> Emacs 28.1

I moved this comment to the code.  Comments like this almost 
*never* belong in commit messages.  Who reads those — in context — 
after a week?

Thanks again!

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

      reply	other threads:[~2022-05-26 20:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-21 10:01 [bug#55558] [PATCH] gnu: emacs-list-utils: update to latest commit Erik Šabič
2022-05-26 19:49 ` Tobias Geerinckx-Rice via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877d686oyv@nckx \
    --to=guix-patches@gnu.org \
    --cc=55558-done@debbugs.gnu.org \
    --cc=erik.sab@gmail.com \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).