unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "Raghav Gururajan" <rg@raghavgururajan.name>
Cc: Morgan.J.Smith@outlook.com, 56382@debbugs.gnu.org
Subject: [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup
Date: Fri, 15 Jul 2022 15:02:02 +0200	[thread overview]
Message-ID: <877d4e8r79.fsf@gnu.org> (raw)
In-Reply-To: <ff47ca4d7bfe0148f827dac382ca6211@raghavgururajan.name> (Raghav Gururajan's message of "Wed, 13 Jul 2022 08:54:37 +0000")

Hi,

"Raghav Gururajan" <rg@raghavgururajan.name> skribis:

>> Does simply adding ‘hicolor-icon-theme’ to ‘inputs’ fix the issue?
>
> Most gtk-based apps expect hicolor-icon-theme and adwaita-icon-theme to be in the profile. Adding these in either system or user profile would prevent this error from occurring.

Right, so the proposed patch (adding ‘hicolor-icon-theme’ to ‘inputs’,
not ‘propagated-inputs’) shouldn’t make any difference I guess?

>> Unfortunately, Gajim fails to build for me as described in
>> <https://dev.gajim.org/gajim/gajim/-/issues/10478>.
>> 
>> Raghav, what should we do about it? The issue above is closed, but are
>> we missing the fix?
>
> That's odd. The upstream removed those obsolete test files which were causing the build failure. Could you please confirm the commit and system-architecture you tried to build on?

I retried and this time it passed.  Perhaps it’s non-deterministic?
Maybe has to do with running tests in parallel?

Thanks,
Ludo’.




  parent reply	other threads:[~2022-07-15 13:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-04 13:43 [bug#56382] [PATCH] gnu: gajim: Use hicolor-icon-theme to avoid crashing on startup Morgan.J.Smith
2022-07-12 22:15 ` Ludovic Courtès
2022-07-13  8:54 ` Raghav Gururajan via Guix-patches via
2022-07-13 16:06   ` Raghav Gururajan via Guix-patches via
2022-07-15 13:02   ` Ludovic Courtès [this message]
2022-07-16  1:38     ` Maxim Cournoyer
2022-07-18  9:29       ` Ludovic Courtès
2022-07-18 13:33         ` [bug#56382] bug#20255: " bokr
2022-07-18 15:19       ` Raghav Gururajan via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877d4e8r79.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=56382@debbugs.gnu.org \
    --cc=Morgan.J.Smith@outlook.com \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).