From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id FrgvHkLX7GJWDgAAbAwnHQ (envelope-from ) for ; Fri, 05 Aug 2022 10:39:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 1WsdHELX7GK0NwAAG6o9tA (envelope-from ) for ; Fri, 05 Aug 2022 10:39:30 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3BB2C2DED2 for ; Fri, 5 Aug 2022 10:39:30 +0200 (CEST) Received: from localhost ([::1]:38232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJsrg-0003X0-Ur for larch@yhetil.org; Fri, 05 Aug 2022 04:39:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJslT-0006xl-3L for guix-patches@gnu.org; Fri, 05 Aug 2022 04:33:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38109) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJslS-0007Zs-Le for guix-patches@gnu.org; Fri, 05 Aug 2022 04:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJslS-00066d-Ei for guix-patches@gnu.org; Fri, 05 Aug 2022 04:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56867] [PATCH] download: Do not wrap TLS port on GnuTLS >= 3.7.7. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 Aug 2022 08:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56867 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 56867@debbugs.gnu.org, guile-devel@gnu.org Received: via spool by 56867-submit@debbugs.gnu.org id=B56867.165968833623414 (code B ref 56867); Fri, 05 Aug 2022 08:33:02 +0000 Received: (at 56867) by debbugs.gnu.org; 5 Aug 2022 08:32:16 +0000 Received: from localhost ([127.0.0.1]:56091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJskh-00065a-HU for submit@debbugs.gnu.org; Fri, 05 Aug 2022 04:32:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJskc-00065H-PZ for 56867@debbugs.gnu.org; Fri, 05 Aug 2022 04:32:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33864) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJskW-0007Oc-Jx; Fri, 05 Aug 2022 04:32:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=fGDz28zEFuqRmW7TgnfRI6AcHBg/aKDvaQ+j2NRHYlo=; b=oMIUzWDBYQoIL6CoCCI2 KBNDu1O0Kug4QGBQXqcyRwRPH29etnHwc672Zt/gOXRb71JchgznV2LDFVp9AMxzxM/VvrvsFKXrl hdElyVTch+51DB4R52u2za/h9hczJkp7xxokJNqvbqaFpR9O2sF14d66EL3/cELngrcBHxfrIHUCh 3S7bOCLjTdqjQejriiYi82Ub4uC2AHbthNbttJLfd7Ym6h6N3NH/nZxybBu8nc09C6gOxDfj/lkq0 I+9xzjBeOh2jUtBN1BSfsyZxJcX8T/Bt/J+1CxeyPIHZqgBrvJapSeqxbUM96U0K3wwAK5lnk9tzt +AqRwf6awSZWDg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=46964 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJskT-00018K-PQ; Fri, 05 Aug 2022 04:32:04 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220801090749.11655-1-ludo@gnu.org> <87pmhjuld1.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 18 Thermidor an 230 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de l'Amande X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 05 Aug 2022 10:31:58 +0200 In-Reply-To: (Maxime Devos's message of "Thu, 4 Aug 2022 21:37:44 +0200") Message-ID: <877d3njdkx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659688770; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=fGDz28zEFuqRmW7TgnfRI6AcHBg/aKDvaQ+j2NRHYlo=; b=amvfa0N/v5XvDiMyot1vNO+4sfFx+E6XOnbVuZqlg7FmcposUGNxuVcKCvCczXj3yNjEn/ SZm8rnGS0hbGZG3l7ZgAcV7oRJsp0Jqvh+jVADLgIWF5IysxqoQHFui6NhFFC9BsP5V8OQ 3x7UcojnI+tuXvAbXGCI7v177SnE0cx5zyesg5DAVoHhV3kurdOl0T/1WDbsZfZPbRON64 Gd1Tnatn0/MZ7SLM1S81lCPit32K2g19SXWEqvAOmvH1mzbgYl1/PvCpq9qXDy7yKJOO5g oN0Hd88J9tDYGoy0nlRRdvwaODZq6d+dMZgOgYLprL1gTUwuyJYfoI4THiPubQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659688770; a=rsa-sha256; cv=none; b=GRpNTavTFNYcLcfdcmRruDkfJYHusaeMiQhA12KfVwmpxHx8W7QHR5Qj/Y+b9TOJqUPEtO C/JCA1ZDB9WTnn0wiMB7VEBxRTFubSbrJGgFP3RmpjIRypYoyI1Kj1jxUscFfMGmHTcAO5 TRBYM9/t/t1hMA4oqUJCMLF6AseIuY5LEkLDofrNGUPIfZh4J8/s9HpPsgfQFuh62g3JTE GiDh1StlzMrVSYCe5davwwkI+EASbUBfXpDJBnOwCF4xOH3NFxZwxeoooxCrAfscSa6dyc FSE1o7vvNyAFe/5CNssspw3vjWTqdwSedqWhrwAeWqosmMVhP4JoUUf/4sPdWA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=oMIUzWDB; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=oMIUzWDB; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3BB2C2DED2 X-Spam-Score: -4.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: bzGAtDnmSsLA Hi, Maxime Devos skribis: > On 02-08-2022 09:59, Ludovic Court=C3=A8s wrote: >>>> + (if (module-defined? (resolve-interface '(gnutls)) >>>> + 'set-session-record-port-close!) ;GnuTLS >= =3D 3.7.7 >>> resolve-module (and presumably also sets #:ensure #t by default, which >>> sometimes causes 'module not found' messages to be replaced by >>> 'unbound variable', which I don't think is useful behaviour, can >>> #:ensure be set to #false? >> This is unnecessary: see the =E2=80=98load-gnutls=E2=80=99 mechanism the= re. The idiom >> above is already used in a couple of places. > > I have looked at the 'load-gnutls' procedure, but I do not see how it > avoids the issue I mentioned (*). [...] > (*) The autoloading of gnutls in load-gnutls avoids compilation errors > when gnutls is absent, but by the way it does it, it causes the module > to be registered as 'it exists' even when it doesn't, so the > information in the module system of Guix becomes incorrect. I understand what you=E2=80=99re saying (I=E2=80=99m quite familiar with Gu= ile=E2=80=99s module system :-) and I do agree that #:ensure #t can lead to bad surprises), but I don=E2=80=99t think this is correct: --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> (resolve-interface '(xxx)) ice-9/boot-9.scm:1685:16: In procedure raise-exception: no code for module (xxx) Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue. scheme@(guile-user) [1]> ,q scheme@(guile-user)> (resolve-module '(xxx) #f #:ensure #f) $1 =3D #f --8<---------------cut here---------------end--------------->8--- This is because =E2=80=98resolve-interface=E2=80=99 does (resolve-module = =E2=80=A6 #:ensure #f). Does that make sense? Thanks, Ludo=E2=80=99.