From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4JWQNZcJAGMPugAAbAwnHQ (envelope-from ) for ; Sat, 20 Aug 2022 00:07:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id CNGMNZcJAGPnbwAA9RJhRA (envelope-from ) for ; Sat, 20 Aug 2022 00:07:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 77657DC82 for ; Sat, 20 Aug 2022 00:07:19 +0200 (CEST) Received: from localhost ([::1]:34136 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oPA97-0001Sh-UJ for larch@yhetil.org; Fri, 19 Aug 2022 18:07:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPA8t-0001SO-Ay for guix-patches@gnu.org; Fri, 19 Aug 2022 18:07:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41395) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oPA8s-000400-So for guix-patches@gnu.org; Fri, 19 Aug 2022 18:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oPA8s-0005QO-Fq for guix-patches@gnu.org; Fri, 19 Aug 2022 18:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#32947] Add java-xalan. Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Aug 2022 22:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32947 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Frank Pursel , 32947@debbugs.gnu.org, maximedevos@telenet.be Received: via spool by 32947-submit@debbugs.gnu.org id=B32947.166094677020774 (code B ref 32947); Fri, 19 Aug 2022 22:07:02 +0000 Received: (at 32947) by debbugs.gnu.org; 19 Aug 2022 22:06:10 +0000 Received: from localhost ([127.0.0.1]:59377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPA81-0005P0-Cl for submit@debbugs.gnu.org; Fri, 19 Aug 2022 18:06:09 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:33992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPA7w-0005OF-8R for 32947@debbugs.gnu.org; Fri, 19 Aug 2022 18:06:07 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:20]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 1C0F71ABC5; Fri, 19 Aug 2022 15:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1660946757; bh=yilTCMA4xlW+pJtab7itDyebgkYF4lWwYiFjyRerCus=; h=From:To:Subject:In-Reply-To:References:Date:From; b=AwN+4464+/me4C9ciC4QNb1MeQp057vJukGmTzY21uwHubgZdaa66Sy3YN3dL+Ecq y1zvrEifYLQZVWG2gdo0y3H6cPL0wcWeETEAHjowWLnby8bJWRbecjw+Oh1VDkXUwc vFIoRk4FFjn6uSJFdojxiTG2HXDd6AzC1BazuCAygwYRaM4K0ab4wp7xaLoyY7HbIM 7XynGDxKy0paGFgCFEAgyHvUdDz1ygfPnzjDdwoqaZ4zQCODPYqkWZ29Vky0JOqATL Uw/PA5ruDiybYjen3GbfTcGCxkCHK90/leAVokRv8hg7nLO8Wl803IimECbiQ1DLaX 7FOEARf+LIEZA== From: Vagrant Cascadian In-Reply-To: <87wngkdacr.fsf@Ginko.local.i-did-not-set--mail-host-address--so-tickle-me> References: <20181005151859.9616-1-dannym@scratchpost.org> <87wngkdacr.fsf@Ginko.local.i-did-not-set--mail-host-address--so-tickle-me> Date: Fri, 19 Aug 2022 15:05:51 -0700 Message-ID: <877d33khxc.fsf@contorta> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660946839; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=iPmF119eqHb46+eBSq2KQP7Mk0VFkk2br46RmqZyBrM=; b=APnKx9F02Z0KW31Jn7EK+y9SssF2oDsYqpibinenESs2mMArOq1N1jsvB+leak9dJTb7VS emNEEGOK9Zjr5ApERPzhYUSP7LkeIe/diX2pxIVmCGStvjCiyG6qcaxQKb3XHOhf1kwcBy mlXNAzoQ8HPtVi4m5YhLbt0I7ItxjQi0+6ODQRhB2YqNoavlZ2b8VnWG/Ixu4Z5BQ0mNyc vTxrvsdcXoONCkGHCliMx9JfOeW5xoPAbcegff+DTZGQSj03fkVvE4GjToIuqAsI35Xhkn vxFlnVlYSW8tID2XmK1uqNSyO4Y3wfnGW08AilllagDJBSOs25vSnER4H6vkCg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660946839; a=rsa-sha256; cv=none; b=XV61NKY6WX0qEEADiTi3ZQfj9JMOtEmpIDD68MlWw4NDCAk4BCizdQ+x5A029i6yJjTwku LVFIValaqrDVFo9AQ93MM2/OGOeq170RtmS/vxmRTBzv4Hj6hR9/IreOCajNi0UdM+52DE 7PenfRaENB1oA+ZdX3fyOFzODrpVX5mn1ljDIewg3snI7xDZY4hniYOA3Xlm5GvoE1ZrGN FZLIPx2fiveze4VHKWLnV4Qmmy1l1y2zu5zpwJZgEx+o5TZIukPlfa2uKU2QkV91DbfxJV vK0+m4he0EOJeBnbRL9lLjL50datt4Jv6jyG4K3C+c96Nhl2jK+kxmkyCRkepg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b=AwN+4464; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.55 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b=AwN+4464; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 77657DC82 X-Spam-Score: -1.55 X-Migadu-Scanner: scn0.migadu.com X-TUID: zS+UOowODhRh --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2022-03-23, Frank Pursel wrote: > Oops, I, somehow, dropped some prior work. I think it's now all here. > > From f9c96acbf38ecbe3dc0e73077f92c6a8be1eb93d Mon Sep 17 00:00:00 2001 > Message-Id: > From: Frank Pursel > Date: Wed, 23 Feb 2022 13:59:26 -0800 > Subject: [PATCH] gnu: Add java-xalan-interp > > * gnu/packages/xml.scm (java-xalan-interp): New variable > --- > gnu/packages/xml.scm | 66 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 66 insertions(+) > > diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm > index 3ce5e771c7..a4d77b51d7 100644 > --- a/gnu/packages/xml.scm > +++ b/gnu/packages/xml.scm > @@ -33,6 +33,8 @@ > ;;; Copyright =C2=A9 2021 Guillaume Le Vaillant > ;;; Copyright =C2=A9 2021 David Larsson > ;;; Copyright =C2=A9 2021 Matthew James Kraai > +;;; Copyright =C2=A9 2022 Frank Pursel > +;;; Copyright =C2=A9 2022 Maxime Devos > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -2592,3 +2594,67 @@ (define-public python-xmltodict > (description "This package provides a Python library to convert XML = to > @code{OrderedDict}.") > (license license:expat))) > + > +(define-public java-xalan-interp > + (package > + (name "java-xalan-interp") > + (version "2.7.2") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "mirror://apache/xalan/xalan-j/source/xalan-j= _" > + (string-replace-substring > + version "." "_") > + "-src.tar.gz")) > + (sha256 > + (base32 "166vg9i11qzi0vbv09abfb50q8caq8wr6zrwg0cwqws9k394l62w")) > + (modules '((guix build utils))) > + (snippet '(begin > + (for-each > + delete-file > + (cons*=20 > + ;; jflex and cup generated files > + ;; for removal > + "src/org/apache/xalan/xsltc/compiler/XPathLexer.jav= a" > + "src/org/apache/xalan/xsltc/compiler/XPathParser.ja= va" > + ;; Removing bundled jars > + (find-files "." "\\.(jar|tar\\.gz)$"))))))) > + (build-system ant-build-system) > + (arguments > + `(#:phases (modify-phases > + %standard-phases > + (add-after 'unpack 'prepare-for-build > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (setenv "ANT_OPTS" "-Dxsltc.java_cup.not_needed=3Dtr= ue") > + (substitute* "build.xml" > + ;; Only the interpretive compiler. xsltc contains= a > + ;; circular reference java_cup. > + (("( + all pre) > + (string-append pre "\"")) > + (("xml-apis") "jaxp")) > + (substitute* (list "src/MANIFEST.MF" > + "src/manifest.xalan-interpretive" > + "src/MANIFEST.SERIALIZER" > + "src/manifest.xsltc") > + ;; This stops the indexing phase from searching for > + ;; xml-apis in the wrong location -- java-xerces a= nd > + ;; java-jaxp are propagated, so the eventual Java > + ;; application package will still have access to i= t. > + (("^Class-Path:(.*)$") "")))) > + (replace 'install > + (install-jars "build"))))) > + (native-inputs (list java-junit java-hamcrest-core)) > + (propagated-inputs (list java-jaxp java-xerces)) > + (home-page "https://xalan.apache.org/xalan-j/index.html") > + (synopsis "Java XSLT processor") > + (description "XSLT processor in java implementing XSLT Version 1.0, = XPath > +Version 1.0, and JAXP 1.3. It builds on SAX2 and DOM level 3. This ver= sion > +is the fully functional interpreter, xslt, not the xsltc version which m= ay be > +faster.") > + (license > + (list > + license:asl2.0 ; almost everything > + ;; samples/AppletXMLtoHTML/rabbitwhorn.jpg, according to > + ;; > + license:public-domain)))) > --=20 > 2.34.0 I was able to apply this patch on current master ec6122250de7c83a7e77054584a34767b11337db ... and successfully build java-xalan-interp! But this appears to add java-xalan-interp, but the subject is "Add java-xalan". I'm not confident in reviewing the whole patch series, and not terribly savvy with guile or java ... The patches started in 2018, are some of the earlier patches applied? Are there other patches that still need applying? Or can they be dropped? Do you have a summary of the discussion around licensing and other issues? Makes me a bit nervous to apply patches as the current status is not totally clear to me. If these aren't the first generation patches in the series, maybe re-send the patches that still need applying as a [PATCH v2] (or v3? v4?) in the subject of each patch? With a summary clarifying the licensing and which exact patches still need applying, that would make it a lot easier to review! Thanks for contributing to guix, and hanging onto patience with the process! live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYwAJQAAKCRDcUY/If5cW qsw2AQCU95TShUprO3dTqSDvnG5FSTs+ORyDqztVNJ/v1wmdsAD7B8mBHRzmC+Xp 3DBuCnfj5S9vTUEhXZo0c9tEb0mbGQs= =dAzD -----END PGP SIGNATURE----- --=-=-=--