From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eFjOLowQAmNXfwAAbAwnHQ (envelope-from ) for ; Sun, 21 Aug 2022 13:01:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id eDTULowQAmN3pAAA9RJhRA (envelope-from ) for ; Sun, 21 Aug 2022 13:01:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9E34F2020B for ; Sun, 21 Aug 2022 13:01:31 +0200 (CEST) Received: from localhost ([::1]:49794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oPihu-00048K-Dx for larch@yhetil.org; Sun, 21 Aug 2022 07:01:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPihS-00045u-Uh for guix-patches@gnu.org; Sun, 21 Aug 2022 07:01:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44131) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oPihS-0000Uc-In for guix-patches@gnu.org; Sun, 21 Aug 2022 07:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oPihS-0000f4-EO for guix-patches@gnu.org; Sun, 21 Aug 2022 07:01:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57257] [PATCH 00/31] Update LXQt to 1.1.0 References: <20220817032024.29955-1-iyzsong@envs.net> In-Reply-To: <20220817032024.29955-1-iyzsong@envs.net> Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Aug 2022 11:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57257 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 57257@debbugs.gnu.org, iyzsong@member.fsf.org Received: via spool by 57257-submit@debbugs.gnu.org id=B57257.16610796542510 (code B ref 57257); Sun, 21 Aug 2022 11:01:02 +0000 Received: (at 57257) by debbugs.gnu.org; 21 Aug 2022 11:00:54 +0000 Received: from localhost ([127.0.0.1]:33879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPihK-0000eQ-3Y for submit@debbugs.gnu.org; Sun, 21 Aug 2022 07:00:54 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPihG-0000eB-Jd for 57257@debbugs.gnu.org; Sun, 21 Aug 2022 07:00:52 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1661079635; cv=none; d=zohomail.com; s=zohoarc; b=TGzoUsdlV2wd8vkLwWgh5yB94sVUNG/h/Oi7//KwdWtui+1dxucK2BJcJ5LSyuxba9mt9OjtrINb/0IAyewSCTTbG5Num+fB1FpgFo1rY9gUYWxSfIK3oE74FXhfQGtDW6pdP8bZ7/wlRCe8/D0uHIn5q0gmwrbN/KEh/tikop4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661079635; h=Content-Type:Content-Transfer-Encoding:Date:From:MIME-Version:Message-ID:Subject:To; bh=RdJymet37c+I/7/Dv7Lc8GpfTJdZ7AH70a9Ld6MHOYo=; b=QA8ZBiIkKqBSLhmmUkSKDSM7TeiJ2Lv6bQK1zGeISew6GDuUaAiKNxzBms4KNzSHjqAIB8fqieFXV4IaHZNoOZjF2rhPCSnvmg7q6nLTJBR4TJAH7D8oyGAo6hsSajiBPz/V/Ute8bD8mVfywcDhSezgKpz1klPVmqCRGXJXWe0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1661079635; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=RdJymet37c+I/7/Dv7Lc8GpfTJdZ7AH70a9Ld6MHOYo=; b=RHKrPMOIujFWi4akA/ijP+wyeqczBPM+STp5nHlIIr6iVwVX4xtwFvmWriDZZi+z X+NMw/JSJO44LMk4z84eUODlpTl1x7vHGCTyTDPAS6Bxg/JHjEx/HvbUKnNAQfHTKfY BM7+XG/1TEguT35pEQZ8Z3VnRsbYPahPBv3/pYUA= Received: from localhost (i5E862DA0.versanet.de [94.134.45.160]) by mx.zohomail.com with SMTPS id 1661079631764491.2085479575933; Sun, 21 Aug 2022 04:00:31 -0700 (PDT) User-agent: mu4e 1.8.7; emacs 28.1 From: Ricardo Wurmus Date: Sun, 21 Aug 2022 12:55:44 +0200 X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <877d313lpw.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1661079692; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RdJymet37c+I/7/Dv7Lc8GpfTJdZ7AH70a9Ld6MHOYo=; b=JVwrdzUCVYnwmDvEj/gUPzP0qnuarm/u1cz7btdD/oZJJhVd4vj6hNlWjFJTN09SkcU661 Y/cnlKJAmavLovTa5mMnrdjSNoa9wgylhA/749O93X7TOEBvQEtZBfV29enF+JZnnr0ab3 guo7g2TeC8+FbaBn1hAYMgwOEvxnariMGl8CT5ptdVbDCdpk2un+yx6ynjMK4eOnUJsFmI opwN7SxDkd08/V8fBS9zzkSdrd0hH+T2TqHVMB5lstR4Dgcm4Qec9BOP91rXJCRNeYG1nf dkECNDmzxMdJEZ8AxYlWv9dVNIqIoT1i3kM+rvbD2rvPw61m9YLHp9gNGM0H7g== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1661079692; a=rsa-sha256; cv=fail; b=HGulVR3GyhN7srguiW3kthB5yhberj9/FqQeVascEpteOJ1H2fgjuQzMEYcnm/8sNZ03xR Y7aqwxyvjrV4ozPUIfjqs89XzZGIyLtFj9l8xNeUIdagVrPAhIu+z+HnjyfkT2riZlwFv3 0mLkGmG4lst8+WacUcVoEiht+y6QKV71XosULO9MeZy/a4FmCpIdnGeJfeNkJH1QUaTxNm qZJzt+juwwlFJ7mWCxuf5wXLUzmf1A88thxASkYMCkxcVH2PZA4/XLXwwU1/yJWAzaXEeb O4sx3mnmPaQ8z7O6srDDk7WGyBY75Y6tYiZ/1bVWKhrFUrtgvskSslofiqxL6Q== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=RHKrPMOI; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.37 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=RHKrPMOI; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9E34F2020B X-Spam-Score: 2.37 X-Migadu-Scanner: scn0.migadu.com X-TUID: a6aS3mFet3Jt Hi, overall this looks good to me. Thank you for working on it! There are just a few questions: - does it really work to use relative file names? Would it be possible to test this roughly in a system test? - you=E2=80=99re removing a lot of patch-source phases. Why are these no l= onger needed? - you=E2=80=99re also removing patch-translations-dir phases. Do translati= ons still work after applying these changes? - this diff looks wrong to me: --8<---------------cut here---------------start------------->8--- diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm index 08e33ca0e3..d2cbd1e131 100644 --- a/gnu/packages/lxqt.scm +++ b/gnu/packages/lxqt.scm @@ -843,32 +843,31 @@ (define-public libfm-qt (define-public pcmanfm-qt (package (name "pcmanfm-qt") [=E2=80=A6] + (arguments + (list + #:tests? #f ; no tests + #:phases + #~(modify-phases %standard-phases + (add-before 'configure 'patch-settings.conf.in + (lambda* (#:key inputs #:allow-other-keys) + (let ((wallpaper (search-input-file inputs + "share/lxqt/wallpapers/waves-logo.png"))) --8<---------------cut here---------------end--------------->8--- Shouldn=E2=80=99t it be "/share/lxqt=E2=80=A6"? Feel free to push this! --=20 Ricardo