From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oI6+A24pDWOoOwEAbAwnHQ (envelope-from ) for ; Mon, 29 Aug 2022 23:02:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uIjuAm4pDWNfDwAAG6o9tA (envelope-from ) for ; Mon, 29 Aug 2022 23:02:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 080B61491 for ; Mon, 29 Aug 2022 22:57:14 +0200 (CEST) Received: from localhost ([::1]:33666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oSlom-0007Y8-Ru for larch@yhetil.org; Mon, 29 Aug 2022 16:57:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSloc-0007XQ-Kp for guix-patches@gnu.org; Mon, 29 Aug 2022 16:57:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44263) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oSloc-0004Ub-Be for guix-patches@gnu.org; Mon, 29 Aug 2022 16:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oSloc-00068I-7Q for guix-patches@gnu.org; Mon, 29 Aug 2022 16:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57473] [PATCH v2 3/4] gnu: fail2ban-service-type: Fix type of enabled? field. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 29 Aug 2022 20:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57473 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: muradm Cc: 57473@debbugs.gnu.org Received: via spool by 57473-submit@debbugs.gnu.org id=B57473.166180661623563 (code B ref 57473); Mon, 29 Aug 2022 20:57:02 +0000 Received: (at 57473) by debbugs.gnu.org; 29 Aug 2022 20:56:56 +0000 Received: from localhost ([127.0.0.1]:34012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSloV-00067z-Lb for submit@debbugs.gnu.org; Mon, 29 Aug 2022 16:56:55 -0400 Received: from mail-qv1-f46.google.com ([209.85.219.46]:34559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSloU-00067j-7u for 57473@debbugs.gnu.org; Mon, 29 Aug 2022 16:56:54 -0400 Received: by mail-qv1-f46.google.com with SMTP id kh8so7276299qvb.1 for <57473@debbugs.gnu.org>; Mon, 29 Aug 2022 13:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc; bh=j0HgKCW7BVlHd3PGow508kBSyIRpg7MSLPH0hmTlNWM=; b=Ydg27zarKKDDl8SLwTSKD6TqZL0+UI4ikmRSVeForTeRhAh038XvfPK1gyje3mh8DJ IYImN2C563AgduXylsfaUoG/HxqlnXD8FbkXgwDrF2b4x7M5nWOvCEYnW08VDyczXtpE AnBCNvxQtrZJOzXgWlhQ8S3WazEGCzCK9efcGs68UOcDh2CIByF0oPog9Y6S/uepTNxv dr9vaKWDJBoiTM8SI+n6P0f0BqvEcdPloYmvDAY6eeUfM18ZYHZD31GaRmHgKOwQUI67 rt7XwZrRaczJFP/F4UcuFweitetjM2yKEh/JvFjUq+DMHkMs/n5woiXMWwZuHhWtaQRy xCwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc; bh=j0HgKCW7BVlHd3PGow508kBSyIRpg7MSLPH0hmTlNWM=; b=LPUBVZGVFUvEncKJjpK3O3FSk0SvIVqwvnJu6ZDgk1T7PTdftUI7uGjdirY4Aze3ff rxd3ic7mfoyhvPUhmRg3of7pooJQc/XYaIFsHkwaS2AsjOCJcYD4pWUiidpaRCwaykeD Uwm38EQOiM9WygnhnJKh80stDFH0rJCRNzvEejAoDSVrRJdZNznfx8dhAQzDnuguMOAz WIExnlw1QxCPlW7k5HmxlLD3Nr9h8QPCNqdijLRYwrItM6/N6zZKBHojXdk2UUH3miws YwjqVMmBbpNygJ9F3pzvQawXxwB3qsJk1g7sHCpg/B8R/1WvpXcKl06SouSwKTbX8ZH/ iCag== X-Gm-Message-State: ACgBeo0f3W8xHzIQK/IFT4UOyL4PFtkNCPemPuhbU0tPlNkOka1mf8zq c6nPvSGDa9GAXMM+qCHIjV3c+a5/Ac8= X-Google-Smtp-Source: AA6agR5JkSRCq6PdaO8NyyzM39gSC3Sr49trJRGbS7sN4qs7j3puX0wCWWS8VASGE0PlZJwqmY1+Gw== X-Received: by 2002:ad4:5ec5:0:b0:498:f95f:36a2 with SMTP id jm5-20020ad45ec5000000b00498f95f36a2mr9279191qvb.64.1661806607715; Mon, 29 Aug 2022 13:56:47 -0700 (PDT) Received: from hurd ([2607:fad8:4:3::1001]) by smtp.gmail.com with ESMTPSA id x3-20020ac85383000000b0031eddc83560sm5565096qtp.90.2022.08.29.13.56.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 13:56:47 -0700 (PDT) From: Maxim Cournoyer References: <20220829094205.15595-1-mail@muradm.net> <20220829135121.23392-1-mail@muradm.net> <20220829135121.23392-3-mail@muradm.net> Date: Mon, 29 Aug 2022 16:56:46 -0400 In-Reply-To: <20220829135121.23392-3-mail@muradm.net> (muradm's message of "Mon, 29 Aug 2022 16:51:20 +0300") Message-ID: <877d2qbwfl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1661806634; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=j0HgKCW7BVlHd3PGow508kBSyIRpg7MSLPH0hmTlNWM=; b=fAtVrdFDo2nKERKTNDJhJRMhxpfVZFa8E60LtF1dvzXhehEMF42e2Wj8Uq3GBKQfTglqg0 wEG2kfhvEmNn/2vuA4PzZhJUB2VEEUCsl+gz8OpGavwFasa8rb7Pc8hzdXUv8FjXnoRC7W pbfcP4pjp6Vaav7RdUvnWKUh6zWMaGIkbB6ff08WmveASdP+HXDXyVmSnHsZPw2sbHIJSq f/ndxcGGn5wIFXn39PrQpVysT3feAyfDarbpQq0kzEz3rsbubVUDwOUJuYdUL3zu1Kbfts QPZhZye/X1lqhOhkDiAti5fdOOWAga22A6UOXXRcdrOxzgQGIHu/pNn4zae1/Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1661806634; a=rsa-sha256; cv=none; b=GyeSvIRWwLM63k0p5WZ9QZhrmMjf9AhRV6ynkIEuZI+o/1EI/Ef7i75s7FKX9vAJW9TOQ0 AMVt3dT9li20A/5WxudcP2i4aZblIUS29fbsoObQFFpXQ2JBFMfziMkp4A/OZbFy1Rr1KH rP9HYTxiYbkPVPsXlMUcIupsedKaR34GQA5/Y+RDRmVT+K9Bcxm+INNh+q7ug3c+7V+40x nBSNgvtajKzUdcGHaiRnP82FDsyyU+FBBS47SICK3c02OGRT3+wQi0ffO292RqLmPyAaWC 6WknX9zhR5OyxpCax8RtrzArmK5PBCYmY5enmtroxqrR6VcESQPFXAeVOoAMAA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Ydg27zar; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.90 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Ydg27zar; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 080B61491 X-Spam-Score: 6.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: wUJTfwY7Erv3 Hi, muradm writes: > * gnu/services/security.scm (fail2ban-jail-configuration) > [enabled?]: Should be maybe-boolean, which is how normaly fail2ban > is configured. This also allows sections without enabled field > like @samp{[DEFAULT]}. > * doc/guix.texi: Type of enabled? is maybe-boolean. > --- > doc/guix.texi | 2 +- > gnu/services/security.scm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/guix.texi b/doc/guix.texi > index 7199ff6bc2..ebfc8fb3fa 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -36656,7 +36656,7 @@ Available @code{fail2ban-jail-configuration} fields are: > @item @code{name} (type: string) > Required name of this jail configuration. > > -@item @code{enabled?} (default: @code{#t}) (type: boolean) > +@item @code{enabled?} (type: maybe-boolean) > Whether this jail is enabled. > > @item @code{backend} (type: maybe-symbol) > diff --git a/gnu/services/security.scm b/gnu/services/security.scm > index 7f66c462f3..3283a582f2 100644 > --- a/gnu/services/security.scm > +++ b/gnu/services/security.scm > @@ -197,7 +197,7 @@ (define-configuration fail2ban-jail-configuration > "Required name of this jail configuration." > empty-serializer) > (enabled? > - (boolean #t) > + maybe-boolean I made this change willingly, because it doesn't make sense to me to define a jail configuration that is disabled by default. Does that make sense? Thanks, Maxim