From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sL9WG/bMLmNsfgEAbAwnHQ (envelope-from ) for ; Sat, 24 Sep 2022 11:25:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id eBqAGvbMLmNyNQEAG6o9tA (envelope-from ) for ; Sat, 24 Sep 2022 11:25:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F2223FCED for ; Sat, 24 Sep 2022 11:25:09 +0200 (CEST) Received: from localhost ([::1]:40408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oc1PJ-0007dU-6G for larch@yhetil.org; Sat, 24 Sep 2022 05:25:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc1PD-0007dL-B9 for guix-patches@gnu.org; Sat, 24 Sep 2022 05:25:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43218) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oc1PC-0007Uj-W9 for guix-patches@gnu.org; Sat, 24 Sep 2022 05:25:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oc1PC-0001N0-Ik for guix-patches@gnu.org; Sat, 24 Sep 2022 05:25:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57460] [PATCH 00/19] Refresh to specific version Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Sep 2022 09:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57460 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hartmut Goebel Cc: 57460@debbugs.gnu.org Received: via spool by 57460-submit@debbugs.gnu.org id=B57460.16640114885241 (code B ref 57460); Sat, 24 Sep 2022 09:25:02 +0000 Received: (at 57460) by debbugs.gnu.org; 24 Sep 2022 09:24:48 +0000 Received: from localhost ([127.0.0.1]:42296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc1Ox-0001MS-FL for submit@debbugs.gnu.org; Sat, 24 Sep 2022 05:24:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc1Ow-0001ME-3c for 57460@debbugs.gnu.org; Sat, 24 Sep 2022 05:24:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41240) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc1Oq-0007TS-1Y; Sat, 24 Sep 2022 05:24:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=EI6kQ7OCb1ijbGtr0k0Xi/mrVj+EbpG4DIO9nx8n6os=; b=rgaZKGyRtynk5I64DqZV EmNXLLIM5di8EChIDRkmHE6VC5booRH9+wClY2W6jRbGnqxZ3Q7EO5mFaSD1rHawc1opB77bdIVVR i2JPegSXy1E4y6FPVVrjSbzAx981KGhqSd5K8jfJj+MdqPleIxoAAmrwWf5wVq0V5af4hLQ0tGhA/ g32iRAstlLvKS7oTEmK5Q/ndBXnQ8ECE3HmyDVLN2ziKK8U29lhTHL4+Tyvx+NVYW3D4Shj/ca6cQ PZ8+9YeARmAl1EYLNJXXlrPiu4QcxAohnalUNZe4AXIYKrracKxekDymFtR/BRX/79NUK+BYfZV96 wlUF815G4A/3XA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:57022 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc1Op-0005ZA-Gi; Sat, 24 Sep 2022 05:24:39 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Sat, 24 Sep 2022 11:24:37 +0200 In-Reply-To: (Hartmut Goebel's message of "Sun, 28 Aug 2022 15:18:34 +0200") Message-ID: <877d1tdt0q.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664011510; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=EI6kQ7OCb1ijbGtr0k0Xi/mrVj+EbpG4DIO9nx8n6os=; b=GD44fquBDfzEjbNkFrWZep2rNoNJvC3skWtFHipQDus+W3xw9JgCzav255THJSWJAkmZuX 7IJ27nduE3buz60+KlAGxJ1n26EBcQerHrXLo6h9PQ5i2SxuF39pw814EMmPLJJcevvc4s 8dJMdHKvsSvH1mg1nyxQYlj3qXruzSCdht2dk7xl9j+seGvwl3/lD+GkFro1Dq7aNAnUPn DU49LbP1trIm1YZnszrxeCvbpRZXXTVc1W1EhgJJkppxP7jHsqZx85Z/Hq0zxsS8PLkw6D oAN2MqeYtnaRlLFdKCJsUjfMsqxaEVoZS0AKR+HGuHCPzEhHw+nXxJ96NwdHMQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664011510; a=rsa-sha256; cv=none; b=H1Id6Q8VGDg3nCz5sh+dV98fTaYq5uyCJ3oqSleFfelwfrZXSf18EF0EI2fwPPXWdf8ynx vQzSX0VaEWSoOhnWfxQ+2DUBnNQj3EWQzH0kqHoqURFP0PypXfWeLnuUUPtxtiQ3zDPPUr bsg/zMfezpR4lgjqhwqjZxXbkOBnKzRlDw689D3L1itd9ZyjIiU5D01KyKLkQChI/UJXMO +jCykNsHA/hnoTdOi8aVF1K0zFDXUmcBgECzfqL0e1A+/jgnajvZmngUFl0kJ0ZDGcvZ9F XpACFNyvw3PEodt3ZhaDbN1tHwYCRNoJ0HNQrhKiyPuJMlNXnsqwHZv+hN7FfQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=rgaZKGyR; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.26 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=rgaZKGyR; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F2223FCED X-Spam-Score: -2.26 X-Migadu-Scanner: scn1.migadu.com X-TUID: gR+XpgkQxj9O Hartmut Goebel skribis: > * guix/import/git.scm > (latest-tag): Add keyword-argument 'version'. If version is given, try = to > find the respective version tag. > (latest-git-tag-version): Add keyword-argument 'version' and pass it on= to > called functions. > (latest-releease) Rename to (import-release), add keyword-argument 'ver= sion' > and pass it on to called functions. (Same comment as before.) > +(define* (latest-tag url > + #:key prefix suffix delim pre-releases? (version #f= )) > "Return the latest version and corresponding tag available from the Git > repository at URL." Please augment the docstring to explain the meaning of #:version. > + (let ((version-to-pick > + (if version > + (filter (lambda (vt) (string=3D? version (car vt))) > + versions->tags) > + versions->tags))) Rather: (let ((versions (if version (filter (match-lambda ((candidate-version . tag) (string=3D? version candidate-version))) versions->tag) versions->tag))) (if (null? versions) =E2=80=A6)) > + (match (last version-to-pick) > + ((version . tag) > + (values version tag))))))))) Please adjust the indentation of the =E2=80=98match=E2=80=99 form so it mat= ches what is done elsewhere. Otherwise LGTM. Ludo=E2=80=99.