From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oGmKJXLJiWNaYAEAbAwnHQ (envelope-from ) for ; Fri, 02 Dec 2022 10:46:26 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id AMB5JXLJiWOAhQAA9RJhRA (envelope-from ) for ; Fri, 02 Dec 2022 10:46:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 657E94598F for ; Fri, 2 Dec 2022 10:46:25 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p12cR-0007HZ-UI; Fri, 02 Dec 2022 04:46:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p12cN-0007HE-49 for guix-patches@gnu.org; Fri, 02 Dec 2022 04:46:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p12cM-0005KY-Re for guix-patches@gnu.org; Fri, 02 Dec 2022 04:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p12cM-000717-Nf for guix-patches@gnu.org; Fri, 02 Dec 2022 04:46:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59513] [PATCH] doc: contributing: Tweak the Commit Policy. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 02 Dec 2022 09:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Christopher Baines Cc: 59513@debbugs.gnu.org, zimoun Received: via spool by 59513-submit@debbugs.gnu.org id=B59513.166997431921818 (code B ref 59513); Fri, 02 Dec 2022 09:46:02 +0000 Received: (at 59513) by debbugs.gnu.org; 2 Dec 2022 09:45:19 +0000 Received: from localhost ([127.0.0.1]:45660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p12be-0005ea-WA for submit@debbugs.gnu.org; Fri, 02 Dec 2022 04:45:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p12bZ-00055K-CC for 59513@debbugs.gnu.org; Fri, 02 Dec 2022 04:45:16 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p12bT-0005AH-U0; Fri, 02 Dec 2022 04:45:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=olwh6K+FajQWgyTXkbWzOM0NEsH2KOaR6nyd2mwAaA8=; b=lzT1/46nhHgHxAtLUAta Yvl5aQGiuu3Gv/7IiCyz2Gj4pk38scRwmltqqH9Q3TsuVq66d1Hz/qbrOIk5q6NBZYVUwuWPeTIJS Rhn/df1zBD2Fv6o7IVKgZAJEhImwVp8IH/2dCIy0cOBLON3nLRNG0QBdlX70K1226ehtkaKnfQUBV xSUYlXStCmDDXb5J2AdOP6SB3RmNDdseJ/atLIYclOO0U+m8UzKVbuTXobDraFixIBzVZ8zEHVmJt tgbQFrtlc3i3YFRP8bL4NFHwEhmR6o53lOuXxNbFFyhTsp006YNLSVYc3csaq3g8TZhiK9cr8JcOE JqFi2pNXvAVHag==; Received: from [193.50.110.137] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p12bT-0005H4-9o; Fri, 02 Dec 2022 04:45:07 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221123104946.29480-1-mail@cbaines.net> <86tu2pfmbv.fsf@gmail.com> <871qps20fa.fsf@cbaines.net> Date: Fri, 02 Dec 2022 10:45:04 +0100 In-Reply-To: <871qps20fa.fsf@cbaines.net> (Christopher Baines's message of "Thu, 24 Nov 2022 08:40:59 +0000") Message-ID: <877czauokf.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669974386; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=olwh6K+FajQWgyTXkbWzOM0NEsH2KOaR6nyd2mwAaA8=; b=OcnxDXVyDKJyIOOKNagOKs36CD2UIC0zW76ncKU7oH3hXWY36Ll+U123gc4314h0Xehk9T UJdpAG5Cjn/bLh0JPdxD2ofhKC+W6XYNBFJBCMqJtXpJvZ4VbNy1DWVaSd5v4cQrzrgSF/ oxdI31QnaStL1WCwboqc6WIRmGOf+dnCS7czPxrk8XK5f5WBFB0K+emO8/Ui2g9iM+0ZBA rDePtG2aVZXsMtYbs0rjumZcEkS8pXHj10Lx0UkSapeJTK5VJmQ0n4qsetnIUZYIcV6JL3 0sQHr8NE9AN2mueKjE3DlQTpiGzZ/27sDmm9L4/VsvqsHFvNkBMI7tKmP3iIQQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669974386; a=rsa-sha256; cv=none; b=al32Q2JlEyh6B5PdfdH6vxV3LNN5IdHEH9rhCddn/TFSb4IcAvhvyx25BVk8FefoNfS0C7 Quf8/Ur/ATcPO5c2T1Osp+ALF2ZNms/2vXuP5XcUleEZejgXoVpj/TXHk4b9hW2xHgw8rW 1Mo2zffNZ26q+7MILOrgdnZD5rhtlpyXSgVMP4+eLA9Cejd4frWZOrLOqdQ5VefQXOS9tA lIyppkchtOsLFhPwp+jFtMqovGsansnWTMuOqxx9RJ7cYlVRWrd7iOSWTSP7ksFRDDWOgu QD0n4uJQKMCxTAAmKUrjmRq1nArdeOqg85gfAZsl3x9RZX030yStAQSGak+HQQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="lzT1/46n"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.10 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="lzT1/46n"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 657E94598F X-Spam-Score: -4.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: P0DA6v7rPB52 Hi, Christopher Baines skribis: >> I would write: >> >> =E2=80=A6 changes), and if you're confident (which means you >> successfully built it in a chroot setup, and have done a >> reasonable copyright and license auditing), it=E2=80=99s OK to c= ommit. > > chroot setup doesn't really make sense to me, I'm not sure why that > needs specifying The chroot requirement is specified because a non-isolated build is worth nothing: it might work on some machine and fail on another one for hard-to-find reasons. We could stop mentioning it if we think everyone keeps chroot enabled (that=E2=80=99s probably the case), but it doesn=E2=80=99t hurt to keep it. > (like do we not want things for the Hurd pushing, since the > guix-daemon doesn't support build isolation there yet)? Well yes, that=E2=80=99s the thing. For i586-gnu we=E2=80=99re currently s= tuck because we haven=E2=80=99t yet defined how to normalize the build environment: https://guix.gnu.org/en/blog/2020/childhurds-and-substitutes/ https://issues.guix.gnu.org/43857 And it=E2=80=99s not theoretical: some util-linux tests may or may not work depending on whether the Hurd box has /proc set up, the Texinfo test suite would pass if there happens to be a usable =E2=80=98pt_chown=E2=80=99= program around (see ), etc. So I think the current situation is that we can build base packages for i586-gnu, that=E2=80=99s fine, but don=E2=80=99t have a solid foundation li= ke we do on GNU/Linux, so there=E2=80=99s no point in going too far. Now, I don=E2=80=99t think the i586-gnu situation is an important considera= tion for the commit policy. Ludo=E2=80=99.