From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wMWfL+7YjGM50wAAbAwnHQ (envelope-from ) for ; Sun, 04 Dec 2022 18:29:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cK3HLu7YjGPyVAEAG6o9tA (envelope-from ) for ; Sun, 04 Dec 2022 18:29:18 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 63F684A75 for ; Sun, 4 Dec 2022 18:29:18 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1snZ-0006g9-OF; Sun, 04 Dec 2022 12:29:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1snW-0006ft-ID for guix-patches@gnu.org; Sun, 04 Dec 2022 12:29:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1snW-00075t-63 for guix-patches@gnu.org; Sun, 04 Dec 2022 12:29:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1snW-0006oF-1W for guix-patches@gnu.org; Sun, 04 Dec 2022 12:29:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59661] [PATCH 0/3] Add e2fsprogs to %base-packages-utils. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 04 Dec 2022 17:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59661 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 59661@debbugs.gnu.org Received: via spool by 59661-submit@debbugs.gnu.org id=B59661.167017493626169 (code B ref 59661); Sun, 04 Dec 2022 17:29:02 +0000 Received: (at 59661) by debbugs.gnu.org; 4 Dec 2022 17:28:56 +0000 Received: from localhost ([127.0.0.1]:58827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1snP-0006o1-S2 for submit@debbugs.gnu.org; Sun, 04 Dec 2022 12:28:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1snN-0006nv-AZ for 59661@debbugs.gnu.org; Sun, 04 Dec 2022 12:28:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1snH-00075P-4C; Sun, 04 Dec 2022 12:28:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=a0YeV0dGfJJ7dBCOGu4lDSbobDETzKyOURQAzphYLI8=; b=Qh7NAaB83MQ8PapPoH3u 9GEv449HpiO8lOKzOMhYeqI/beZ2MvUAlOcw4Bpktd4mMLWWRGKYKjGTNfxsvCnCzCBYNXYS1TdBa 7THWbydgOHIUTjxkgqx+z7/6mNwFjQK9/GMIVxKbPLcBGJu2fC32xIYW57xWeZ1OHecY07FBnOCjj 7vt4oJt4rSCmfsjFHhZP5hhTCg/tatYa8i7qt6HcAxMkq8Le/stS+MZdI3OSpUXixY5tUYkLcGgWs XtBXrb6lAE+zHPk0JstGceevKnBMKmMxCojGyK3pYu92Llf6W2WvmwQy8shKSxOMTZCPUr6GA1fwa DApOQvODO9fVAw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1snG-00041O-Lo; Sun, 04 Dec 2022 12:28:46 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <20221204044347.23147-2-maxim.cournoyer@gmail.com> <87wn77m8kw.fsf@gnu.org> Date: Sun, 04 Dec 2022 18:28:44 +0100 In-Reply-To: <87wn77m8kw.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 04 Dec 2022 17:34:23 +0100") Message-ID: <877cz7m62b.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670174958; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=a0YeV0dGfJJ7dBCOGu4lDSbobDETzKyOURQAzphYLI8=; b=OkXyhbz7n8mWMnWzvkUDRSMVgiolrZiXjscKtKhgeoBX1BFoo71vrH+b9MfjEnyyoZehue u/QjL64jazQpamP2wyVUSYNRPIpign1F8VBvcZhZxVwqmN2UbD2W0c+k4/mId4/x7zS32e ny/ZWnSY5bHG4Td67Ysimt3F/7/4HkO6/0rX+jPamJjopCyOiC0hPF+wS3lh9zm3vDjeNe X64/mQpD7Kd0vEAW3KGxZIT8sIZNDC3vYyxKjUg1LD+oglmHI+hDdaxnt7UAcmtBHyvTbQ vkcWOvW+zJS/PhJgLFkrcReCc/0kZzenvWqLqgd0KbGAz36+tvKypmi5YeGIEw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670174958; a=rsa-sha256; cv=none; b=Sa9iOObm3dRvTyv4LKSy5u6R0XHb9BIfJ/IXMKzMDzzg2ZjIqZXAWPqaZnh1wZ36+oKUUt eq5WCPFhrgzVVIRzcCUXxnO5UY00D3HA4clnglYv2LPm7it05T70b7kQ15A9aIIkf78699 mDHshBzSQDbAYRjp6FoO3LtY+q1lAzHi2spmAu3Mss0q5PxEgQzODg4aR0/scV1vHn8Mqe nOZ/nGKoSWYHgQjMxRrEmaIvoxUSbDLm9f/cKrUwNvLh1ysp578NPi5gvR8Y43vXNS93T5 oxLmmhB3wjMcprFWYZtjHqQNWvq+U2HRPEC/mbFKXil7gjFIlQQHN9VxgnC3xw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Qh7NAaB8; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Qh7NAaB8; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 63F684A75 X-Spam-Score: -2.86 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3bXVawwQlJ6a Ludovic Court=C3=A8s skribis: > Maxim Cournoyer skribis: > >> * gnu/system/install.scm (%installer-disk-utilities): Add e2fsprogs. > > LGTM! > > e2fsprogs binaries are indeed missing from $PATH in > guix-system-install-1.4.0rc1.*.iso; I=E2=80=99ll cherry-pick it on > =E2=80=98version-1.4.0=E2=80=99. > > What I don=E2=80=99t get is that our manual installation tests should have > caught this issue because they use =E2=80=98mkfs.ext4=E2=80=99 and expect= to have it in > $PATH. I=E2=80=99ll take a look=E2=80=A6 Got it: Mathieu worked around it in 0f66ef9aa99d2043abccbc80d858bdeca57534ac by explicitly adding e2fsprogs and the installation system used by the tests: commit 0f66ef9aa99d2043abccbc80d858bdeca57534ac Author: Mathieu Othacehe Date: Fri Sep 30 15:19:36 2022 +0200 tests: install: Fix iso-image-installer test. This is a follow-up of: 45eac6cdf5c8d9d7b0c564b105c790d2d2007799. It fixes the following error: + mkfs.ext4 -L my-root /dev/vda2 sh: line 12: mkfs.ext4: command not found * gnu/tests/install.scm (%test-iso-image-installer): Add e2fsprogs to= the appended packages. We should be able to revert this commit once the installer provides e2fsprogs by default. Thanks, Ludo=E2=80=99.