unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Josselin Poiret via Guix-patches via <guix-patches@gnu.org>
To: 'Brendan Tildesley <mail@brendan.scot>, 54379@debbugs.gnu.org
Cc: Kevin Boulain <kevinboulain@gmail.com>,
	Maxime Devos <maximedevos@telenet.be>
Subject: [bug#54379] [PATCH v4 1/6] gnu: pipewire: Remove pipewire 0.2.
Date: Sun, 04 Dec 2022 11:18:14 +0100	[thread overview]
Message-ID: <877cz71nh5.fsf@jpoiret.xyz> (raw)
In-Reply-To: <20221009091232.25885-1-mail@brendan.scot>

Hi Brendan and Kevin,

'Brendan Tildesley <mail@brendan.scot> writes:
> Same as v3 but uses PREFIX instead of DESTDIR for libfreeaptx.

This patch totally flew under my radar before, but now that I wanted to
add aptX support I finally found it (after writing the libfreeaptx
definition myself first :p).

Looks good overall, I'm using it without any issues, but I have a couple
of very small nitpicks:

* First of all, patch 1 doesn't cleanly apply on master anymore (which
  is normal). To make it easier for maintainers to merge your patches,
  you should specify base-commit in your patches using the --base
  option, so that they know what patch this was supposed to cleanly
  apply on;

* in patch 5, you apparently left an entry in the commit message about
  the `/etc` change, even though you separated it into its own commit;

* while we're at it, there's a small typo in patch 1's commit message,
  `theinput` -> `the input`;

* if you're inheriting patches from someone else, you should consider
  either leaving them as the primary author if you're keeping their
  changes as-is, or putting them in the commit message as
  Co-authored-by:.  It's not really an issue here I think, but something
  to remember.

Best,
-- 
Josselin Poiret




  parent reply	other threads:[~2022-12-04 10:19 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-13 22:35 [bug#54379] [PATCH] gnu: linux: update PipeWire & WirePlumber Kevin Boulain
2022-03-14  8:25 ` Brendan Tildesley
2022-03-14  9:06   ` Brendan Tildesley
2022-03-14 23:06   ` Kevin Boulain
2022-03-30  1:01     ` Brendan Tildesley
2022-03-30  4:23       ` fesoj000
2022-03-30 19:14         ` Kevin Boulain
2022-03-31  5:40         ` Brendan Tildesley
2022-04-01 12:46           ` fesoj000
2022-03-31  8:27     ` Brendan Tildesley
2022-04-01 19:32       ` Kevin Boulain
2022-03-14 23:06 ` [bug#54379] [PATCH 1/2] " Kevin Boulain
2022-03-14 23:06   ` [bug#54379] [PATCH 2/2] gnu: rename pipewire to pipewire-0.2 and pipewire-0.3 to pipewire Kevin Boulain
2022-03-30 19:18 ` [bug#54379] [PATCH 1/2] gnu: linux: update PipeWire & WirePlumber Kevin Boulain
2022-03-30 19:18   ` [bug#54379] [PATCH 2/2] gnu: rename pipewire to pipewire-0.2 and pipewire-0.3 to pipewire Kevin Boulain
2022-04-01 19:23 ` [bug#54379] [PATCH 1/2] gnu: linux: update PipeWire & WirePlumber Kevin Boulain
2022-04-01 19:23   ` [bug#54379] [PATCH 2/2] gnu: rename pipewire to pipewire-0.2 and pipewire-0.3 to pipewire Kevin Boulain
2022-04-01 19:34   ` [bug#54379] [PATCH 1/2] gnu: linux: update PipeWire & WirePlumber Maxime Devos
2022-04-01 19:41   ` Maxime Devos
2022-04-01 19:42   ` Maxime Devos
2022-04-01 20:44 ` [bug#54379] [PATCH 0/3] " Kevin Boulain
2022-04-01 20:44   ` [bug#54379] [PATCH 1/3] gnu: linux: update PipeWire Kevin Boulain
2022-04-01 20:44   ` [bug#54379] [PATCH 2/3] gnu: linux: update WirePlumber Kevin Boulain
2022-04-01 20:44   ` [bug#54379] [PATCH 3/3] gnu: rename pipewire to pipewire-0.2 and pipewire-0.3 to pipewire Kevin Boulain
2022-04-02 16:19   ` [bug#54379] [PATCH 0/3] gnu: linux: update PipeWire & WirePlumber Maxime Devos
2022-04-02 18:33     ` Kevin Boulain
2022-04-02 19:51       ` Maxime Devos
2022-08-18 20:46         ` Jack Hill
2022-08-24 17:31           ` Maxime Devos
2022-04-02 16:35   ` Maxime Devos
2022-10-09  4:02 ` [bug#54379] [(Brendan's) PATCH v3 0/6] " 'Brendan Tildesley
2022-10-09  4:02   ` [bug#54379] [PATCH v3 1/6] gnu: pipewire: Remove pipewire 0.2 'Brendan Tildesley
2022-10-09  4:02   ` [bug#54379] [PATCH v3 2/6] gnu: pipewire: Update to 0.3.59 'Brendan Tildesley
2022-10-09  4:02   ` [bug#54379] [PATCH v3 3/6] gnu: pipewire: Set sysconfdir to /etc 'Brendan Tildesley
2022-10-09  4:02   ` [bug#54379] [PATCH v3 4/6] gnu: Add libfreeaptx 'Brendan Tildesley
2022-10-09  9:01     ` Maxime Devos
2022-10-09  4:02   ` [bug#54379] [PATCH v3 5/6] gnu: pipewire: Enable more features 'Brendan Tildesley
2022-10-09  4:02   ` [bug#54379] [PATCH v3 6/6] gnu: wireplumber: Update to 0.4.12 'Brendan Tildesley
2022-10-10 19:57   ` [bug#54379] [(Brendan's) PATCH v3 0/6] gnu: linux: update PipeWire & WirePlumber Kevin Boulain
2022-10-09  9:12 ` [bug#54379] [PATCH v4 1/6] gnu: pipewire: Remove pipewire 0.2 'Brendan Tildesley
2022-10-09  9:12   ` 'Brendan Tildesley
2022-10-09  9:12   ` [bug#54379] [PATCH v4 2/6] gnu: pipewire: Update to 0.3.59 'Brendan Tildesley
2022-10-09  9:12   ` [bug#54379] [PATCH v4 3/6] gnu: pipewire: Set sysconfdir to /etc 'Brendan Tildesley
2022-10-09  9:12   ` [bug#54379] [PATCH v4 4/6] gnu: Add libfreeaptx 'Brendan Tildesley
2022-10-09  9:12   ` [bug#54379] [PATCH v4 5/6] gnu: pipewire: Enable more features 'Brendan Tildesley
2022-10-09  9:12   ` [bug#54379] [PATCH v4 6/6] gnu: wireplumber: Update to 0.4.12 'Brendan Tildesley
2022-12-04 10:18   ` Josselin Poiret via Guix-patches via [this message]
2022-12-24 11:59     ` [bug#54379] [PATCH v4 1/6] gnu: pipewire: Remove pipewire 0.2 Josselin Poiret via Guix-patches via
2023-01-08  9:30       ` Josselin Poiret via Guix-patches via
2023-01-08  9:30         ` [bug#54379] [PATCH v5 1/6] gnu: pipewire: Switch default to 0.3 Josselin Poiret via Guix-patches via
2023-01-08  9:30           ` [bug#54379] [PATCH v5 2/6] gnu: pipewire: Update to 0.3.63 Josselin Poiret via Guix-patches via
2023-01-08  9:30           ` [bug#54379] [PATCH v5 3/6] gnu: pipewire: Set sysconfdir to /etc Josselin Poiret via Guix-patches via
2023-01-08  9:30           ` [bug#54379] [PATCH v5 4/6] gnu: Add libfreeaptx Josselin Poiret via Guix-patches via
2023-01-08  9:30           ` [bug#54379] [PATCH v5 5/6] gnu: pipewire: Enable more features Josselin Poiret via Guix-patches via
2023-01-08  9:30           ` [bug#54379] [PATCH v5 6/6] gnu: wireplumber: Update to 0.4.13 Josselin Poiret via Guix-patches via
2023-01-08 16:48         ` [bug#54379] [PATCH v4 1/6] gnu: pipewire: Remove pipewire 0.2 Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cz71nh5.fsf@jpoiret.xyz \
    --to=guix-patches@gnu.org \
    --cc=54379@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    --cc=kevinboulain@gmail.com \
    --cc=mail@brendan.scot \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).