From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0I8pJtCUoWM/TgAAbAwnHQ (envelope-from ) for ; Tue, 20 Dec 2022 11:56:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yHfMJdCUoWNdGwEAauVa8A (envelope-from ) for ; Tue, 20 Dec 2022 11:56:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 324C03D662 for ; Tue, 20 Dec 2022 11:56:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7aHz-0007hc-Gr; Tue, 20 Dec 2022 05:56:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7aHy-0007hP-RN for guix-patches@gnu.org; Tue, 20 Dec 2022 05:56:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7aHy-00017G-J8 for guix-patches@gnu.org; Tue, 20 Dec 2022 05:56:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7aHy-0004Kg-2x for guix-patches@gnu.org; Tue, 20 Dec 2022 05:56:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59513] [PATCH v2] doc: contributing: Tweak the Commit Policy. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Dec 2022 10:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Vagrant Cascadian Cc: 59513@debbugs.gnu.org, Christopher Baines , Liliana Marie Prikler , zimoun Received: via spool by 59513-submit@debbugs.gnu.org id=B59513.167153373716643 (code B ref 59513); Tue, 20 Dec 2022 10:56:02 +0000 Received: (at 59513) by debbugs.gnu.org; 20 Dec 2022 10:55:37 +0000 Received: from localhost ([127.0.0.1]:44208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7aHZ-0004KN-6d for submit@debbugs.gnu.org; Tue, 20 Dec 2022 05:55:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7aHU-0004KH-MV for 59513@debbugs.gnu.org; Tue, 20 Dec 2022 05:55:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7aHO-00014i-OO; Tue, 20 Dec 2022 05:55:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=oVGSkKbtPbVGzTvwl15WELwkY+zQMTBoOmm7drkLdVY=; b=PHUhxOna8xgt9+B3bNUA I49ZMGAIHD5fPqePOM2XnsCNGD8AmZriiARe7+exawNunYrBTgbR3gZhfOYZvaHFWWpFtrxWws4dd b+kVjArsIdTCTwNxNQGrKvJu/iYYtx1InX1En4ADYX2xeGqJBgiTv0uhD+e9cKSemfzLrJKG5jjvO nFw1lG/xxGf5KK4qxv8i24k2W8kaB+wIZDR3gHMM4NOjqBB0Z/72I4ZaU6XfIvHwWJ0BdchLD1bbw u2M6QbBxAHdWBbvfuP8pMUF+r3x1+Bcc2T64AOIQfp1KcoJfKRD9IOuoL8Hz0vFJr8SeIh888yNtC 5V+cbNghpiJkww==; Received: from [193.50.110.60] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7aHO-00042w-CQ; Tue, 20 Dec 2022 05:55:26 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221123104946.29480-1-mail@cbaines.net> <20221208112051.5019-1-mail@cbaines.net> <87bko64xfq.fsf@contorta> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: =?UTF-8?Q?D=C3=A9cadi?= 30 Frimaire an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour de la Pelle X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 20 Dec 2022 11:55:23 +0100 In-Reply-To: <87bko64xfq.fsf@contorta> (Vagrant Cascadian's message of "Tue, 13 Dec 2022 16:54:17 -0800") Message-ID: <877cymbazo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=PHUhxOna; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671533776; a=rsa-sha256; cv=none; b=YILIhR6oicuFDoKJll/kATYcIuB+yL7I9Z1x8KM4z08zosl+gpvS4360yRJYqML1QwmWXL j5Mka3nZfYxxdwI0N/rCpt89C+cR2s3UZz6j6wVsa35qVDlgw6Q/wdjtM8UNre+8dHju2u mn3yZh6vnUl24zYrF/RRTwrGrMmexSIRqh0McXVrMjmb49s5/RzwnbiklVzsG4TSELgAo5 mqx++d6JIHYDzdVIRmvWwfhw7tdgg10WR65m1RvhU9BzqIvlMLV45w/Aabm/i7UvT00H7R 1Xh7UhHFZhNwsIIOud6FBSxM1ouMTTBMMbBqctAScItJYtXYdbR3vf3ZNLbFlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671533776; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=oVGSkKbtPbVGzTvwl15WELwkY+zQMTBoOmm7drkLdVY=; b=EFz8Na9udapHtXftHX6OgNoAIWvwpyNhFfOZQ9+3cKtwdVkX3F2R20UnH/277oB0J8hMzx 4xSs1SsYAtMnRhoSYz4sS0k2WnD6XWXSxa+hHbDJFJZnqe13b9iX2TPlTOakF0ZnUBIXxq B7x/4O0ie8HSSMX+vOUuMBM9koBZtW/UMvc40+ET6w4wsYYrgTe/+gIVle1FmtndpLmYIY m2ZuYSSWTp+mD9rb71haxKjH3xYEK4I4PpOrmT3Y0n72Hs+FZxERaWuIcE3GKChJErnwct D0U+74Gt1xBYrz6IKqEnbJctPWIoO1FgJX4wKWOyBBlGQ+dd9Jkx5ZpaKJ0Mdg== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=PHUhxOna; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.39 X-Spam-Score: -2.39 X-Migadu-Queue-Id: 324C03D662 X-TUID: Gjy/OtMvccfO Howdy, Vagrant Cascadian skribis: > On 2022-12-08, Christopher Baines wrote: >> Only suggest waiting one week for review for simpler changes, wait two w= eeks >> for more significant changes. > ... >> +Changes should be posted to @email{guix-patches@@gnu.org}. This mailing >> +list fills the patch-tracking database (@pxref{Tracking Bugs and >> +Patches}). It also allows patches to be picked up and tested by the >> +quality assurance tooling; the result of that testing eventually shows >> +up on the dashboard at >> +@indicateurl{https://qa.guix.gnu.org/issue/@var{number}}, where >> +@var{number} is the number assigned by the issue tracker. Leave time >> +for a review, without committing anything (@pxref{Submitting Patches}). >> +If you didn=E2=80=99t receive any reply after one week (two weeks for m= ore >> +significant changes), and if you're confident, it's OK to commit. > > My one concern here for things that I tend to work on is > diffoscope... it has such a large dependency graph(?) because it > supports so many file formats, it pulls in quite a lot for the test > suites... > > In a week or two of changes between submission and being able to push to > master, I'd worry that you could end up with a diffoscope that wouldn't > build because of changes to one of it's (native-)inputs or whatnot > because of changes to master in the previous week... I suppose there=E2=80=99s always this risk. Ideally, qa.guix would either rebuild things periodically (rebasing them) or could be told to. > That said, overall, I think sending everything through guix-patches is a > good change, even if my lazier self pouts a little at having to deal > with more process for seemingly simple things. :) Right, I can sympathize. :-) I=E2=80=99ve done my share of direct pushes = for =E2=80=9Csimple thing=E2=80=9D, but I think there=E2=80=99s now evidence th= at sometimes simple things aren=E2=80=99t that simple. Waiting for a green flag from qa.guix and/or from fellow hackers might seem annoying at first, but the gains in terms of peace of mind, smooth collaboration, and overall stability are worth it. Ludo=E2=80=99.