From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id IF3DKODnBWQDQQEASxT56A (envelope-from ) for ; Mon, 06 Mar 2023 14:17:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yMPdJ+DnBWRNVgAAG6o9tA (envelope-from ) for ; Mon, 06 Mar 2023 14:17:20 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6EF4ABDEC for ; Mon, 6 Mar 2023 14:17:20 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZAiB-0008Jp-Ud; Mon, 06 Mar 2023 08:17:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZAiA-0008JR-V7 for guix-patches@gnu.org; Mon, 06 Mar 2023 08:17:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZAi6-0004bY-OP for guix-patches@gnu.org; Mon, 06 Mar 2023 08:17:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZAi6-0005e8-HS for guix-patches@gnu.org; Mon, 06 Mar 2023 08:17:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60756] [PATCH v2 1/2] services: Add x11-socket-directory-service-type. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Mar 2023 13:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60756 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60756@debbugs.gnu.org Received: via spool by 60756-submit@debbugs.gnu.org id=B60756.167810858921653 (code B ref 60756); Mon, 06 Mar 2023 13:17:02 +0000 Received: (at 60756) by debbugs.gnu.org; 6 Mar 2023 13:16:29 +0000 Received: from localhost ([127.0.0.1]:41675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZAhY-0005dB-QG for submit@debbugs.gnu.org; Mon, 06 Mar 2023 08:16:29 -0500 Received: from jpoiret.xyz ([206.189.101.64]:38202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZAhU-0005cx-7W for 60756@debbugs.gnu.org; Mon, 06 Mar 2023 08:16:26 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 865B81851DF for <60756@debbugs.gnu.org>; Mon, 6 Mar 2023 13:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1678108582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lO6d56xLEhsUYKTsT4afHvxSTqp/68KU4gjGedmq+oE=; b=j+gcfktKHd1I+ge16qZZ5k7mV8xA3SMyvHbTV02PWHQ8OlDv//EMM5PIkEhHhKuS+Eg/rR HbOQnvqYhpdVvCzQlFQrhpAtNZMvtGUaxcPgqHO7CGgI+3O1Flltji21cxK0Yd1fnsYoRF viFo7RChaTum563ZMbCAvJopvECTRGskL38wFgEL17Zl1am3NJMtt5jiM45KpArqzXhbQu dmYnf0oYt6XckLyHw+olrtZSVVMnp4SaoCLxmm00GsBvqB1VMF3xb1ujv3fOWFY/rIoC1F WM4C3uAHKchjfsGCbnsD2XlakiqTtRsYAG8W1gQ3PX/M/9lpq8Ms8e8SEQcYEw== In-Reply-To: <156c8abd42d67c8174f274ca933bdc495efc1962.1676733543.git.mirai@makinata.eu> References: <156c8abd42d67c8174f274ca933bdc495efc1962.1676733543.git.mirai@makinata.eu> Date: Mon, 06 Mar 2023 14:16:21 +0100 Message-ID: <877cvuqau2.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches From: Josselin Poiret via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678108640; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=lO6d56xLEhsUYKTsT4afHvxSTqp/68KU4gjGedmq+oE=; b=CvDA5ABfNgxjlopbFbBdhTpXqcBV0/RNJZtm+JAjwH4gU0l2ykJv/qYzS6Ev+PeiEvsdRn 5h+o9hXXO3O6yafogJTaG8Guvo/UOVmfPW6U5NBTFJrpzEAQLQcZ5tKVMIqURnEc6qQakb +sH7SNdUQzsVBmQasS0pnqlLjYLGiTdF9SwrHCZJ0etHpcEA8NLuUNw3KoXYzwHZTVz+SS hrVwY+7HqfW36L/IvLgqUNMLXGsS7k30OnpzVp309DMXRwMt9uzZv21ANH/454WwaaX+m6 xc18REwagLt8xounudKnaFlSZ50+4x8Ps1p3aoyzT7aZMBOqpV3mq+ZLKHYm7A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=j+gcfktK; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678108640; a=rsa-sha256; cv=none; b=pmhRGlw5oRsW4GlOIXq0b+m2iCEUQ2Lbzw1BRGsEbY9WfQwPMorP4O1Gw128310xXqszUg ppF1I4b9tVKA782kh+J/nfxv6in6H89wLJBXoeU6xNhdUFSoCTkC212hx+3AEJXDBfQcVL SBkKMHeF3UgX5f/Nd0jmTLYXOv4AtnvIGGzkQf4onOrwOS4sh+YCgTBGo8yI4CEtsUppuT KrTGfvYgV+tJ+tFBpRn79FNMcq/nmQpW0De629Awz5hBX/jZzgEPccODP32sf7wewOdm+y 5dkUnOMMiKEUHTeNmriUXUeeePBghdGZyWHp6Ksv3jFjV/JRaHGK5mZJlHkmJw== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -3.71 X-Spam-Score: -3.71 X-Migadu-Queue-Id: 6EF4ABDEC Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=j+gcfktK; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: 9+SmgMM1F2S3 This message wasn't cced to the ML, so here it is again (sorry) FTR. This was in response to v2. Hi Bruno, Bruno Victal writes: > The x11-socket-directory-service misuses activation-service-type > to create directories. This kind of usage is incorrect since > activation-service-type does not depend of file-systems and incompatible Small typo: s/depend of/depend on/, that can be fixed by the committer. > with user defined /tmp mount. > > This commit turns x11-socket-directory-service into a shepherd one-shot > service by defining a new x11-socket-directory-service-type. > > * gnu/services/desktop.scm (x11-socket-directory-service-type): New variable. > (x11-socket-directory-service): Deprecate variable. > (desktop-services-for-system): Use new service-type. > * gnu/tests/lightdm.scm: Use new service-type. Looks good to me, tested it myself (note to self: don't forget `-enable-kvm`). Removing the tmpfs-specifc test is a good call here as well. Noting here that for the same reason as the test being useless, you can't test this patchset properly with `guix system vm`, since the file-systems get overridden. I tested it with `guix system image` instead, which only overrides the root and esp file systems if present. Best, -- Josselin Poiret