From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id UKwiNhoUkmStBQEASxT56A (envelope-from ) for ; Tue, 20 Jun 2023 23:03:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id eNhlNRoUkmRvcAAAG6o9tA (envelope-from ) for ; Tue, 20 Jun 2023 23:03:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 603B63A60A for ; Tue, 20 Jun 2023 23:03:22 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBiVK-0004Mc-Iz; Tue, 20 Jun 2023 17:03:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBiVC-0004M0-SD for guix-patches@gnu.org; Tue, 20 Jun 2023 17:03:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qBiVC-0003fZ-GY for guix-patches@gnu.org; Tue, 20 Jun 2023 17:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qBiVC-0007FJ-1r for guix-patches@gnu.org; Tue, 20 Jun 2023 17:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63567] [PATCH] gnu: Add wf-shadow Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Jun 2023 21:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63567 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63567@debbugs.gnu.org Cc: Skylar The Cobra Widulski Received: via spool by 63567-submit@debbugs.gnu.org id=B63567.168729495027814 (code B ref 63567); Tue, 20 Jun 2023 21:03:02 +0000 Received: (at 63567) by debbugs.gnu.org; 20 Jun 2023 21:02:30 +0000 Received: from localhost ([127.0.0.1]:59868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBiUf-0007EX-Va for submit@debbugs.gnu.org; Tue, 20 Jun 2023 17:02:30 -0400 Received: from mail1.fsfe.org ([217.69.89.151]:51806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBiUc-0007EN-S1 for 63567@debbugs.gnu.org; Tue, 20 Jun 2023 17:02:28 -0400 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1687294943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rOQ3T337Kfu0+BS8col+nTB13lRr6mPqSw4o/s6IUzI=; b=s/+c/o/PD2LVF9NdqpXXijLnkWWULhBOSBXnH/7RKOUsfwX+3jnesV7Trv5kGI0zBD4bw3 Oe62U7zjdANLMaK+HRPXCb9bUQv7lR9wE1gV2zeDLqFAkKHoNTmM9NDNG3uEeFu05VkHFL 87wZUEpaGUTGoefGa/7wyudN8RMJIj4= In-Reply-To: <20230518040259.16837-1-cobra@vern.cc> References: <20230518040259.16837-1-cobra@vern.cc> Date: Tue, 20 Jun 2023 23:02:23 +0200 Message-ID: <877crx7sps.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687295002; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rOQ3T337Kfu0+BS8col+nTB13lRr6mPqSw4o/s6IUzI=; b=rMhJq8A3anvO+M8qpoKUnh/a8yt4rbrexGDZRGp9sKVKUnXbjR0jd+NJjBBTb1z7z/Or2h IhGp1FtzwkRZUILNvrOjU+NmCjJCZwzcHCVj7vRCKW9NZCyCkv6UVBvEw+h4eHH6O3a50P cCXudarFSCahF6GckbSPkk5D8zGdzg+lW4xsC0DSoknc9oifPlZLkztBwoIlfXnMWtVD8M JY2WSA2JRP345R6Sy3yPP2m4QmXw/vfDTeD+OUQJW1Fc9u1KGQ5lVGURZUDtb4QxzugurC +ZsMIlNRiXd54RFJH2SkOfttTbb6AKhIClCyONqeHQuah55xFYRi7ErLc6IU6A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b="s/+c/o/P"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687295002; a=rsa-sha256; cv=none; b=N5lcPdFirlvjEO0dEgEufPl2ciu45dRvU+Vsv+NTYpY51levZW6LiBbjWWzVgpTVl82RIH 6e4PeiFTQ5aDIc+rcWKX714aywChZsjwvsYc4hC3UPzhkXdtjUgAOh5dzC5n5IlDwBu43y jxsqsYY/cMKZZbZEkKCGikFsT1z00i9gnqiyCdItmW5Q5uhw8HkRzqqqXEh6IxjwgWOzYu /q5R6H0HHhf3Sb1sIFHJ7RSgXwLJkSlL/R9N4UST44uQd4BwIXOEds4b167tATICuP11ow SGNSCtkM27ZHuLdRvVGL08dMaCwcIdSKzNlJRx2ZqcYfuwPC7Rul6f26u8Cwlg== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.14 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b="s/+c/o/P"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 603B63A60A X-Spam-Score: -2.14 X-TUID: Zv3oCChF9rxn Hi cobra, Thanks for the patch! Some comments follow. cobra--- via Guix-patches via writes: > From: "Skylar \"The Cobra\" Widulski" > > Signed-off-by: Skylar "The Cobra" Widulski In guix, the committer adds the 'Signed-off-by' line to commits, so you can leave that out. We also have some of our own conventions w.r.t. formatting our commits logs: https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html > --- > gnu/packages/video.scm | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index 0abc153c60..f31eee4a43 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -64,6 +64,7 @@ > ;;; Copyright =C2=A9 2022 Chadwain Holness > ;;; Copyright =C2=A9 2022 Andy Tai > ;;; Copyright =C2=A9 2023 Ott Joon > +;;; Copyright =C2=A9 2023 Skylar Widulski > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -202,6 +203,7 @@ (define-module (gnu packages video) > #:use-module (gnu packages web) > #:use-module (gnu packages webkit) > #:use-module (gnu packages wget) > + #:use-module (gnu packages wm) This would introduce an import cycle. WDYT about adding wf-shadow to (gnu packages wm)'s wm.scm instead? > #:use-module (gnu packages wxwidgets) > #:use-module (gnu packages xdisorg) > #:use-module (gnu packages xiph) > @@ -5658,3 +5660,32 @@ (define-public svtplay-dl > broadcasters including SVT Play, Sveriges Radio, TV4 Play, along with ma= ny > others.") > (license license:expat))) > + > +(define-public wf-shadow > + (package > + (name "wf-shadow") > + (version "1.5.5") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://codeberg.org/cobra/wf-shadow") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1qyf1w9vw5xswf9vw1267l5zh1dckilbmcm7qj1v762n2saw103p"= )))) > + (build-system copy-build-system) > + (arguments > + '(#:install-plan > + '(("wf-shadow" "bin/") > + ("wf-shadow-tui" "bin/") > + ("doc/wf-shadow.1" "share/man/man1/") > + ("doc/wf-shadow-tui.1" "share/man/man1/")))) > + (inputs (list bash wf-recorder wofi dialog wlr-randr)) These inputs currently don't do much; there are multiple ways around this. One way is already used in the grimshot package expression (guix edit grimshot) to patch references to other command-line tools, and it uses the copy-build-system as well. You could have a look at it for inspiration. AFAICS you can also leave out the=20 > + (home-page "https://codeberg.org/cobra/wf-shadow") > + (synopsis "Make instant-replay easy on wlroots based compositors") > + (description > + "@code{wf-shadow} is a script written in order to fill the void in > +instant-replay software for Wayland, specifically wlroots compositors. = It uses > +wf-recorder and wofi in order to accomplish the task.") Could you add @code{} to wlroots, wf-recorder and wofi as well? I think having a descriptive first sentence would also help users find wf-shadow more easily. The current opener seems to focus on the reason why it was created. Cheers, Jelle