unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#64570] [PATCH] fix `guix publish --advertise'
@ 2023-07-11  4:01 nathan via Guix-patches via
  2023-07-11 13:45 ` bug#64570: " Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: nathan via Guix-patches via @ 2023-07-11  4:01 UTC (permalink / raw)
  To: 64570

[-- Attachment #1: Type: text/plain, Size: 118 bytes --]

Simple oversight.
Since 0ae419877ce070721f8e5404c2fe7d721a22f998, timeout will be #f with `guix publish --advertise'.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-avahi-fix-exception-when-timeout-is-f.patch --]
[-- Type: text/x-patch, Size: 1022 bytes --]

From aa385273da1e97c5e69c34582611c7adf99ebbb4 Mon Sep 17 00:00:00 2001
From: nathan <nathan_mail@nborghese.com>
Date: Mon, 10 Jul 2023 23:26:54 -0400
Subject: [PATCH] avahi: fix exception when timeout is #f

* guix/avahi.scm (avahi-publish-service-thread): Fixes crash when timeout is
  #f, which is the default for "guix publish --advertise"
---
 guix/avahi.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/guix/avahi.scm b/guix/avahi.scm
index 502b0b9dcd..574fe0b850 100644
--- a/guix/avahi.scm
+++ b/guix/avahi.scm
@@ -84,7 +84,9 @@ (define client-callback
                                   client-flag/ignore-user-config)
                                  client-callback)))
        (while (not (stop-loop?))
-         (iterate-simple-poll poll timeout))))))
+         (if timeout
+             (iterate-simple-poll poll timeout)
+             (iterate-simple-poll poll)))))))
 
 (define (interface->ip-address interface)
   "Return the local IP address of the given INTERFACE."
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#64570: [PATCH] fix `guix publish --advertise'
  2023-07-11  4:01 [bug#64570] [PATCH] fix `guix publish --advertise' nathan via Guix-patches via
@ 2023-07-11 13:45 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2023-07-11 13:45 UTC (permalink / raw)
  To: nathan; +Cc: 64570-done

Hi,

nathan <nathan_mail@nborghese.com> skribis:

> Simple oversight.
> Since 0ae419877ce070721f8e5404c2fe7d721a22f998, timeout will be #f with `guix publish --advertise'.
>
>>From aa385273da1e97c5e69c34582611c7adf99ebbb4 Mon Sep 17 00:00:00 2001
> From: nathan <nathan_mail@nborghese.com>
> Date: Mon, 10 Jul 2023 23:26:54 -0400
> Subject: [PATCH] avahi: fix exception when timeout is #f
>
> * guix/avahi.scm (avahi-publish-service-thread): Fixes crash when timeout is
>   #f, which is the default for "guix publish --advertise"

Oops, my bad.  Applied, thanks!

Ludo’.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-11 13:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-11  4:01 [bug#64570] [PATCH] fix `guix publish --advertise' nathan via Guix-patches via
2023-07-11 13:45 ` bug#64570: " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).