From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OPi+Gms6HmUhTAAAG6o9tA:P1 (envelope-from ) for ; Thu, 05 Oct 2023 06:24:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id OPi+Gms6HmUhTAAAG6o9tA (envelope-from ) for ; Thu, 05 Oct 2023 06:24:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 224A44480A for ; Thu, 5 Oct 2023 06:24:11 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=iNvQ0t6t; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696479851; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=7WqBPITD5CKfreHCcg626xwyacgfGFqdcb5YIJTXHhs=; b=obDt3KfIevdvUomvI79urUO/HGYJTezF0Q+pl0baK5c5jTpTkqzzXmacFVYOWsA1Z7WI6o pWVQHhlUG46qZxkKePj0Lsur7Zy5MoBxICSCEET4BOsZ1XMm+bOmpzOLdSQjY/ykOb0LLA S8VYhf/lQfslnw9t91iW5vxXDjAw+693Jo85Qdxwi33xY5GAZZqQjOUpPlyozfxn52wHqt dyZvmtoN2lHvahxZ1AkbCF8pBtnTFW3vfH7EXh3PYDD10ZotvxGls2FNLUdaeVAz9TPVkU /l6L893I/Arc8/b6kYMuQIrSdmvNHgT5Ov+AWlmVxbZxqwiRr7aosjDg26BYPg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696479851; a=rsa-sha256; cv=none; b=IfrBtP/Bwnn5VpFvbQWf6Y6kSADrgD0Bf62bgeFzFTNNdVUoCCHKOS8bYg2x0ndpOPQtVK Q/kFX0lnNWruYB0KBZDjAuBmGgMqA+2WvuSdlr7Hj7puYJ2ZbJrPsjum1RhxUnQl6NbNoz M4FQHMv29uHdsYH25juct8UDtfpLpHLSA08TNOMNyyW6FUyDt4sAIAVHM8lRThvCNRfdx6 4rVYdlhfeYw7GXkShEeVmGhPqSey3x6h8JrlJEXVSiVN5Us+YQko/v72IOi1/UCUEP8o+7 HUUVWsZrf/LLPGoKdra4h5oa7P7Tcg+fXT8g1iI1CoE0quDqPt+qSvyn389BrA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=iNvQ0t6t; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoFtu-0000eF-Fo; Thu, 05 Oct 2023 00:23:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoFtp-0000PJ-B6 for guix-patches@gnu.org; Thu, 05 Oct 2023 00:23:46 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qoFtn-0004wR-OT for guix-patches@gnu.org; Thu, 05 Oct 2023 00:23:44 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qoFu5-0008ER-My for guix-patches@gnu.org; Thu, 05 Oct 2023 00:24:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66263] [PATCH 00/23] guix: Add avr as a platform. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Oct 2023 04:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jean-Pierre De Jesus DIAZ Cc: 66263@debbugs.gnu.org, vagrant@debian.org, efraim@flashner.co.il Received: via spool by 66263-submit@debbugs.gnu.org id=B66263.169647982431612 (code B ref 66263); Thu, 05 Oct 2023 04:24:01 +0000 Received: (at 66263) by debbugs.gnu.org; 5 Oct 2023 04:23:44 +0000 Received: from localhost ([127.0.0.1]:45700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoFtn-0008Do-MJ for submit@debbugs.gnu.org; Thu, 05 Oct 2023 00:23:44 -0400 Received: from mail-qv1-xf2d.google.com ([2607:f8b0:4864:20::f2d]:59491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qoFtl-0008Da-5m for 66263@debbugs.gnu.org; Thu, 05 Oct 2023 00:23:41 -0400 Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-65af1037ca8so2787086d6.2 for <66263@debbugs.gnu.org>; Wed, 04 Oct 2023 21:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696479797; x=1697084597; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=7WqBPITD5CKfreHCcg626xwyacgfGFqdcb5YIJTXHhs=; b=iNvQ0t6t98i1ucd75Vo21IG4CBKxL18eMZcjzV/tvvcv+LNDZb9FMP2/aXEjc9tE+f BoUDUqSTwlKKQwm99TE4f/KmtSh89t8lr7b3kpbbmvU3+MCinLrpLv42BmUr3im5slln KMkRJ9eNUG+e8lNrrvUJ8g0Bmnh8w01poM5Mlxm2L0jSShgACHkzhag31QPNHL58XPoh t+bhPOFIwRDDJw9lF2fna5SQfNeh55APdmvihhADqnFE6ynZKJUAxhRV7OeF0kPi6pEQ pPTQuHdSKltM8aLj599SAYnGEBV/Q4PLiuqArhLW2SIc8vmMx+GzrdmmiDSvSvEOh+ti 0Ktg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696479797; x=1697084597; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7WqBPITD5CKfreHCcg626xwyacgfGFqdcb5YIJTXHhs=; b=enGgrNOnUibVDOb+pUVYXbx7W/3PNgv+iD75cNhLv5n67kcQ4cXqZkrh7uiBc18c43 oEjeL0iVijuKlHNef/QOibPA8jdrH+8JH/bjw3sSdotm10lpdHeaV5co7GMtG78gQnuD UAjB7mMxKJ7YVWG6eC7Dok9g16gdv7hBSZjc75iD+VXM2Mu+YVH6JLH53ZuxmQvb4pX1 A1zyjV2m9mDD8EJg/6pVRzHI1HErnpIwdfBRurVFeVN+vYrXbK7N7AVuShP5FW7FlsQ0 YeRvkdyKjqc0eyNmbCclhEbRjhqFiz6UDisjWHlSVbpdu5sFCxZEzG2KD0gusD1gIEV9 4d7Q== X-Gm-Message-State: AOJu0YxZLuyWpT+poRMf3rP8FKH/dmNzgJCv1n17eJnA83iW9hVmFE9B 5AtlhAlKbNVPh3t306FX9vxMsYo07UJk+A== X-Google-Smtp-Source: AGHT+IFwTKue0aiAKDx/VUdEiiuSJliiCVxtSnQEnRwL7MpleCMCaW/eUcAw499plslxv9MG+2BCtQ== X-Received: by 2002:a0c:9c85:0:b0:65b:1c7c:5ad3 with SMTP id i5-20020a0c9c85000000b0065b1c7c5ad3mr3548439qvf.15.1696479797378; Wed, 04 Oct 2023 21:23:17 -0700 (PDT) Received: from hurd (dsl-141-24.b2b2c.ca. [66.158.141.24]) by smtp.gmail.com with ESMTPSA id t25-20020a05620a005900b0076e672f535asm221788qkt.57.2023.10.04.21.23.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 21:23:16 -0700 (PDT) From: Maxim Cournoyer References: <20230929091627.7820-1-jean@foundationdevices.com> <20230929091627.7820-8-jean@foundationdevices.com> Date: Thu, 05 Oct 2023 00:23:15 -0400 In-Reply-To: <20230929091627.7820-8-jean@foundationdevices.com> (Jean-Pierre De Jesus DIAZ's message of "Fri, 29 Sep 2023 11:16:12 +0200") Message-ID: <877co11yvg.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 2.76 X-Migadu-Spam-Score: 2.76 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Queue-Id: 224A44480A X-TUID: Jpb6l2s/ZGow Hi, Jean-Pierre De Jesus DIAZ writes: > * gnu/packages/avr.scm (make-avr-libc): New procedure. > > * gnu/packages/avr.scm (avr-libc): Use make-avr-libc procedure. > --- > gnu/packages/avr.scm | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/gnu/packages/avr.scm b/gnu/packages/avr.scm > index ccce686010..df1523274b 100644 > --- a/gnu/packages/avr.scm > +++ b/gnu/packages/avr.scm > @@ -34,7 +34,8 @@ (define-module (gnu packages avr) > #:use-module (gnu packages check) > #:use-module (gnu packages cross-base) > #:use-module (gnu packages flashing-tools) > - #:use-module (gnu packages gcc)) > + #:use-module (gnu packages gcc) > + #:export (make-avr-libc)) > > (define-public avr-binutils > (package > @@ -93,7 +94,9 @@ (define avr-gcc > `(("gcc" ,gcc) > ,@(package-native-inputs xgcc)))))) > > -(define avr-libc > +(define* (make-avr-libc #:key > + (xbinutils (cross-binutils "avr")) > + (xgcc (cross-gcc "avr"))) I had forgotten: please document any newly added procedures with doc strings, especially public ones. > (package > (name "avr-libc") > (version "2.0.0") > @@ -106,10 +109,12 @@ (define avr-libc > "15svr2fx8j6prql2il2fc0ppwlv50rpmyckaxx38d3gxxv97zpdj")))) > (build-system gnu-build-system) > (arguments > - '(#:out-of-source? #t > - #:configure-flags '("--host=avr"))) > - (native-inputs `(("avr-binutils" ,avr-binutils) > - ("avr-gcc" ,avr-gcc))) > + (list #:target "avr" > + > + #:out-of-source? #t > + > + #:implicit-cross-inputs? #f)) > + (native-inputs (list xbinutils xgcc)) > (home-page "https://www.nongnu.org/avr-libc/") > (synopsis "The AVR C Library") This already was like this, but the leading 'The' determinant should be dropped for synopsis. -- Thanks, Maxim