From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id cOoNMy7tMmUVyQAAG6o9tA:P1 (envelope-from ) for ; Fri, 20 Oct 2023 23:12:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cOoNMy7tMmUVyQAAG6o9tA (envelope-from ) for ; Fri, 20 Oct 2023 23:12:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4538C66D53 for ; Fri, 20 Oct 2023 23:12:14 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=CbwZw8uc; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697836334; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZKUNV2BqtzWYKkyWb5U2d2P2SMq5mUkrJ6wkHKb7CAM=; b=aDCnBy4nV6mAdAJM9rVjGE2GNcQC8K4lxr3VTjykNFX2nzvKvFczBSQXgRCZnw6K50ajUj zDxSGkiow4VBaye4vJwyp+y/BrW/bG3zBhTrOBhDTM/NOHPQTNQLXVn7KPxmXVEaDYmukV 5EJupHMGhXTbNHUl5Bmq6B/dgjhlmPWv2Smp8bh9cRK4/6mBL5UOwIvdmYaFQW/NKyDZfr fXBp/3mysqckvZci+0A1KMW9g/fqKWuI7Jv1moqkJWgvxFu4n3syG141TqoeyKsrJcBmVB n4/3tNhSxd99EV2QxhrLS0B6YzLEmQMYVsFG1ZeBCoKTYWmd8I7jyh0zF0g5vg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697836334; a=rsa-sha256; cv=none; b=cT2OgN74vWCfDd+VNF60ME99aCxJLxJrSwSZvhSuO1rerJFH4tyQhIjU8RwKyjW2w8yzKj 7RMtxZofDcbcFji0CBbbEy+RA/BV/6nJhgLy0b6wAXpR7V5BfISycYWcNjw8Zn3JDloBKu LD/s0vkxbLxo/VUBEhkpDgVxOH5G4XJp6GhQKd12DGto8CeG2BVYD02b9ZLq5xeBwznqV7 RDFE8456easHxdEEZlfMkQ0N08uabBxieAMWLdbInyBA+JzvOmYr+Q4ypDuTW89wz/1b69 T090EeW+sDJp4AhlKXI8YLocbwWdefaABlOdc8P0He+vE5rM2yscvaMDHPPPPg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=CbwZw8uc; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtwmR-0006Em-7J; Fri, 20 Oct 2023 17:11:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtwmM-0006Ab-OB for guix-patches@gnu.org; Fri, 20 Oct 2023 17:11:35 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtwmM-0006ri-G9 for guix-patches@gnu.org; Fri, 20 Oct 2023 17:11:34 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qtwmn-0006Fg-Qa for guix-patches@gnu.org; Fri, 20 Oct 2023 17:12:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42146] [PATCH core-updates 1/?] build: substitute: Don't fail silently. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Oct 2023 21:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42146 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= , Ludovic =?UTF-8?Q?Court=C3=A8s?= , 42146@debbugs.gnu.org Received: via spool by 42146-submit@debbugs.gnu.org id=B42146.169783630424000 (code B ref 42146); Fri, 20 Oct 2023 21:12:01 +0000 Received: (at 42146) by debbugs.gnu.org; 20 Oct 2023 21:11:44 +0000 Received: from localhost ([127.0.0.1]:41760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtwmV-0006F1-UF for submit@debbugs.gnu.org; Fri, 20 Oct 2023 17:11:44 -0400 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]:55743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtwmS-0006Em-7N for 42146@debbugs.gnu.org; Fri, 20 Oct 2023 17:11:42 -0400 Received: by mail-qk1-x736.google.com with SMTP id af79cd13be357-77897c4ac1fso76125885a.3 for <42146@debbugs.gnu.org>; Fri, 20 Oct 2023 14:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697836267; x=1698441067; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZKUNV2BqtzWYKkyWb5U2d2P2SMq5mUkrJ6wkHKb7CAM=; b=CbwZw8uc1iM1SDhenlRDpgRs8wre3JnjPg+16Rb0nwqdIobhyI3VitXu9vPISTFGK/ 4pqCzLSSHpH9anMkvU9GpntH+8umpFnfzYBfxDG27KxfQRhF023psfbsPf01S8MJcvNS MPkSRocjlpdG+tGM0Sg2wEGPhyQ0xgWnDm1VZDmS2ZI4r3pGcz0vrO0zMPO2OwEHJ1Y5 qdZBFFZCMDI/UJx006xny8j5dPTHFmgQRqEoeIp+a8sxfkj50ZdiYcplnQvQJTbNK1/c amPCKXw0DgwjtP8Z+djp/1eLaLrIrNOI3M7hYgTAe5i7iFusMREUyOrKXDU4womz1LQN bHYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697836267; x=1698441067; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZKUNV2BqtzWYKkyWb5U2d2P2SMq5mUkrJ6wkHKb7CAM=; b=KYYeT7dd15n8Blzr+Z9aZB3UXi/yNzCdLiKEDSUZZJ2hK2ZU06l60IGr/6lwegsKtn kNgTzH0DMPOeZYwSYpJO5gpjcrBiHFP/zpiHnRYz12qpPzOWrVbAheoE92ysY1rt1xBH xFV6GFXTakt3MLqxdeqi5T2fTVmnDX3mQbPVePUygbbsXflIJV24NqBU7nQcH2yfhPRi fjOaWXTnJ90dhESO3jJUYsiT/5Sip/Cwm55XdXe9KQCo7a1A5NZP/N+pha9v9ghDrHBV fNIH4w+d2WhT0GBsaM7HcdF9ONLfeG+CrJAipJKkqnqQ/3+PKShx7BZ5/L4+ZeR+HuLe LTEw== X-Gm-Message-State: AOJu0YyraLWwXdLRNR7P8LVp0mDLZSSqDQNcZ/Nyen2fk6F4QyYExEnm lbNju4IZf9zdE8etIhtEvW6pkPRK61mj0w== X-Google-Smtp-Source: AGHT+IEd/Hvweqwa1deq6rZVGXRIY7d4QsP8ZzQBtjcVVTefxLH/inOCdTbh6naXz7Ge5+h9oNGbxQ== X-Received: by 2002:a05:620a:40d2:b0:775:99dd:431b with SMTP id g18-20020a05620a40d200b0077599dd431bmr3162151qko.58.1697836266788; Fri, 20 Oct 2023 14:11:06 -0700 (PDT) Received: from hurd (dsl-156-111.b2b2c.ca. [66.158.156.111]) by smtp.gmail.com with ESMTPSA id o8-20020a05620a228800b0076cdc3b5beasm895906qkh.86.2023.10.20.14.11.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 14:11:06 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <3dad7ba9-75b4-4c48-b468-07c2a1fd603d@makinata.eu> (Bruno Victal's message of "Fri, 20 Oct 2023 19:50:15 +0100") References: <878r7yxrpz.fsf_-_@gnu.org> <3dad7ba9-75b4-4c48-b468-07c2a1fd603d@makinata.eu> Date: Fri, 20 Oct 2023 17:11:05 -0400 Message-ID: <877cnhgfti.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: 5.86 X-Migadu-Queue-Id: 4538C66D53 X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: 5.86 X-TUID: hTP50CK7SZcs Hi, Bruno Victal writes: > Hi Ludo=E2=80=99, > > On 2023-10-19 21:49, Ludovic Court=C3=A8s wrote: >>> +(test-group "substitute*" >>=20 >> I=E2=80=99d avoid groups: they=E2=80=99re not super useful and the outpu= t with the >> Automake driver is terrible. > > I personally like using groups for structuring the logic of the tests. > > The output issue sounds either like a bug to me that should be fixed > or a place for improvement. Ludo, could you refresh my memory about what is wrong with the Automake SRFI-64 driver when it comes to tests? I think it used to masks the tests in its output, but I'm not seeing this now? Consider the following tests, where the "elm->package-name" and "infer-elm-package-name" tests are in the "round trip" test group itself nested in the "elm->package-name and infer-elm-package-name" test group. tests/configuration.scm contains a "duplicated/conflicting entries" test group that contains "duplicate sanitizer", "duplicate serializer" and "conflicting use of serializer + empty-serializer": --8<---------------cut here---------------start------------->8--- make check TESTS=3D'tests/services/configuration.scm tests/elm.scm' \ SCM_LOG_DRIVER_FLAGS=3D"--brief=3Dno" --8<---------------cut here---------------end--------------->8--- PASS: tests/services/configuration.scm - default value, no serialization PASS: tests/services/configuration.scm - wrong type for a field PASS: tests/services/configuration.scm - default value, custom serializer PASS: tests/services/configuration.scm - no default value, provided PASS: tests/services/configuration.scm - no default value, not provided PASS: tests/services/configuration.scm - serialize-configuration PASS: tests/services/configuration.scm - serialize-configuration [deprecate= d] PASS: tests/services/configuration.scm - serialize-configuration with no-se= rialization PASS: tests/services/configuration.scm - serialize-configuration with prefix PASS: tests/services/configuration.scm - default value, sanitizer PASS: tests/services/configuration.scm - string value, sanitized to number PASS: tests/services/configuration.scm - default value, serializer literal PASS: tests/services/configuration.scm - empty-serializer as literal PASS: tests/services/configuration.scm - empty-serializer as procedure PASS: tests/services/configuration.scm - default value, sanitizer, permutat= ion PASS: tests/services/configuration.scm - default value, serializer, permuta= tion PASS: tests/services/configuration.scm - string value sanitized to number, = permutation PASS: tests/services/configuration.scm - default value, sanitizer, permutat= ion 2 PASS: tests/services/configuration.scm - default value, serializer, permuta= tion 2 PASS: tests/services/configuration.scm - duplicate sanitizer PASS: tests/services/configuration.scm - duplicate serializer PASS: tests/services/configuration.scm - conflicting use of serializer + em= pty-serializer PASS: tests/services/configuration.scm - Mix of bare serializer and new syn= tax PASS: tests/services/configuration.scm - Mix of bare serializer and new syn= tax, permutation) PASS: tests/services/configuration.scm - maybe value serialization PASS: tests/services/configuration.scm - maybe value serialization of the i= nstance PASS: tests/services/configuration.scm - maybe value serialization of the i= nstance, unspecified PASS: tests/services/configuration.scm - symbol maybe value serialization, = unspecified PASS: tests/services/configuration.scm - maybe value without serialization = no procedure bound PASS: tests/services/configuration.scm - maybe type, no default PASS: tests/services/configuration.scm - maybe type, with default PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infer-elm-package-name PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infer-elm-package-name PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infer-elm-package-name PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infer-elm-package-name PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infer-elm-package-name PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infer-elm-package-name PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infer-elm-package-name PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infer-elm-package-name PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infer-elm-package-name PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infers other name PASS: tests/elm.scm - infered name round-trips PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infers other name PASS: tests/elm.scm - infered name round-trips PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infers other name PASS: tests/elm.scm - infered name round-trips PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infers other name PASS: tests/elm.scm - infered name round-trips PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infers other name PASS: tests/elm.scm - infered name round-trips PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infers other name PASS: tests/elm.scm - infered name round-trips PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infers other name PASS: tests/elm.scm - infered name round-trips PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infers other name PASS: tests/elm.scm - infered name round-trips PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infers other name PASS: tests/elm.scm - infered name round-trips PASS: tests/elm.scm - elm->package-name PASS: tests/elm.scm - infers other name PASS: tests/elm.scm - infered name round-trips PASS: tests/elm.scm - elm PASS: tests/elm.scm - guile PASS: tests/elm.scm - gcc-toolchain PASS: tests/elm.scm - font-adobe-source-sans-pro PASS: tests/elm.scm - (elm->guix-package "elm/core") PASS: tests/elm.scm - (elm-recursive-import "elm-guix/demo") =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D Testsuite summary for GNU Guix 1.3.0.48706-b42e6315-dirty =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D # TOTAL: 85 # PASS: 85 # SKIP: 0 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D Observation: the output says nothing about the groups, but at least the nested tests are correctly listed. --=20 Thanks, Maxim