From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id cHj8OE8YQWVc9QAAauVa8A:P1 (envelope-from ) for ; Tue, 31 Oct 2023 16:08:00 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id cHj8OE8YQWVc9QAAauVa8A (envelope-from ) for ; Tue, 31 Oct 2023 16:07:59 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7676245CC6 for ; Tue, 31 Oct 2023 16:07:59 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=gCwANNv+; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698764879; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=AuU2ZFNfUoDYuRnukQym7Yd/VOZOOldBSMLeQsJ2sU0=; b=rTVW31FZ3vVkQ0dLCYy4zvJsjqq1jQKqnK43mGHWbt+y//TeSVCIfWtjY3idcMlWFfYhQL 9OV68eF7opCYCrxWlY6hnS9V3l8ZN1s9kdYtvuw7UuMf/xT7R3VGYFU1s6LT8O1PSgh+jG D6KiCvoNst5LoUD4JzbAhzvwCidefBrFF0Wg4N8uWVWZmjci4k1otRUD3hnu+KGxJKLaR6 8AV0SVmLnpe4/mEDJygV8i/ipitjiNV9BHyYD2lk7sXz2+4K8rgrW2iON3FbO4GhL/Ys2h atTcoUTUcUKHaf2qMhLPx7nxqyPksZFQgswQTUFbzerBkLvSMBc5S+c6273nVw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=gCwANNv+; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698764879; a=rsa-sha256; cv=none; b=XW31R1AfxZOB2dVI4LhrAhEoI4e7hGJkm7SbfC89Kmw18nrbfDwI1W5+hEQBLdLavzqf+N PVcKLW/IG6LLC/9/32OHLegRcQem1hqTv0jAQSpCkfK0OL/jONtE3ij3h2pAoJUbhHq9UD sIT/44H7J8jBiSKIzljobrwWDjElkS+8rt7mKsROxkjM1Z7m7CrBgkrtELfgQwm5bHwJvH d6mPVIaFwbEQLUKts7LYtZ3hp4IIdGOyjwOQU7kmeSPVZJUOXBdTE9TOxDT02A9uDfU7Z/ Veo/NbTJthu4lFV2IS96al1JXfnxt06zX2Q6qZzmdMqNpBeCIr6aV0NJZempkw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxqL8-0003tl-7l; Tue, 31 Oct 2023 11:07:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxqL6-0003so-2g for guix-patches@gnu.org; Tue, 31 Oct 2023 11:07:32 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qxqL2-0006VS-Ae for guix-patches@gnu.org; Tue, 31 Oct 2023 11:07:31 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qxqLZ-00078e-Rt for guix-patches@gnu.org; Tue, 31 Oct 2023 11:08:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66793] [PATCH 1/3] tests: Make =?UTF-8?Q?=E2=80=98guix_?= =?UTF-8?Q?time-machine=E2=80=99?= test effective. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 31 Oct 2023 15:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66793 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 66793@debbugs.gnu.org Received: via spool by 66793-submit@debbugs.gnu.org id=B66793.169876483227341 (code B ref 66793); Tue, 31 Oct 2023 15:08:01 +0000 Received: (at 66793) by debbugs.gnu.org; 31 Oct 2023 15:07:12 +0000 Received: from localhost ([127.0.0.1]:48975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxqKl-00076u-TP for submit@debbugs.gnu.org; Tue, 31 Oct 2023 11:07:12 -0400 Received: from mail-oo1-xc30.google.com ([2607:f8b0:4864:20::c30]:60916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxqKg-00076P-Q7 for 66793@debbugs.gnu.org; Tue, 31 Oct 2023 11:07:10 -0400 Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-581edcde26cso3508066eaf.1 for <66793@debbugs.gnu.org>; Tue, 31 Oct 2023 08:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698764787; x=1699369587; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AuU2ZFNfUoDYuRnukQym7Yd/VOZOOldBSMLeQsJ2sU0=; b=gCwANNv+AYE7+MedpKq1HOPossInuEentlORP+znwNEpcMIMHSLyglzFhUPkLD+qdS Rl6oDqfHd9oQuxpRD86BB+/TJ1k5BiG7x9DRXdXlkkJvuuzPU177C6VvFR5RspPQ2tzn NiWl1vf05Mrb1aq9MsexsB7lvcIw0qPoR2rdEKe6Z+wNZ2OkCB+ax76fAaSDEqQugSip 6TOlyfWzymscn5ND7Y2q9O6RYaq1D77H5+3TjPxlsz6IwxIApyITuBN6JPzvtCw46eng BKi8wpgfmKos9wrYn1GJiFYyIpO4dp9UWLwX5EJo5FeTlFaK0OYw4nBXIHphd1e4I5Um tNAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698764787; x=1699369587; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AuU2ZFNfUoDYuRnukQym7Yd/VOZOOldBSMLeQsJ2sU0=; b=HCkNShJZq5MGib3qTxQMkLMAxNaaB5moEGjDzm2pHnzhCikC5Qv+BX/kc19RuKWkLI 0+TciO1NqgRC87b6/O0VwBf99EzjcHnBpwA9mQyIzDOvXSFi15KnCElkKkLT0+ej0cvI wR9qq2Y8hWcDEZIl0PplhdOwxnHxsCRSX9GEAzyyFJDc7+Ab/9EEbmjhK6MDKT2o1keq CMQHEzVzWh+nJWTDaCO3aCMBrIFz4X0UZv3nG3d2UmaP1Arn/f3tzhGAynXIOnLY1Fer tRBjmN28plbrB33OKnIkJKWfxWxsdD0qyTaKbpNxBHUpwx/j+wu2OPZoB5ZFEHXZ9p5v p1iw== X-Gm-Message-State: AOJu0YzWsuu38BaE0RUwJwyMcNbhaoZ6JpK3fcOq0Pezv2J4NZ0JFrW9 O9YcgBefpA0MuYR9UfilTr5l7thqrTM= X-Google-Smtp-Source: AGHT+IFx0M8x+Et7+D9aSUdOBzEY+v1stRaR+MHIl5rSuG47riAlS7OaLqWps5ixeIn1vh3EWmsSXw== X-Received: by 2002:a05:6358:e496:b0:168:f602:d61 with SMTP id by22-20020a056358e49600b00168f6020d61mr10997336rwb.32.1698764786907; Tue, 31 Oct 2023 08:06:26 -0700 (PDT) Received: from hurd (dsl-10-128-239.b2b2c.ca. [72.10.128.239]) by smtp.gmail.com with ESMTPSA id c4-20020a0ceb44000000b0066d5220d860sm603896qvq.18.2023.10.31.08.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 08:06:26 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 28 Oct 2023 16:08:33 +0200") References: Date: Tue, 31 Oct 2023 11:06:25 -0400 Message-ID: <877cn2sufi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 3.67 X-Spam-Score: 3.67 X-Migadu-Queue-Id: 7676245CC6 X-Migadu-Scanner: mx13.migadu.com X-TUID: Oh2cugDD8uZN Hi, Ludovic Court=C3=A8s writes: > The test as added in 79ec651a286c71a3d4c72be33a1f80e76a560031 had no > effect: first because =E2=80=98guix time-machine --commit=3DX=E2=80=99, n= ot followed by a > command, does nothing, and second because the =E2=80=9C! COMMAND=E2=80=9D= shell stanza > does not have the desired effect (see = ). Interesting. I had tested it, but I guess not with that script :-). [...] > -guix time-machine --version > +if [ -d "$abs_top_srcdir/.git" ] \ > + || guile -c '(getaddrinfo "www.gnu.org" "80" AI_NUMERICSERV)' 2> /dev= /null > +then > + guix time-machine --version > +else > + echo "This test requires networking or a local Git checkout; skippin= g." >&2 > + exit 77 > +fi >=20=20 > -# Visiting a commit older than v1.0.0 fails. > -! guix time-machine --commit=3Dv0.15.0 > +if [ -d "$abs_top_srcdir/.git" ] > +then > + EXTRA_OPTIONS=3D"--url=3D$abs_top_srcdir" Should the --url valE here be prefixed with "file://", just to make it extra clear we are cloning from a local file? > +else > + EXTRA_OPTIONS=3D"" > +fi >=20=20 > -exit 0 > +# Visiting a commit older than v1.0.0 must fail (this test is expensive > +# because it clones the whole repository). > +guix time-machine -q --commit=3Dv0.15.0 $EXTRA_OPTIONS -- describe && fa= lse > + > +true Otherwise LGTM. --=20 Thanks, Maxim