From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id EDRqKZSTDWZXDgAAqHPOHw:P1 (envelope-from ) for ; Wed, 03 Apr 2024 19:36:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id EDRqKZSTDWZXDgAAqHPOHw (envelope-from ) for ; Wed, 03 Apr 2024 19:36:20 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1712165779; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=D6zMfzDq7cRXW8rrnq7Nxetg0CtCaAqGlqy+T61lPO8=; b=gQiWtmSzamxXbVC3RLOQxPkWdS8s55ocKSPabGoHtk3hqvT5n0LROTIH+2TwHgjGDj6OeK CBXRiWyr1tjSthTffQDtwfKuNi2ZPxlC0g8E3XqqtIX+Py19qH9o6YCsyAmj2PgZe2zRbO 9CISl6u+V36mptsH+ANTRaigBVxYQzPMAMBEj+EC0uXZkWtfg9qPaCAJ0nmwN/C8HvjtBs oxSr4AtQergI17HTNKFaHtH+ZFxtIIsOIbfAnCS9tt0rzI3PkWchF97rdik5wvsQ/aBF1A bPeHCwxAlR5AVqDKmA9iFbn0d2J6I837j07r/38iN9fc+eVNAi3oXUcwZJ8LqQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1712165779; a=rsa-sha256; cv=none; b=Pb6BF12qqzr6HEF3p15rZE1Pnu5GriobsStQe8dCPLZsx4A20Ha5jbmQIiZXk6WKGskUGU D9gftGdRRORnghhuY72CCrBNJBNb4m4Alawm9bAVt4B2syuVqWjKVq8LvpW2oT/Dcv6x2D s/jzcNFbapVIMliHa4P23X7HmRhNpbbGSf74N9dk4psfDfwtqyiGq9EObRV9FjDsEGHjag YwiFO+I0gnAo3EqsUgdCS1NU4xFcsW+LmL/bbxzjn6Lx7lEsqscSpbIurp6Js0nNjnumPu H6Nob4wF/dUDrBM2nTE45chY4H2Ace4ivMwVyG2litVO3eYbVm/YXpv/eTFUjA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8F25D3F353 for ; Wed, 03 Apr 2024 19:36:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rs4Wn-000187-7c; Wed, 03 Apr 2024 13:36:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rs4Wk-000179-TS for guix-patches@gnu.org; Wed, 03 Apr 2024 13:35:58 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rs4Wk-0003kK-L4 for guix-patches@gnu.org; Wed, 03 Apr 2024 13:35:58 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rs4Wp-00084C-2y for guix-patches@gnu.org; Wed, 03 Apr 2024 13:36:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69292] [PATCH 6/6] store: database: Rename a couple of procedures. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Apr 2024 17:36:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69292 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 69292@debbugs.gnu.org Received: via spool by 69292-submit@debbugs.gnu.org id=B69292.171216572730802 (code B ref 69292); Wed, 03 Apr 2024 17:36:03 +0000 Received: (at 69292) by debbugs.gnu.org; 3 Apr 2024 17:35:27 +0000 Received: from localhost ([127.0.0.1]:59456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rs4WF-00080j-29 for submit@debbugs.gnu.org; Wed, 03 Apr 2024 13:35:27 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rs4WC-00080W-O8 for 69292@debbugs.gnu.org; Wed, 03 Apr 2024 13:35:25 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 8CCD927BBE2; Wed, 3 Apr 2024 18:35:19 +0100 (BST) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 7899911e; Wed, 3 Apr 2024 17:35:19 +0000 (UTC) From: Christopher Baines In-Reply-To: <871q8yl0om.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 27 Feb 2024 10:24:25 +0100") References: <4b6a268daab5e0b307dff2229d551a47c9fe1ebc.1708457946.git.mail@cbaines.net> <12f872394c84039fa553e50381d040de24f24d3e.1708457946.git.mail@cbaines.net> <87zfvrdtcw.fsf@gnu.org> <871q8z8p0n.fsf@cbaines.net> <871q8yl0om.fsf@gnu.org> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Wed, 03 Apr 2024 18:35:19 +0100 Message-ID: <877chejqnc.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.41 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -8.41 X-Migadu-Queue-Id: 8F25D3F353 X-TUID: FrdNy3S0rT/0 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Christopher Baines skribis: > >> Ludovic Court=C3=A8s writes: >> >>> Christopher Baines skribis: >>> >>>> These names should be more descriptive. >>>> >>>> * guix/store/database.scm (path-id): Rename to select-valid-path-id. >>>> (sqlite-register): Rename to register-valid-path. >>>> (register-items): Update accordingly. >>>> >>>> Change-Id: I6d4a14d4cde9d71ab34d6ffdbfbfde51b2c0e1db >>> >>> OK for =E2=80=98register-valid-path=E2=80=99. >>> >>> For =E2=80=98path-id=E2=80=99 my preference would be =E2=80=98valid-pat= h-id=E2=80=99 or keeping >>> =E2=80=98path-id=E2=80=99; =E2=80=98select=E2=80=99 looks odd as nothin= g=E2=80=99s being =E2=80=9Cselected=E2=80=9D here in the >>> non-SQL sense of the word. >> >> The main thing I'm trying to do here is make the procedures that >> directly interact with the database stand out (similar to the ! suffix >> convention). Maybe the procedure taking the db as an argument is enough, >> but to me path-id/valid-path-id look too much like record accessors. > > I=E2=80=99d say that having an explicit =E2=80=98db=E2=80=99 argument is = enough (similar to > procedures that take a =E2=80=98store=E2=80=99 argument). I've changed it to valid-path-id now. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmYNk1dfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XesYA/9Gh9ZjhoTsFV3RktzVH2+VpeuxXu9cv/7 5WtGRkJFttYs8OQMSAQN/4s/06HbT3Rs3YIhFYRADcRUc5q8Sq9/+p+dIFrqFOeZ 4hCa91zmP36AuYR2TmhyEG5ATi34ptNgo7sieDnEAAeDwa42MAZw1NKIH2gXKmmI DjuTXTTDJirr98m36X3mvaZzbKNL8+/j6LjYJ17+umXqq+LvVsDE4NmT26H6aGKD 4GYtB52oRiaOYswclZjVjzk6Qg4dedc8GGBTuRp0Nq30v5JageG71iLma0TlpAcN v/ZISEikh1UNM5cpRbhQnU9gUF+ZgCvGoZYKltCx8GJJ24uRKhjFcup95Ppgv26+ ukM3Gcf0a0q+GIwxJld8gENFr1o94epRJKglV3EuzM1Yu+yzD1OEeEc8zDvctF5j SmMjgJO+Dpgmy41OFFpaSkcgSZr+s4mGLAcAWjyDHeWypKXQU0LcX6nvfl32mhNu 7BoQPn1HshkOCEpctjF3ZrO3lM/f/8qLjbhnQmRLjliZmjhQkvZza4dluPwV795W ukCMQh1tfaSopidEB6N0y/WtX/R/bJ6XUSh/46MG6eGAYxIHcvfaK4DMvX7liD6L mfjY1N6eTFAXDwhmL+Rbx1IZ7mwDhUFyxwj7hczwnsD7FL4n0RXVlhmzd/PeTN5U 8V6LgltayjI= =c+j+ -----END PGP SIGNATURE----- --=-=-=--