From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id wKSRE9KOHWaKAAAAe85BDQ:P1 (envelope-from ) for ; Mon, 15 Apr 2024 22:32:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id wKSRE9KOHWaKAAAAe85BDQ (envelope-from ) for ; Mon, 15 Apr 2024 22:32:18 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=FiG5lWOI; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713213138; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=9UObZ4NCjgxd1bEK1ZChK7VcgRNgJJmkNJG6EUXJWEo=; b=ZJMlQ8zpUlAZe1XPJyIIdWXdh8FiXEcznkMQzZ2SSuN4edbd3XH2oArNDkfLYOvx5dTL0a AAR2VZExvfRF19MQbvddm70wdFXQ8v4wfUoFtI9qwiqY6WRZjjWLz8Wy32TGyKMcDyBYqn euI9ELMxnSOaHuH+4HzFAcag/VAfSZXpe9FkO6MQvoweDg/IAIU3uHcyA71+/HRCY+LY09 +NhqTj99OtKZDLuvasdNmnR7MeNQQ4Qh6lXbes3ety/IYFHO8IXnoTDOfjWg245eWi6JpJ 1LhYcENqdX9zM3xGheZUcTgNOPIh2ID/+tbYBZB7/aaSXJYWDsfXgzynjCSx5Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=FiG5lWOI; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713213138; a=rsa-sha256; cv=none; b=ZXOf2x8jB7zwWzY0LxoVPwpULXDZFD6wYcKBxrnn3+dogdR6EIAEPU71nT2injwEocMOGn T3MnrlNj/n2czEKwNGaPWiDZj9wNeAylLgTEL2xVpokZlXxvDUkQI1RXHKtibUTAmyxXWQ 3FCNjDmgpLu6xm2eCSBE0QgbvosdHDYRs29SHshJuI9D9r8d/ijCgcmhU6Zc1CoOMyJGnI xrSLySy6aCxGYzYP58n0HSA0h+d8WQY4FAKtICGHYinYKWARhRjJEKKuzwEc/+UEMkWxBT ZuXjJVubFwEAUb8dKstg8UzldR1BO09GanK1+o0A9RNkPf0Vhw2R4UWAAv272A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 17C2F679CB for ; Mon, 15 Apr 2024 22:32:18 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwSzc-0006MS-FG; Mon, 15 Apr 2024 16:31:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwSzY-0006Lh-Ak for guix-patches@gnu.org; Mon, 15 Apr 2024 16:31:54 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rwSzY-0002bB-1w for guix-patches@gnu.org; Mon, 15 Apr 2024 16:31:52 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rwSzj-0006NW-RT for guix-patches@gnu.org; Mon, 15 Apr 2024 16:32:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70398] [PATCH 5/5] packages: Reduce code bloat due to list allocation in input fields. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 Apr 2024 20:32:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70398 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier Cc: 70398@debbugs.gnu.org, Josselin Poiret , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines Received: via spool by 70398-submit@debbugs.gnu.org id=B70398.171321311124381 (code B ref 70398); Mon, 15 Apr 2024 20:32:03 +0000 Received: (at 70398) by debbugs.gnu.org; 15 Apr 2024 20:31:51 +0000 Received: from localhost ([127.0.0.1]:39457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwSzV-0006Kz-3W for submit@debbugs.gnu.org; Mon, 15 Apr 2024 16:31:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwSzT-0006Jv-MP for 70398@debbugs.gnu.org; Mon, 15 Apr 2024 16:31:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwSzC-0002Yb-Ag; Mon, 15 Apr 2024 16:31:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=9UObZ4NCjgxd1bEK1ZChK7VcgRNgJJmkNJG6EUXJWEo=; b=FiG5lWOI/i4I3+OI96DI BbE0mukDquqhcSi2sdt4JPJCrbS2u9xXcom1Xa3nPxwW6dNXIgyoWX+WDU1LBgmezYVSm8Rc57f9R QzWaWPecCsKJq0bsOUDPR4kIac/AFtdlKcj+Ir/tNNRVW5EsqAaxOJiEjQHZ/fyfA1SfGJgzBGlAv OqCHaAtVXDC0WXONJl+XpQg8xOkD6mwiYzWh0XOvV/Q1xrjR+2TfeHtBiaNTzLC3MbdUqIg5wA2G7 ppG4aZVAXUUlAt5LoQz0h3hqdAmpGSR7c5ni68TSRRiWG+PXYVcBDlpEIJnkmxC1s0pb/OnsBuNxV cG5MmdwKFfpnDA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <87zftuik7b.fsf@gmail.com> (Simon Tournier's message of "Mon, 15 Apr 2024 19:56:08 +0200") References: <87zftuik7b.fsf@gmail.com> Date: Mon, 15 Apr 2024 22:31:20 +0200 Message-ID: <877cgyz7tz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.57 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -5.57 X-Migadu-Queue-Id: 17C2F679CB X-TUID: jKjJJsuJGT1R Simon Tournier skribis: > On lun., 15 avril 2024 at 17:37, Ludovic Court=C3=A8s wrot= e: > >> + ((_ (list args ...)) >> + ;; As of 3.0.9, (list ...) is open-coded, which can lead to a long= list >> + ;; of instructions. To reduce code bloat in package modules where= input >> + ;; fields may create such lists, move list allocation to the calle= e. >> + (add-input-labels args ...)) > > I am not sure to understand: =C2=AB (list ...) is open-coded, which can l= ead > to a long list of instructions. =C2=BB. This: --8<---------------cut here---------------start------------->8--- scheme@(guile-user)> ,c (lambda () (list 1 2 3 4)) [...] 8 (allocate-words/immediate 0 2)=20=20 9 (scm-set!/immediate 0 0 2)=20=20=20=20=20=20 10 (scm-set!/immediate 0 1 1)=20=20=20=20=20=20 11 (allocate-words/immediate 2 2)=20=20 12 (scm-set!/immediate 2 0 3)=20=20=20=20=20=20 13 (scm-set!/immediate 2 1 0)=20=20=20=20=20=20 14 (allocate-words/immediate 3 2)=20=20 15 (scm-set!/immediate 3 0 4)=20=20=20=20=20=20 16 (scm-set!/immediate 3 1 2)=20=20=20=20=20=20 17 (allocate-words/immediate 4 2)=20=20 18 (scm-set!/immediate 4 0 5)=20=20=20=20=20=20 19 (scm-set!/immediate 4 1 3)=20=20=20=20=20=20 --8<---------------cut here---------------end--------------->8--- > Well, irrelevant for .go size but why not something like: > > ((_ (list args . rest)) > (apply add-inputs-labels (append args rest))) That=E2=80=99s more code and I=E2=80=99m really trying hard to minimize gen= erated code. :-) Ludo=E2=80=99.