From: Zheng Junjie <zhengjunjie@iscas.ac.cn>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 70546-done@debbugs.gnu.org,
Vivien Kraus <vivien@planete-kraus.eu>,
Liliana Marie Prikler <liliana.prikler@gmail.com>,
Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: bug#70546: [PATCH v2] gnu: cairo: Fix cross-compilation.
Date: Tue, 14 May 2024 00:37:16 +0800 [thread overview]
Message-ID: <877cfxzn0j.fsf@iscas.ac.cn> (raw)
In-Reply-To: <87jzjxanfa.fsf@gnu.org> ("Ludovic Courtès"'s message of "Mon, 13 May 2024 14:47:37 +0200")
[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hi,
>
> Zheng Junjie <zhengjunjie@iscas.ac.cn> skribis:
>
>> * gnu/packages/gtk.scm (cairo)[arguments]: Add ‘fix-cross-compilation’ phase
>> when cross-compiling.
>>
>> Change-Id: I3579bb1249c749ee5f164bb4dd47f585b181c2bc
>
> [...]
>
>> + ,@(if (%current-target-system)
>> + `(#:phases
>> + (modify-phases %standard-phases
>> + (add-after 'unpack 'fix-cross-compilation
>> + (lambda _
>> + ;; XXX: Let meson-build-system can customize the property
>
> s/can customize/customize/
>
>> + (substitute* "meson.build"
>> + (("'ipc_rmid_deferred_release', 'auto'")
>> + ;; see https://github.com/NixOS/nixpkgs/blob/df51f2293e935e85f6a2e69bcf89a40cb31bbc3d/pkgs/development/libraries/cairo/default.nix#L65
>> + ;; XXX: check it on hurd.
>> + "'ipc_rmid_deferred_release', 'true'"))))))
>> + '())))
>
> Otherwise LGTM, thanks!
>
> Ludo’.
Thanks, push at https://git.savannah.gnu.org/cgit/guix.git/commit/?id=ecfd88cbe34551ebdae92c7c6bb5888bbd0993d6
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2024-05-13 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 3:17 [bug#70546] [PATCH] gnu: cairo: Fix cross-compilation Zheng Junjie
2024-04-24 4:18 ` Liliana Marie Prikler
2024-04-24 4:34 ` [bug#70546] [PATCH v2] " Zheng Junjie
2024-05-13 12:47 ` Ludovic Courtès
2024-05-13 16:37 ` Zheng Junjie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cfxzn0j.fsf@iscas.ac.cn \
--to=zhengjunjie@iscas.ac.cn \
--cc=70546-done@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=ludo@gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).