unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 71022-done@debbugs.gnu.org,
	Simon Tournier <zimon.toutoune@gmail.com>,
	Vagrant Cascadian <vagrant@debian.org>,
	Richard Sent <richard@freakingpenguin.com>,
	Efraim Flashner <efraim@flashner.co.il>,
	Ricardo Wurmus <rekado@elephly.net>,
	Andreas Enge <andreas@enge.fr>,
	Attila Lendvai <attila@lendvai.name>,
	Janneke Nieuwenhuizen <janneke@gnu.org>
Subject: bug#71022: [PATCH v2] configure.ac: Set default value for the 'prefix' variable.
Date: Sat, 25 May 2024 23:38:12 -0400	[thread overview]
Message-ID: <877cfhi6or.fsf@gmail.com> (raw)
In-Reply-To: <878r00c2f7.fsf@gnu.org> ("Ludovic Courtès"'s message of "Thu, 23 May 2024 11:17:48 +0200")

Hi,

Ludovic Courtès <ludo@gnu.org> writes:

> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> The Guix standard configuration uses a localstatedir of /var and a sysconfdir
>> of /etc.  To ease things for everyone, make the default values match that
>> standard expected configuration.  See
>> <https://lists.gnu.org/archive/html/guix-devel/2024-05/msg00003.html> for a
>> related discussion.
>>
>> * configure.ac: Default $prefix to '' unless already set.
>> * doc/contributing.texi (Building from Git): Streamline doc.
>> * doc/guix-cookbook.texi (Guix environment via direnv): Likewise.
>>
>> Change-Id: I23cd12b58a842d246fbc9fdc740311c573eb0212
>
> LGTM! :-)

I ran 'make distcheck', which initially failed with a

--8<---------------cut here---------------start------------->8---
'dot' error: Format: "pdf" not recognized. Use one of: canon cmap cmapx cmapx_np
dot dot_json eps fig gd gd2 gif gv imap imap_np ismap jpe
jpeg jpg json json0 mp pic plain plain-ext png pov ps ps2
svg svgz tk vdx vml vmlz vrml wbmp xdot xdot1.2 xdot1.4 xdot_json
--8<---------------cut here---------------end--------------->8---

error.  I needed to use the full graphviz, not 'graphviz-minimal' as
used by the Guix package.

I also had to add imagemagick for the 'convert' command.  After that it
proceeded normally; it failed finding many missing substitutes but
otherwise 'make distcheck' went fine.

Pushed, at last.  Some related commits to the above will appear to
guix-patches soon.

-- 
Maxim




      reply	other threads:[~2024-05-26  3:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-17 23:52 [bug#71022] [PATCH] configure.ac: Set default value for the 'prefix' variable Maxim Cournoyer
2024-05-19 10:42 ` Ricardo Wurmus
2024-05-22  0:16   ` Maxim Cournoyer
2024-05-19 14:16 ` Ludovic Courtès
2024-05-22 12:30   ` Maxim Cournoyer
2024-05-23  9:17     ` Ludovic Courtès
2024-05-22  0:24 ` Maxim Cournoyer
2024-05-22 12:51 ` [bug#71022] [PATCH v2] " Maxim Cournoyer
2024-05-23  9:17   ` Ludovic Courtès
2024-05-26  3:38     ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cfhi6or.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=71022-done@debbugs.gnu.org \
    --cc=andreas@enge.fr \
    --cc=attila@lendvai.name \
    --cc=efraim@flashner.co.il \
    --cc=janneke@gnu.org \
    --cc=ludo@gnu.org \
    --cc=rekado@elephly.net \
    --cc=richard@freakingpenguin.com \
    --cc=vagrant@debian.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).