From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id CLAZFQ0uqmbMMQEAe85BDQ:P1 (envelope-from ) for ; Wed, 31 Jul 2024 12:29:01 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id CLAZFQ0uqmbMMQEAe85BDQ (envelope-from ) for ; Wed, 31 Jul 2024 14:29:01 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=bc0v01dG; dkim=fail ("headers rsa verify failed") header.d=araneo.si header.s=20230811 header.b=WaxCk5mr; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=araneo.si (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1722428941; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vZF7CMTYBZrm5tF43VG8UBOPFi0GAihZbxhHnzdRaws=; b=eadMFJkTZfqnYd/aopshlN0kM+WGOseUTcbejohUbvfciF81uPgeHDEc6eFYMXPOlrRXLu 6+ZW/NDAt4vJy0hdJk1aGrAK5ii0g83lv460GQWkC1NVNyz1K3XyHevcNbACElxCHKk8BA dlPI5vZa2fa1ezDp7ubT91m2Sh1vWhlt0EKV2P9lx40uJ9bi8uXvP5q3krYbh2tIahesma 0oTzI1sbKI0lBXK4F4RbCXW8Z85/ZuQJMIEFAtFYRE8joMC6a93IckGgXl9hWsH5q9JnAW BdTyWHYujLxJ9Wdx/sMrL2QPfOKrnOR1ysCFNkDtj5okvV4g7j02FQcR1NFOkA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1722428941; a=rsa-sha256; cv=none; b=gx+XQ7+idgS3HJG++7TI7WTGhLD8bJ7fXzwJKWqFyE7LRAOD7e+jV2ZTIe7jDLl1E2Iq4N ygJEU1ht/hM8pyOE7Ki9vjDUX7KM72yrLf7pOSWbfhO8+Q5zuNtbobghaL4/8b1xlEUHG5 eOItpbmPQ4XvlfysbXWNLEjG57WqEy5Y7xXkYKvu6zoKP0muwn6yzwIby5RXxgKue9Fybf 5z8j+l59vgaGAk/v2ywzJl0VWY/S/mHRV9tpBVnDLLAiRhCMkWh6UOWeYkVbXVjXEEHG62 //iNPl8I3KIxs+Uv/9JUYu7ENI6rLRkFIm6RF/NCe/VjQzwicSXAaNpE6032TA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=bc0v01dG; dkim=fail ("headers rsa verify failed") header.d=araneo.si header.s=20230811 header.b=WaxCk5mr; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=araneo.si (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9E11879047 for ; Wed, 31 Jul 2024 14:29:00 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sZ8Rk-0001Is-N8; Wed, 31 Jul 2024 08:28:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZ8Rj-0001Ii-Ar for guix-patches@gnu.org; Wed, 31 Jul 2024 08:28:47 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sZ8Rj-0003VY-10 for guix-patches@gnu.org; Wed, 31 Jul 2024 08:28:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=vZF7CMTYBZrm5tF43VG8UBOPFi0GAihZbxhHnzdRaws=; b=bc0v01dGlXCnLH5L5IqCjQOpoFcy9gXkpXMIJpBtu0LEiaUyWimumHQ5ikm7tnt1Oc2mJWK2R3MGowskKmXA75ZvbWFcPAudV8/d4WejcuaE9jWsiBshfhqLktEbuC+p1/1tK62Q7kWAfvpHfTn5Rf9mA4ArauBuay4VRj5VRjYByfUasiKj5ttaNgqByRrZuoXqlh0b7IpSOtAbTvdL3v6K+NgLLUikgL2v4K8Obk48c0lQEZ5+9ih5ozurSO0+Kchz0lcpw6/E9N4tXxe78FJCWAExIa2MdLQpuRbKv5KBb0VA8igifodo2Xwa55zFVjJvQb76TjLMA53yUBH2Xw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sZ8Ry-0006sv-4d for guix-patches@gnu.org; Wed, 31 Jul 2024 08:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72205] [PATCH 1/4] gnu: Add kdsingleapplication. Resent-From: Timotej Lazar Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 31 Jul 2024 12:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72205 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 72205@debbugs.gnu.org, =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Received: via spool by 72205-submit@debbugs.gnu.org id=B72205.172242893126446 (code B ref 72205); Wed, 31 Jul 2024 12:29:02 +0000 Received: (at 72205) by debbugs.gnu.org; 31 Jul 2024 12:28:51 +0000 Received: from localhost ([127.0.0.1]:49336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZ8Rm-0006sU-TX for submit@debbugs.gnu.org; Wed, 31 Jul 2024 08:28:51 -0400 Received: from static.51.243.21.65.clients.your-server.de ([65.21.243.51]:51332 helo=araneo.si) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZ8Rl-0006sI-6Q for 72205@debbugs.gnu.org; Wed, 31 Jul 2024 08:28:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=20230811; bh=Kmoru5FF1Ye bT+c6/LQ7SOx6mK9Hh56XGcwotutWZY4=; h=date:references:in-reply-to: subject:cc:to:from; d=araneo.si; b=WaxCk5mrOrCPs7m+48yfN8Ezro6XUnCS3D+ JHga9cJF8v4ATeNUdBoY9y4hiovF+WU59Wx+TFhhRkNAw9vfUEs83meHwn9u/UQpPq82At am2uDU1qNNAC1ujUA520JT7d/VSqqjIykENQQCmW0ihhnGKS+HIk9TbWOh2kI/gNtY= Received: by araneo.si (OpenSMTPD) with ESMTPSA id fdd6820c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 31 Jul 2024 12:28:29 +0000 (UTC) From: Timotej Lazar In-Reply-To: <877cd2xfj2.fsf@gmail.com> References: <877cd2xfj2.fsf@gmail.com> Date: Wed, 31 Jul 2024 14:28:27 +0200 Message-ID: <877cd1oidw.fsf@araneo.si> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.36 X-Spam-Score: -7.36 X-Migadu-Queue-Id: 9E11879047 X-Migadu-Scanner: mx11.migadu.com X-TUID: zOH9sPsiLa77 (Sending again to include the list.) Thanks for the review! The patches have already been merged, but I=E2=80=99= ll send another one fixing the issues you point out. Maxim Cournoyer [2024-07-31 15:05:21+0900]: > Timotej Lazar writes: >> + #:configure-flags >> + #~(list "-DKDSingleApplication_QT6=3Dtrue" "-DKDSingleApplication= _TESTS=3Dtrue"))) > > That's a nitpick, but my impression was that ON/OFF as boolean value for > CMake were more common (or YES/NO). I went by the build instructions=C2=B9 but I=E2=80=99ll change it to be con= sistent with (most) other packages. >> + (license (list license:bsd-3 license:expat)))) > > Is it dual licensed? Or which files/section of the source is covered by > which? A comment is needed. No, some build files are licensed differently. I meant to add a comment but= forgot. =C2=B9 https://github.com/KDAB/KDSingleApplication/blob/1.1/INSTALL.txt