unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Timotej Lazar <timotej.lazar@araneo.si>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 72205@debbugs.gnu.org, 宋文武 <iyzsong@envs.net>
Subject: [bug#72205] [PATCH 1/4] gnu: Add kdsingleapplication.
Date: Wed, 31 Jul 2024 14:28:27 +0200	[thread overview]
Message-ID: <877cd1oidw.fsf@araneo.si> (raw)
In-Reply-To: <877cd2xfj2.fsf@gmail.com>

(Sending again to include the list.)

Thanks for the review! The patches have already been merged, but I’ll send another one fixing the issues you point out.

Maxim Cournoyer <maxim.cournoyer@gmail.com> [2024-07-31 15:05:21+0900]:
> Timotej Lazar <timotej.lazar@araneo.si> writes:
>> +      #:configure-flags
>> +      #~(list "-DKDSingleApplication_QT6=true" "-DKDSingleApplication_TESTS=true")))
>
> That's a nitpick, but my impression was that ON/OFF as boolean value for
> CMake were more common (or YES/NO).

I went by the build instructions¹ but I’ll change it to be consistent with (most) other packages.

>> +    (license (list license:bsd-3 license:expat))))
>
> Is it dual licensed? Or which files/section of the source is covered by
> which? A comment is needed.

No, some build files are licensed differently. I meant to add a comment but forgot.

¹ https://github.com/KDAB/KDSingleApplication/blob/1.1/INSTALL.txt




  reply	other threads:[~2024-07-31 12:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-20  6:49 [bug#72205] [PATCH 0/4] Update nheko Timotej Lazar
2024-07-20  6:57 ` [bug#72205] [PATCH 1/4] gnu: Add kdsingleapplication Timotej Lazar
2024-07-31  6:05   ` Maxim Cournoyer
2024-07-31 12:28     ` Timotej Lazar [this message]
2024-07-31 18:57     ` [bug#72205] [PATCH] gnu: kdsingleapplication: Improve package Timotej Lazar
2024-07-20  6:57 ` [bug#72205] [PATCH 2/4] gnu: mtxclient: Update to 0.10.0 Timotej Lazar
2024-07-20  6:57 ` [bug#72205] [PATCH 3/4] gnu: mtxclient: Switch to new package style Timotej Lazar
2024-07-20  6:57 ` [bug#72205] [PATCH 4/4] gnu: nheko: Update to 0.12.0 Timotej Lazar
2024-07-25  5:15 ` bug#72205: [PATCH 0/4] Update nheko Zheng Junjie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cd1oidw.fsf@araneo.si \
    --to=timotej.lazar@araneo.si \
    --cc=72205@debbugs.gnu.org \
    --cc=iyzsong@envs.net \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).