From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 0PetG7j31mbUgwEAqHPOHw:P1 (envelope-from ) for ; Tue, 03 Sep 2024 11:49:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 0PetG7j31mbUgwEAqHPOHw (envelope-from ) for ; Tue, 03 Sep 2024 13:49:12 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=aEz9olsk; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=KmIRQ8DO; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1725364152; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HIsphwH7uFvOroBTwrFM5/tswduqOrNekgMGOne/zXw=; b=jPoYWjUa+IwDAL0CZ592/Z7XJgFUJ31hmFOeCvD8wUGTeguKQkgtAwqTTxxfVT/tpHPNgr x5mN6a2fCrxYMvVx+vt9VBkTqs3jc/zyRHTWqOnBYfNch5+5Hvk62RIzK7+HEF/GTwU7h6 cChKvUQB1AdLknAD9QK/zQv4w5AFWhNzgecPCNDSbK1uK/xJdaYKinfmZBXC+FKK4MO1Cp ZYvDp24Bo+rRyfczCmBJwwOSDAnW8M/rsqQVm841so/Yd5wO8VMv+jx66rDTxntqzVEa6n OvKZ5hE/dDeWGeQp+o7yyAVmd6Uh5Yi4cjGlHsDbiygIpTPAcuWu9XAAn8x0MA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725364152; a=rsa-sha256; cv=none; b=UVqNBBKQqOCeCVwMIDglGKL7IKLesrZn4qQT1GY/c8oMBMi8UviYQAUR/XjFJkvivcpipi hCLoa6SCAOgelrpKFmdYH/kIveD6+8gbY4LEMFmzHCn5l1rRH9odM7P08faG9MFpCLj0dF H6+jVrPdWcmUISlbbU2zUmD8ax8SXgsRj1M9FBQLod+/JyRQTPrGvr3FJWm9jvaKKeQjE6 58u7mV0Og+LhL8XzfAwr4y7EIMNWdWmLWhk0Xc3Wcj/2Y3VDW7GZki4ECW2QeWvqt7IpnD uQzLZoq0ICvs+3YFZCrXDK2VTpl6O3hncR9M8xeS68qk9opnEDychDUdacj9qA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=aEz9olsk; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=KmIRQ8DO; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 369BA63718 for ; Tue, 3 Sep 2024 13:49:12 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1slS1u-0005jZ-Hc; Tue, 03 Sep 2024 07:49:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slS1s-0005jA-Jd for guix-patches@gnu.org; Tue, 03 Sep 2024 07:49:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1slS1s-000866-9u for guix-patches@gnu.org; Tue, 03 Sep 2024 07:49:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=HIsphwH7uFvOroBTwrFM5/tswduqOrNekgMGOne/zXw=; b=aEz9olsklpLeLVvKLqd+QYzKWSC24N7ExsFuc/aWxMgMPIIq8lPRrh6watxT4KpD0j1u5tSC9iLGNyxZjJFhuvrCSp76qOOyJ/RzN5QE7Cy/fmz3DDj2G/K84L8bzC7cJcWBemd6oCjin/dKPd1mfA80kpZNPG+GyS+wa1bbipTMhtE8GOUAlxPYTDsoIzBM+isBG6OumG+Z1ekd1y39y7OM3YvGCE6eK0rOYlkWnZ7EtjBNKIR4nLFzgS0lfIgLAMUArn5V5EQKGiZJ0z9np4pq25UGkQEhwWNT7IWzBSirJ2ZWxJ5fQYrYo3X6IvhuVlTezniFO9XI3pdJD9sq4g==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1slS2s-0000vY-Az for guix-patches@gnu.org; Tue, 03 Sep 2024 07:50:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72885] [PATCH v2] gnu: screen: Update to 5.0.0 Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 03 Sep 2024 11:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72885 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andy Tai Cc: 72885@debbugs.gnu.org Received: via spool by 72885-submit@debbugs.gnu.org id=B72885.17253641963547 (code B ref 72885); Tue, 03 Sep 2024 11:50:02 +0000 Received: (at 72885) by debbugs.gnu.org; 3 Sep 2024 11:49:56 +0000 Received: from localhost ([127.0.0.1]:59195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slS2l-0000v8-Tn for submit@debbugs.gnu.org; Tue, 03 Sep 2024 07:49:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slS2j-0000uq-89 for 72885@debbugs.gnu.org; Tue, 03 Sep 2024 07:49:54 -0400 Received: from fencepost.gnu.org ([209.51.188.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slS1d-000850-G8; Tue, 03 Sep 2024 07:48:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=HIsphwH7uFvOroBTwrFM5/tswduqOrNekgMGOne/zXw=; b=KmIRQ8DOpoOyBRnMaN3h kT4NP4KZAtGfBMcSUS6U/hXbDcjdVQfWbuiaPfNPLV3PnHF5NLhnecBuCes+6hhtLrxrJARbp0YFD 5huMgU7brGxRJSiZ4Rx5cW/eAuTX3llyYL07JPQo1daVacmqZMDseGie/KRv0p4sptEW+4EtjLCGG 8v9aQECJL1mwKbJktwiIQPgzbV91CpQOcQqIioz3Zeov8Kc59yYWPWthvSEa5ePje0cBaYWYnKHNh eI8mIZLKPX1LJKNktTc4STBE2uDgUHiwGhB5PKTYk8hqRhrhq6R9PCqkqS/wo7OY63MnhMRY/T5+H 5bTxt2iebPhZFA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <3094ea0169f5d37b90a1fccb4d495bdaa6ab6158.1725174170.git.atai@atai.org> (Andy Tai's message of "Sun, 1 Sep 2024 00:03:38 -0700") References: <3094ea0169f5d37b90a1fccb4d495bdaa6ab6158.1725174170.git.atai@atai.org> Date: Tue, 03 Sep 2024 13:48:43 +0200 Message-ID: <877cbtgdpg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 369BA63718 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -7.48 X-Spam-Score: -7.48 X-TUID: d1ZOxXW/ng7j Hello, Andy Tai skribis: > * gnu/packages/patches/screen-hurd-path-max.patch: Update for screen 5.0.= 0. > * gnu/packages/screen.scm (screen): Update to 5.0.0. > [arguments]<#:configure-flags: Add "CFLAGS=3D-D_GNU_SOURCE=3D1". > [inputs]: Add linux-pam. > > Change-Id: Iebc5eff0128ff7f4d27a22cca1bd4a025aca3244 [...] > -+ * Define PATH_MAX to 4096 if it's not defined, like on GNU/Hurd Did you confirm that it still builds for GNU/Hurd? You can test by cross-compiling with =E2=80=98--target=3Di586-pc-gnu=E2=80= =99 or by compiling natively, if you have configured the =E2=80=98hurd-vm=E2=80=99 se= rvice, with =E2=80=98--system=3Di586-gnu=E2=80=99. > (arguments > `(#:configure-flags > + ;; GNU_SOURCE must be defined for mallocmock_reset() to be defi= ned > + '("CFLAGS=3D-D_GNU_SOURCE=3D1" This very likely removes the default flags, =E2=80=9C-O2 -g=E2=80=9D, which= is something we should not do (we=E2=80=99d get an unoptimized build and =E2=80=98--with= -debug-info=E2=80=99 wouldn=E2=80=99t have the intended effect). I think you need to have: "CFLAGS=3D-O2 -g -D_GNU_SOURCE=3D1" instead. Please check the build log to make sure it has the intended effect. Could you send an updated patch? Thanks, Ludo=E2=80=99.