From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id aHr8DM7Y4mbqGQEAe85BDQ:P1 (envelope-from ) for ; Thu, 12 Sep 2024 12:04:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id aHr8DM7Y4mbqGQEAe85BDQ (envelope-from ) for ; Thu, 12 Sep 2024 14:04:30 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=ZgrfBkYq; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Gmt9pIMF; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726142669; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=as23pRzQqXKG+qD312zABP7nHRv1MWlkupvu6DFESpU=; b=MAK1dzx5jGZqk4BCU5Jkj+qASHrCoLHaNpgIka7Gp2qLTBGfC4OJEVjnYg7Why3u6z55iH kXsq3+9iRoyZ17hwZQ30aJbWLuxpe/Ut5nIx6faW5cYkdogsuilhenlBn8MTcnDfvneiAy IyS9+0GqpQpmpGKAxaz1gcYwZcxTjmD9gGR1TUMiQgda8gV7XekDdUqn46f+F816Tex2Yr TVASs/jxcIy1wdMLXk1Kft9hp+lwBq003RbjyI8I6CAOsCWmex0gqr1UyPytrYthCcX+ax bF9CbPsErgLq4eqhRS1Lcz3MNeO0AsSa3fPR0Ilxvb8wRsZNhkqN9UIHrcJjLg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=ZgrfBkYq; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Gmt9pIMF; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726142669; a=rsa-sha256; cv=none; b=GrVaBpY2HJIvQ20BQNYaThpk0+JAc95+ACGzgLcXptgv+uPyK0V8Hqk20s53rBmIX0Uzz1 1XKu/iIQY7ifDyAUfdClb6clnkptif5ovvw9uG6FNWVeVFj0Bh0vbo0o6kt7K1m3lzH/Ss iLf7qrm98cPYSBvwm6vzxYV/bN6BwDkTRlUL2ptnFRGoG6rmo8bTZR0d9j1b1jw21E0mX2 UfOY+/X1nOznpnv+RWAShQSYEsGi49wgQfEYKDt4QurTZ9tAhiToMMU8PK9NbQNsMntCba tocM8v5YsnFqeM284Dh7DrnujVSSWi1jXFdPwipmVJFvXLTnhLAqY3kHqKY1CA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C8741794BC for ; Thu, 12 Sep 2024 14:04:29 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1soiYi-0002GK-CZ; Thu, 12 Sep 2024 08:04:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soiYF-00017O-N3 for guix-patches@gnu.org; Thu, 12 Sep 2024 08:03:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1soiYE-0004yN-Rx for guix-patches@gnu.org; Thu, 12 Sep 2024 08:03:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=as23pRzQqXKG+qD312zABP7nHRv1MWlkupvu6DFESpU=; b=ZgrfBkYqVSV8Qz+Kwt1NtKjXuhWcZzwcF/ys842GFxJ4JqKqr3dkROh/qIoE/RLfaOPf/hwYJ+z/Ey/ibLg6FQb9R8Fm/RPMETGBqKOb1d1PXl5B+PKEPjF8LsizpyxPTnSEotvCgRiKcgMwwb0dYsn54KaIG7z13zSqtJqf6gnDufckyBY+satABSN6utcueuZKXRLBNs8E0ssxLc4P2WY+ZT7mlQWYll00NaTDD0yn5/u0zgmQBndG+VUIHd93N8i9gVW79pcmMuJ1kh+7SgG8dEUFf0tFD+Pr1RoeiB2UZ1Vc3HZ55vlPGiispRdIpLnzNdYKpRqeyvokQHRVjw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1soiYM-0005bb-4t for guix-patches@gnu.org; Thu, 12 Sep 2024 08:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73028] [PATCH] doc: Document usage of #:out-of-source? for meson-build-system. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 12 Sep 2024 12:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73028 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dariqq Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 73028@debbugs.gnu.org, Florian Pelz Received: via spool by 73028-submit@debbugs.gnu.org id=B73028.172614261821511 (code B ref 73028); Thu, 12 Sep 2024 12:04:02 +0000 Received: (at 73028) by debbugs.gnu.org; 12 Sep 2024 12:03:38 +0000 Received: from localhost ([127.0.0.1]:40350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soiXx-0005at-Rd for submit@debbugs.gnu.org; Thu, 12 Sep 2024 08:03:38 -0400 Received: from mail-pl1-f169.google.com ([209.85.214.169]:51397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soiXw-0005ah-2s for 73028@debbugs.gnu.org; Thu, 12 Sep 2024 08:03:36 -0400 Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-20536dcc6e9so6532785ad.2 for <73028@debbugs.gnu.org>; Thu, 12 Sep 2024 05:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726142543; x=1726747343; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=as23pRzQqXKG+qD312zABP7nHRv1MWlkupvu6DFESpU=; b=Gmt9pIMFwXAupE8nwe9G1//WscH/I51oOL6EjQ+Rfn6rZGcUaXESBhftos3gkU2pfw RwfsXXDdfUQCvcOZmWCWhUdcFBz+b41bhNGJpYHJhfWzDHwzlE/nDgcrUmtsBmXCtTEq KiM8ACYip3ha8kNNj3zSI8UfxYXb0Mvzomw0gIljlwDO4Xv271TWrPnyYjugkkBGtcbn 3uvxC9+MhWGI3zii6QWrhT/e/6JESKyfpOLE13PTLtcHkGrJWZNchP2aaKWC7c7UV1+V 37MCUtoGjwdehL7OjJV02uoAJS5SbXS163409lmTpKlGfKm/Ds4THR2X99YPdj8/KIlj E//g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726142543; x=1726747343; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=as23pRzQqXKG+qD312zABP7nHRv1MWlkupvu6DFESpU=; b=nfuzPqz+uphfSo2HtX6dh89gzeGXh6nHxYGw0UaCbT5guja73CgaK6ZRXEyDJ4YewS BHa5o7HssJhn4AmDQKNWx1qB2houaBPodMKtjvBsZtAJSUkHD4iYM7SZa9Sjm4nORbxU qLYDKEn5RGEUF2/BvUwc6lVIc0FnkBbWCKzz6nWbgSS8XPgNsfLGvItJdImGM9+6v8j1 2W1B9c2eqqrP6UZvKGTGNkhGeL4bGguEuFGWP43IpTXhRBc5ZQrMW4/YiU00kJp+y93d otL+bM70Uui/plD3bLuH6BglFOIFiwEBoszNj8KBMXtpesXYLo956vZyILHY8cEca9jO O6vA== X-Gm-Message-State: AOJu0YydrWfDBjKM3WjqXmm5qCmZJ1kxjk4RLx8UO1oRjQzZJ1Dh6nLe MhA3RJB15yeVkypSzfWWH/7HaD7m78mnFCsi/ouBwJxTMP+t0FKxYMKtvCNTEy0= X-Google-Smtp-Source: AGHT+IFX5UQgzLiDkH4MboRf4EybkVnuyoWRrTaoA5gQaZUR/FRE5XFJTVnstGNAxmMa9QigDa340g== X-Received: by 2002:a17:902:d2ce:b0:1fd:672f:2b34 with SMTP id d9443c01a7336-2076e392a1cmr39298705ad.33.1726142542484; Thu, 12 Sep 2024 05:02:22 -0700 (PDT) Received: from hurd ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2076af2566dsm13237895ad.59.2024.09.12.05.02.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 05:02:21 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: (dariqq@posteo.net's message of "Thu, 12 Sep 2024 07:12:22 +0000") References: <878qvy3ent.fsf@gmail.com> <97aa51a8-a945-44f4-8a61-e9bbc3eddba4@posteo.net> <87jzfhy9jf.fsf@gmail.com> Date: Thu, 12 Sep 2024 21:02:19 +0900 Message-ID: <877cbhw050.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.01 X-Spam-Score: -6.01 X-Migadu-Queue-Id: C8741794BC X-Migadu-Scanner: mx10.migadu.com X-TUID: 1EDw3O1zaKWY Hi Dariqq, Dariqq writes: [...] >>> Maybe it should not be an option at all and instead be #t >>> unconditionally in 'install-license-files phase in meson-build-system? >> Given most build phases of the gnu-build-system, which support >> #:out-of-source? are reused in the meson-build-system, this argument >> needs to be set to #t (which it currently is). But perhaps there's a >> way to hide it from the users, perhaps via the 'private-keywords' >> variable defined in the 'lower' procedure of the (guix build-system >> meson) module (I haven't tested). >> > > Something like that might be a better solution. I am not sure how > these 'private-keywords' work: It looks like #:meson is one but you > can definitly override the default meson being used. Also the > private-arguments seem to get stripped from the arguments in the bag > (not sure what that is exactly) so they might not be passed to the > build phases I think your understanding is correct. The private options are accepted on the build system, but not propagated to the lower build strata (applied to phases). So what we'd like here is to *not* expose an #:out-of-source argument at the build system level, and enforce #:out-of-source #t for the lower build code. I guess the static #t argument could be added to the bag arguments. > > Would such a change require rebuilding (basically) everything given > that currently all packages are already built with #:out-of-source? > set to the default value #t? Yes. To test this kind of change without having to wait for the world to rebuild first, I sometimes make a copy of the build system files and suffix them with -v2 or something. It's a bit of a pain, but faster than waiting for 20k packages to be built. -- Thanks, Maxim