From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 8N8cNlge42YogQEA62LTzQ:P1 (envelope-from ) for ; Thu, 12 Sep 2024 17:01:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 8N8cNlge42YogQEA62LTzQ (envelope-from ) for ; Thu, 12 Sep 2024 19:01:12 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="E3Fsi+g/"; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=iUak3Crp; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726160472; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+Xc5/XgCuM7v10djinKsJEq8bJQUwECYT8IdXmHrAvA=; b=Klt719w0EAI0DGuDCQVZEmPQVUsnhRcWdJVBpW8uyH3ai143FVVuR+hGv8r/dNJwVLFl95 SmkrjpplsisLG2gtRlJh52G8qHMjz7anncxTAYeeg9gD2ZtbsK76Y0cytJ1RBWCcF6mc/V 1TVz8kwWMdzPecoh7O2wLGi7e2n8LFXxM25aZ09zkZ601gRszOcGYI33bo9CPESZbUxgs5 5YyYCdkrPdDEYsYiM/RzlPoL9wvZrKuPGiuntykmCcb9dpT/qpc2hWkBfHUimFgzfVEs8b 69BRMZvTK79CVE+n2XODF7XnVZZeJUQ4iKOox8IZd8EF9HiT2cp8/qs/QmSJCg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726160472; a=rsa-sha256; cv=none; b=SWdDuTY4tZLbQxFTpMyGeujnXVRsvx3BpaYsEe1Rrgfh4evnL1CrYarT/vNi6DwFQgpnb/ 0B9ljbwWUW62MwcJ9raeWcQUGmM8PKYJWYuQDQbni6vh7HA9mhUCg/1matSuHsGo6RaZup hncVLt8m5M6z3yrQ19kfgMtMoXuCbI1oG37D5yh9myh8F+MlefUw/2ZE5OgdGaXvSZp/Dh Aj+9qzHHbUe4DmTDJFPb/ywhWigEMsrTQkOWWw3cFyWVBMd0bsWtSIz+mpnbGDGeYJFPrZ MsfyrGoAChoczo5oZB+qYjGqWopa/W4VR2/1ukTdja1h1XGFj0j0Ajjvjd10eg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="E3Fsi+g/"; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=iUak3Crp; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CC8CA12D24 for ; Thu, 12 Sep 2024 19:01:12 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sonBp-00060B-AH; Thu, 12 Sep 2024 13:01:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sonBe-0005zj-Lc for guix-patches@gnu.org; Thu, 12 Sep 2024 13:00:54 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sonBe-0001SL-Aa for guix-patches@gnu.org; Thu, 12 Sep 2024 13:00:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=+Xc5/XgCuM7v10djinKsJEq8bJQUwECYT8IdXmHrAvA=; b=E3Fsi+g/8M0/OoPdSyqAXV+YXhaEsIuQ05PuFYqxKKG5+wLIFD9bawMq83R1G6yzNR76xWkKy7ZlpwK7vAJZ6Wd8Mj+nxe0tX4W/sXQpfy3x3nxYnZtOLVYHgwg+hkPdrHODeYh9vobou+KxFoWfuFf1esHzrNTkcvUv4F2AyyeTfzygZLyuDZpUxV4zP8VZzmr/WRRY5vki4DKJPyjreiQAvqVceNSMZXWSVHxSpQWn7bOguat/9xOHZA5cGdyPnXr5nHBgQbetAjyfbjAA8kwj1Qosm5Y+G87I/5p0xaYDoESfIjEjQhyh6MtGKeCwgmen6P2IqcEaY45yYLmPyA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sonBm-0005At-82 for guix-patches@gnu.org; Thu, 12 Sep 2024 13:01:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73190] [PATCH 2/3] gnu: make-libiberty: Build with -fPIC. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 12 Sep 2024 17:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73190 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Nguy=E1=BB=85n?= Gia Phong Cc: Andreas Enge , 73190@debbugs.gnu.org Received: via spool by 73190-submit@debbugs.gnu.org id=B73190.172616042319816 (code B ref 73190); Thu, 12 Sep 2024 17:01:02 +0000 Received: (at 73190) by debbugs.gnu.org; 12 Sep 2024 17:00:23 +0000 Received: from localhost ([127.0.0.1]:41774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sonB8-00059Y-Qz for submit@debbugs.gnu.org; Thu, 12 Sep 2024 13:00:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sonB6-00055r-TB for 73190@debbugs.gnu.org; Thu, 12 Sep 2024 13:00:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sonAs-0001KW-Os; Thu, 12 Sep 2024 13:00:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=+Xc5/XgCuM7v10djinKsJEq8bJQUwECYT8IdXmHrAvA=; b=iUak3CrptqqusScG0Hjn HFkuFpZW6ah790Pt+edKGSkS0jLbdXVtuxTbCVZ0THRs2Snpl5+6w1S3RUsSDXj1VJnPGRDafVRg1 0LTZjU/aCQllja3bgjRPgu0KMHdBJs6JGUnXINIxzfMqQl4WG2VOLXH7qmqwNKpoJ+tco6qeSfu1C jH3QrGEq7jY1qt2WEKqX66f6v+4q5CbSuCAE1Djv086ja+COHzJS8XWQGIC+fsKS2hsOXmRYCHJBZ xQHuzh/+9yM68Tf4+w9AFIPtohce+gArYMziAnKAsHaJJWWgRd1AZvFqUTmN9zX26HThXQtkzvBV2 +Ob2wvQYB8hwXQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: ("=?UTF-8?Q?Nguy=E1=BB=85n?= Gia Phong"'s message of "Thu, 12 Sep 2024 11:28:33 +0900") References: Date: Thu, 12 Sep 2024 19:00:01 +0200 Message-ID: <877cbgkdta.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -9.09 X-Migadu-Queue-Id: CC8CA12D24 X-Spam-Score: -9.09 X-TUID: tAYrRpunDq16 Hello, Nguy=E1=BB=85n Gia Phong skribis: > Since iberty is a static library, linking a PIC-enabled target to it > requires it to also have been built with PIC. (The target is Dyninst > in this case.) > > * gnu/packages/gcc.scm (make-libiberty)[arguments]: > Adjust make-flags to add -fPIC to CFLAGS. > > Change-Id: I155045d05f4434cb68be933a95b7bc9fdec98818 [...] > + #:make-flags '("CFLAGS=3D-fPIC") I believe this overrides the default =E2=80=98CFLAGS=E2=80=99, and the end = result is that the library would be compiled with =E2=80=98-O0 -g0=E2=80=99. So unless I=E2=80=99m mistaken, you should instead have: "CFLAGS=3D-O2 -g -fPIC" Apart from that, the patch series looks good to me. Could you send updated patches? Thanks in advance, Ludo=E2=80=99.