From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id KNsLAPJrV2eWWgEAqHPOHw:P1 (envelope-from ) for ; Mon, 09 Dec 2024 22:15:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id KNsLAPJrV2eWWgEAqHPOHw (envelope-from ) for ; Mon, 09 Dec 2024 23:15:14 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=E2mQTe1G; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=jcxEzk2j; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733782513; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CgMzUdSUYw42MPLrtBsq+PwdKMgm13CYf/uILoLQoZU=; b=nCYIfuYYSnkOKmS0SIDRqPxutmkCtxDcIWYvdct0AKSWyUC8wn0ZBewSXT9n6OP34mfqOZ inNtABYcMCY9+3vY03+eCLD/KSCbNgLvvSe4S8zej/HfJx/9yklMirNiEx8TVviEuWgvd/ EzBgeahmDngEem1uQRreP/8Ezp4Dcj6ro2AT2BiEfPRAAfsgDMyKVw+byf44WRkgdOM2bv 4WQbGXFXwPLNx/sP2IJsZyXjXvhELEZtmQ8Wq/HjMQ0QJKXpN939yn8yrord23R56wiJ4b ghJDjHYJvv33TsnYoxTI3+73Khg/KYnUioNDS1C4JU+y+PQOCVvfqhaFkvWu6A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=E2mQTe1G; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=jcxEzk2j; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733782513; a=rsa-sha256; cv=none; b=ZVWoMoHqV9nl+4n0fZ+uu7uhLJLQPXxuYgW+iikOthqoyb6/52Dp15V8jXc3+12oae/644 GVfCxH0b34n0FNnMCd5XL5eg1A3upYcwq1PK7/yEDbMz3i73R8lep4+3oFIo/Nr8IFqKYw MI64xgFG4amB0ucg9w3T5RI1kN6qj32caqRxJUvM/1xgficmZpSgeXop7WUHLy7sRPKcmg qnuT1fs7UrmjUppEpMWTt2qDMxnOnONxt/FX2XD85YxwcJohA5uHUa6JqhJmCRLTW0gfGH Raz8TnlVRG67qgx8xpTyCccgEKA94scTTc6jr401NXZrbJKBuKIh/4kY8mFG8A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9D8957EEE3 for ; Mon, 09 Dec 2024 23:15:12 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tKm1x-0000Kk-9Q; Mon, 09 Dec 2024 17:15:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKm1v-0000IU-CW for guix-patches@gnu.org; Mon, 09 Dec 2024 17:15:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tKm1v-0006Ui-3W for guix-patches@gnu.org; Mon, 09 Dec 2024 17:15:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=CgMzUdSUYw42MPLrtBsq+PwdKMgm13CYf/uILoLQoZU=; b=E2mQTe1GTRlwOFPT9+cum04xy3jbdKHjizom2JWb8PN42Hvm9rOCp5ZFpTwVZ0McFUrqEnBoC6HVZYYiyL2RRx8AEw659pEn7xfTygtxhZ3ijkhDHaRWtZ4OxLDr25Ony8Si1T9Qs+yLtSQ8Ju8C2fVH7J/V2Qd8czsJTCLOEGwe3kMkyk2hydVQC742kAj8JQjmWX3r+0X1/V+aKcVJqguGXN1ODyBf+YSOmI8J+StSK3nOKYL3enXOuNYDl9PQXw4hImfJBSEO5DqmYXfPo1RlbWsotmYJwgilC+Sx241dPJ8vcC5kaTGxOBtayhdZLgEk0k0/Vjp3dEbl5wTHSg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tKm1t-0004a6-VG for guix-patches@gnu.org; Mon, 09 Dec 2024 17:15:01 -0500 Subject: bug#74686: [PATCH] daemon: Fix linking gcrypt when --as-needed linker arg is used Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 09 Dec 2024 22:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 74686 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Do=C4=9Fan_?= =?UTF-8?Q?=C3=87e=C3=A7en?= Cc: 74686-done@debbugs.gnu.org Mail-Followup-To: 74686@debbugs.gnu.org, ludo@gnu.org, sepeth@fastmail.com Received: via spool by 74686-done@debbugs.gnu.org id=D74686.173378246517482 (code D ref 74686); Mon, 09 Dec 2024 22:15:01 +0000 Received: (at 74686-done) by debbugs.gnu.org; 9 Dec 2024 22:14:25 +0000 Received: from localhost ([127.0.0.1]:56045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKm1J-0004Xt-1i for submit@debbugs.gnu.org; Mon, 09 Dec 2024 17:14:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tKm1H-0004Xa-9I for 74686-done@debbugs.gnu.org; Mon, 09 Dec 2024 17:14:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKm1B-0006Rm-I2; Mon, 09 Dec 2024 17:14:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=CgMzUdSUYw42MPLrtBsq+PwdKMgm13CYf/uILoLQoZU=; b=jcxEzk2j7+gFS4n3heIT Pnvy1ItSQ2rfHgy8gt/vbzkG2D4JuvBl7sYzyXHWJFIu/jV+eaCP05djmAJn7of/Snb2c1z6siQL+ a8QkKBxGmj7W7XpXPLDzSzz6vkcLJ3uK6uWlfd5opqg4ytUphwh5B9Tl4NliJQybz/rPRPvX2jt9Y n8jtqsu0PIAQi1wvkH2kJRr+QyZ2AGILOu8t5LYolDA3tH1pcYF7gRzB+Szon97L/Y5tIgiIUcCO+ odvAhyAWt1uTulfEwKMW+8gl8acLUgExrwNNvZIGpaZEji99f41+bBwLARRC2OGtd4Upk5L+5MCyf tYQunz/XtA305g==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <5a89940f415ff9475062136c4e29e27d650fdbe3.1733307011.git.sepeth@fastmail.com> ("=?UTF-8?Q?Do=C4=9Fan_?= =?UTF-8?Q?=C3=87e=C3=A7en?="'s message of "Wed, 4 Dec 2024 12:10:11 +0200") References: <5a89940f415ff9475062136c4e29e27d650fdbe3.1733307011.git.sepeth@fastmail.com> Date: Mon, 09 Dec 2024 23:14:15 +0100 Message-ID: <877c88ld1k.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -0.86 X-Spam-Score: -0.86 X-Migadu-Queue-Id: 9D8957EEE3 X-TUID: V/YghQzrFCfo Hi, Do=C4=9Fan =C3=87e=C3=A7en skribis: > As it is mentioned in autoconf manual that library names should be > specified in LIBS, not LDFLAGS. See: > > https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/= html_node/Preset-Output-Variables.html#index-LDFLAGS-2 > > This change also brings back the save_* vars trick that was there > before. I missed in my earlier change that nix/local.mk was referring > LIBGCRYPT_* vars directly. > > And, instead of CXXFLAGS, CPPFLAGS is used since the latter is probably > more correct as this is used for include dirs, therefore using > preprocessor flags. > > Tested with ./configure LDFLAGS=3D"-Wl,--as-needed" --with-libgcrypt-pref= ix=3D... combinations. > > Change-Id: Iadb10e1994c9a78e2927847af2cfe5e096fbb2a8 Applied with a ChangeLog-style commit log, thanks. (I was surprised by some of the changes in the first patch; thanks for following up!) Ludo=E2=80=99.