From: "Ludovic Courtès" <ludo@gnu.org>
To: "Doğan Çeçen" <sepeth@fastmail.com>
Cc: 74686-done@debbugs.gnu.org
Subject: bug#74686: [PATCH] daemon: Fix linking gcrypt when --as-needed linker arg is used
Date: Mon, 09 Dec 2024 23:14:15 +0100 [thread overview]
Message-ID: <877c88ld1k.fsf@gnu.org> (raw)
In-Reply-To: <5a89940f415ff9475062136c4e29e27d650fdbe3.1733307011.git.sepeth@fastmail.com> ("Doğan Çeçen"'s message of "Wed, 4 Dec 2024 12:10:11 +0200")
Hi,
Doğan Çeçen <sepeth@fastmail.com> skribis:
> As it is mentioned in autoconf manual that library names should be
> specified in LIBS, not LDFLAGS. See:
>
> https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/html_node/Preset-Output-Variables.html#index-LDFLAGS-2
>
> This change also brings back the save_* vars trick that was there
> before. I missed in my earlier change that nix/local.mk was referring
> LIBGCRYPT_* vars directly.
>
> And, instead of CXXFLAGS, CPPFLAGS is used since the latter is probably
> more correct as this is used for include dirs, therefore using
> preprocessor flags.
>
> Tested with ./configure LDFLAGS="-Wl,--as-needed" --with-libgcrypt-prefix=... combinations.
>
> Change-Id: Iadb10e1994c9a78e2927847af2cfe5e096fbb2a8
Applied with a ChangeLog-style commit log, thanks.
(I was surprised by some of the changes in the first patch; thanks for
following up!)
Ludo’.
prev parent reply other threads:[~2024-12-09 22:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 10:10 [bug#74686] [PATCH] daemon: Fix linking gcrypt when --as-needed linker arg is used Doğan Çeçen
2024-12-09 22:14 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c88ld1k.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=74686-done@debbugs.gnu.org \
--cc=sepeth@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).