From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id mKKPNF6PcWeyewEA62LTzQ:P1 (envelope-from ) for ; Sun, 29 Dec 2024 18:05:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id mKKPNF6PcWeyewEA62LTzQ (envelope-from ) for ; Sun, 29 Dec 2024 19:05:18 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=T9T+I8lH; dkim=fail ("headers rsa verify failed") header.d=xn--no-cja.eu header.s=ds202402 header.b=Lhg+NNA+; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1735495518; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=L7/+00MwLgdv+yaWnuo/L57GZQexQGyF6k95pCk5x8Q=; b=W2v7qp6rt9sc8ojVkPpO0siSn6GQbN1whkstCKS6iXadEtC5h39VyRZ7+cTDaRxUpAktIo ENTISRIitTdcQdIsN5+KzuSVNVtSlS/lZKuLMSl9NxqehSDTRjExCSLLXYTFIBvH3DZ3/G 4HkwkGrLv06fKZnIWCfob9iiCJiQ3G+3R57B23rictedC2yR2qshpP+q5r4sMsZGynCqwS 77rTG8XjGpT8JtfFDt3Non/BQFRIIaAdjHN/jUSY46zi5c9RazgeD9MIFbK1pt7+IGzOGN 3UgvfjAOLS6CXvH901/sng0KJMeUw6r3yxMJ8Rc7FnaIaTj8DxFfm2db95brrA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=T9T+I8lH; dkim=fail ("headers rsa verify failed") header.d=xn--no-cja.eu header.s=ds202402 header.b=Lhg+NNA+; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1735495518; a=rsa-sha256; cv=none; b=PaYPn2eo8aoQhbnc5paYs0x31sM/FTOD6lblY+bQeDMCasudR1tEwmQVkKePJ8kEoOAiR9 ynw7cF55kH++Tz8ZNe3Ft2gwqxu+Iq6kZx4fyGTXAbfUyJUcmSR6JyaZyuZQxcWSKTnQcj kf99v6zyjEApWlwu6e+z1r6e0pRnOIAISTNs/pqIBQy6PEua4HwZyxzltOWk53MSsw4nP5 EMU34Cg/jJQ6rK/XSEmIK9RGFBa4Msho8JSGy1bK0WjSJzOfZIkrt+l7XBgOQyzBMJ4vP1 8KVR3JAuUyBiIvyRRhVSXBN1W52tqWA1rT6VlTFgfR+9xlc5zFYOQ+WV6qwx9w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 643A58906D for ; Sun, 29 Dec 2024 19:05:18 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRxey-0002zQ-Lz; Sun, 29 Dec 2024 13:05:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRxew-0002yt-NC for guix-patches@gnu.org; Sun, 29 Dec 2024 13:05:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRxew-0001mF-D8 for guix-patches@gnu.org; Sun, 29 Dec 2024 13:05:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=L7/+00MwLgdv+yaWnuo/L57GZQexQGyF6k95pCk5x8Q=; b=T9T+I8lHX2dZoXbsIk6u01WqtDX1end2HXNuHEL8zHf6uiumh3hpjXCHNZTB64CTodworWozVVGNtJdRkVuSy83iYzOkkZ0Dykoy8wDKOM19nQy4nYGZAIzjOATUQztMtuIWZDiuFjKDnldPh6FbI4WW0f4PnDqwIuIbvXkf1WboZ+f4Xj7a5s+Xia0vgzLfnzQJBNCoYXY01l8FOSkQ/3XLBoTExa3vbQn0gyRdHzXdYg7cDBoXZthF1ANUgO4oVujiWp6RLSMt+qlH0KxwHNi5nEg1I/5kgOcQzo5pXNzS1PsaKUM3ep1FUEYNgW6Ft7Fx3TSRHQmn3FDs3qOW7Q==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tRxew-0005Df-7X for guix-patches@gnu.org; Sun, 29 Dec 2024 13:05:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#75172] QA review for 75172 References: <20cc82b3d64dd9d2355234df2271ca919a1905e7.1735464449.git.yovan@gorski.stream> In-Reply-To: <20cc82b3d64dd9d2355234df2271ca919a1905e7.1735464449.git.yovan@gorski.stream> Resent-From: =?UTF-8?Q?No=C3=A9?= Lopez Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 29 Dec 2024 18:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75172 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: control@debbugs.gnu.org,75172@debbugs.gnu.org Received: via spool by 75172-submit@debbugs.gnu.org id=B75172.173549548520028 (code B ref 75172); Sun, 29 Dec 2024 18:05:02 +0000 Received: (at 75172) by debbugs.gnu.org; 29 Dec 2024 18:04:45 +0000 Received: from localhost ([127.0.0.1]:56087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRxee-0005Cx-NV for submit@debbugs.gnu.org; Sun, 29 Dec 2024 13:04:44 -0500 Received: from smtp.domeneshop.no ([194.63.252.55]:56525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRxeX-0005CZ-E4; Sun, 29 Dec 2024 13:04:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xn--no-cja.eu; s=ds202402; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:To:From:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=L7/+00MwLgdv+yaWnuo/L57GZQexQGyF6k95pCk5x8Q=; b=Lhg+NNA+Z4z5PyolGlhceX/Blw vcYa4uA+eKLIra2FSbD/hdZal6v8sCIUVByvcrmQgeIz/8MQ3+RUqehfocuI8Bce3Mpfcg1Fgc2ii npWpor4e6GvEUZ3oozIuPo/JjJojD0UwAGB6RS73XskxTLplGW5pDh6JyO2hc0o/bbPhGQWDKMQJl qiUyoEEiVkGorcWEu8Z3Zfix7BgOj/7Asky93vwXFaR0AwALBa+rWFeuEcha3XZAhwJLd7eQ0kxgM lpD6bBC2zczgsrZeVcVyPpwxh9n8yK4ZUwbu13KATP+SuIk9FHZd/to4cxnGpAntjiO5jcdlEt7Lm 8Z1HRM8Q==; Received: from smtp by smtp.domeneshop.no with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) id 1tRxcK-005nf6-Sd; Sun, 29 Dec 2024 19:02:20 +0100 Date: Sun, 29 Dec 2024 19:03:47 +0100 Message-ID: <877c7iv01o.fsf@xn--no-cja.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: =?UTF-8?Q?No=C3=A9?= Lopez X-ACL-Warn: , =?utf-8?q?No=C3=A9_Lopez_via_Guix-patches?= From: =?utf-8?q?No=C3=A9_Lopez_via_Guix-patches?= via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -3.60 X-Spam-Score: -3.60 X-Migadu-Queue-Id: 643A58906D X-TUID: xVdLtKOfS85W user guix usertag 75172 + reviewed-looks-good thanks Guix QA review form submission: Thanks for the patch, it builds and works well. The line you added in substitute* is a bit too long, but I think you can just replace the \n with an actual line break: (substitute* "test/irc.lua" (("local is_origin") "if remote =3D=3D nil then return function() end\nend\nlocal is_origin")) Have a nice day, No=C3=A9 Lopez Items marked as checked: Package builds, Commit messages