From: "Noé Lopez via Guix-patches via" <guix-patches@gnu.org>
To: control@debbugs.gnu.org,75172@debbugs.gnu.org
Subject: [bug#75172] QA review for 75172
Date: Sun, 29 Dec 2024 19:03:47 +0100 [thread overview]
Message-ID: <877c7iv01o.fsf@xn--no-cja.eu> (raw)
In-Reply-To: <20cc82b3d64dd9d2355234df2271ca919a1905e7.1735464449.git.yovan@gorski.stream>
user guix
usertag 75172 + reviewed-looks-good
thanks
Guix QA review form submission:
Thanks for the patch, it builds and works well.
The line you added in substitute* is a bit too long, but I think you can
just replace the \n with an actual line break:
(substitute* "test/irc.lua"
(("local is_origin")
"if remote == nil then
return function() end\nend\nlocal is_origin"))
Have a nice day,
Noé Lopez
Items marked as checked: Package builds, Commit messages
next prev parent reply other threads:[~2024-12-29 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-29 9:52 [bug#75172] [PATCH] gnu: fennel: Update to 1.5.1 Yovan Naumovski
2024-12-29 18:03 ` Noé Lopez via Guix-patches via [this message]
2024-12-30 9:18 ` Yovan Naumovski
2024-12-30 19:50 ` Ian Eure
2024-12-30 21:11 ` Yovan Naumovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c7iv01o.fsf@xn--no-cja.eu \
--to=guix-patches@gnu.org \
--cc=75172@debbugs.gnu.org \
--cc=control@debbugs.gnu.org \
--cc=noe@xn--no-cja.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).