* [bug#75243] [PATCH] gnu: Add emacs-binder.
@ 2025-01-01 15:29 Divya Ranjan via Guix-patches via
2025-01-01 16:40 ` Nicolas Goaziou via Guix-patches via
0 siblings, 1 reply; 5+ messages in thread
From: Divya Ranjan via Guix-patches via @ 2025-01-01 15:29 UTC (permalink / raw)
To: 75243; +Cc: Divya Ranjan
* gnu/packages/emacs-xyz.scm (emacs-binder): New variable.
---
gnu/packages/emacs-xyz.scm | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4e4ac5d4c4..73b6ad72b9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -39712,6 +39712,25 @@ (define-public emacs-iter2
original package.")
(license license:gpl3+)))
+(define-public emacs-binder
+ (package
+ (name "emacs-binder")
+ (version "20241023.1154")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://melpa.org/packages/binder-" version ".tar"))
+ (sha256
+ (base32 "1nvsmmg9wwan5y38dpcpffzxxvivi4708ri64f03gwcq66g1k49m"))))
+ (build-system emacs-build-system)
+ (home-page "https://codeberg.org/divyaranjan/binder")
+ (synopsis
+ "Binder is a global minor mode to facilitate working on multiple files")
+ (description "Primarily, Binder provides a global minor mode binder-mode.
+This allows working with files in the current binder-project-directory.
+Data concerning these files is saved in a .binder.el file in the project directory.")
+ (license license:gpl3+)))
+
(define-public emacs-bind-map
(let ((commit "510a24138d8de3b8df0783f1ac493a551fc9bd74")
(revision "0"))
--
2.47.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [bug#75243] [PATCH] gnu: Add emacs-binder.
2025-01-01 15:29 [bug#75243] [PATCH] gnu: Add emacs-binder Divya Ranjan via Guix-patches via
@ 2025-01-01 16:40 ` Nicolas Goaziou via Guix-patches via
2025-01-01 20:13 ` Divya Ranjan via Guix-patches via
2025-01-02 4:59 ` Divya Ranjan via Guix-patches via
0 siblings, 2 replies; 5+ messages in thread
From: Nicolas Goaziou via Guix-patches via @ 2025-01-01 16:40 UTC (permalink / raw)
To: 75243; +Cc: divya
Hello,
Divya Ranjan via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/emacs-xyz.scm (emacs-binder): New variable.
Thank you. Some comments follow.
> +(define-public emacs-binder
> + (package
> + (name "emacs-binder")
> + (version "20241023.1154")
Version should be "0.5.0", as set in "binder.el".
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://melpa.org/packages/binder-" version ".tar"))
Guix does not use MELPA as upstream because tarballs are not reliable.
Please use Codeberg repository instead.
> + (sha256
> + (base32 "1nvsmmg9wwan5y38dpcpffzxxvivi4708ri64f03gwcq66g1k49m"))))
> + (build-system emacs-build-system)
> + (home-page "https://codeberg.org/divyaranjan/binder")
> + (synopsis
> + "Binder is a global minor mode to facilitate working on multiple files")
> + (description "Primarily, Binder provides a global minor mode
> binder-mode.
"binder-mode" -> "Binder mode".
> +This allows working with files in the current
> binder-project-directory.
"binder-project-directory" -> "@code{binder-project-directory}".
> +Data concerning these files is saved in a .binder.el file in the
> project directory.")
I don’t think the last sentence is useful in the description as it
merely describes the internals of the package. I suggest to remove it.
If you absolutely want to keep it, I suggest to apply proper markup:
".binder.el" -> "@file{.binder.el}".
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread* [bug#75243] [PATCH] gnu: Add emacs-binder.
2025-01-01 16:40 ` Nicolas Goaziou via Guix-patches via
@ 2025-01-01 20:13 ` Divya Ranjan via Guix-patches via
2025-01-02 4:59 ` Divya Ranjan via Guix-patches via
1 sibling, 0 replies; 5+ messages in thread
From: Divya Ranjan via Guix-patches via @ 2025-01-01 20:13 UTC (permalink / raw)
To: 75243; +Cc: mail
[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]
Hello Nicholas, I’ve made the necessary edits, the edited patch is attached below:
Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org> writes:
> Hello,
>
> Divya Ranjan via Guix-patches via <guix-patches@gnu.org> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-binder): New variable.
>
> Thank you. Some comments follow.
>
>> +(define-public emacs-binder
>> + (package
>> + (name "emacs-binder")
>> + (version "20241023.1154")
>
> Version should be "0.5.0", as set in "binder.el".
>
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append "https://melpa.org/packages/binder-" version ".tar"))
>
> Guix does not use MELPA as upstream because tarballs are not reliable.
> Please use Codeberg repository instead.
>
>> + (sha256
>> + (base32 "1nvsmmg9wwan5y38dpcpffzxxvivi4708ri64f03gwcq66g1k49m"))))
>> + (build-system emacs-build-system)
>> + (home-page "https://codeberg.org/divyaranjan/binder")
>> + (synopsis
>> + "Binder is a global minor mode to facilitate working on multiple files")
>> + (description "Primarily, Binder provides a global minor mode
>> binder-mode.
>
> "binder-mode" -> "Binder mode".
>
>> +This allows working with files in the current
>> binder-project-directory.
>
> "binder-project-directory" -> "@code{binder-project-directory}".
>
>> +Data concerning these files is saved in a .binder.el file in the
>> project directory.")
>
> I don’t think the last sentence is useful in the description as it
> merely describes the internals of the package. I suggest to remove it.
> If you absolutely want to keep it, I suggest to apply proper markup:
> ".binder.el" -> "@file{.binder.el}".
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-binder.patch --]
[-- Type: text/x-patch, Size: 1565 bytes --]
From 1ff216e0f0479dc86d1b686fc80af50ccf8f5487 Mon Sep 17 00:00:00 2001
From: Divya Ranjan <divya@subvertising.org>
Date: Wed, 1 Jan 2025 15:18:44 +0000
Subject: [PATCH] gnu: Add emacs-binder.
* gnu/packages/emacs-xyz.scm (emacs-binder): New variable.
---
gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4e4ac5d4c4..072e30d131 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -39712,6 +39712,28 @@ (define-public emacs-iter2
original package.")
(license license:gpl3+)))
+(define-public emacs-binder
+ (package
+ (name "emacs-binder")
+ (version "0.5.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://codeberg.org/divyaranjan/binder")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ "1fdgl31zc15cysv1yys95j0106i2fwfxb3qcwwh7f3mcz2snr2md")))
+ (build-system emacs-build-system)
+ (home-page "https://codeberg.org/divyaranjan/binder")
+ (synopsis
+ "Binder is a global minor mode to facilitate working on multiple files")
+ (description
+ "Primarily, Binder provides a global minor mode Binder Mode.
+This allows working with files in the current @code{binder-project-directory}.")
+ (license license:gpl3+)))
+
(define-public emacs-bind-map
(let ((commit "510a24138d8de3b8df0783f1ac493a551fc9bd74")
(revision "0"))
--
2.47.1
[-- Attachment #3: Type: text/plain, Size: 179 bytes --]
>
> Could you send an updated patch?
>
> Regards,
--
Divya Ranjan,
Philosophy, Mathematics, Libre Software.
PGP Fingerprint: F0B3 1A69 8006 8FB8 096A 2F12 B245 10C6 108C 8D4A
^ permalink raw reply related [flat|nested] 5+ messages in thread* [bug#75243] [PATCH] gnu: Add emacs-binder.
2025-01-01 16:40 ` Nicolas Goaziou via Guix-patches via
2025-01-01 20:13 ` Divya Ranjan via Guix-patches via
@ 2025-01-02 4:59 ` Divya Ranjan via Guix-patches via
2025-01-03 11:02 ` Nicolas Goaziou via Guix-patches via
1 sibling, 1 reply; 5+ messages in thread
From: Divya Ranjan via Guix-patches via @ 2025-01-02 4:59 UTC (permalink / raw)
To: 75243; +Cc: mail
Also, Nicholas I forgot to include the Copyright signature in my patch, could you just include it yourself? "Divya Ranjan Pattanaik <divya@subvertising.org>".
Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org> writes:
> Hello,
>
> Divya Ranjan via Guix-patches via <guix-patches@gnu.org> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-binder): New variable.
>
> Thank you. Some comments follow.
>
>> +(define-public emacs-binder
>> + (package
>> + (name "emacs-binder")
>> + (version "20241023.1154")
>
> Version should be "0.5.0", as set in "binder.el".
>
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append "https://melpa.org/packages/binder-" version ".tar"))
>
> Guix does not use MELPA as upstream because tarballs are not reliable.
> Please use Codeberg repository instead.
>
>> + (sha256
>> + (base32 "1nvsmmg9wwan5y38dpcpffzxxvivi4708ri64f03gwcq66g1k49m"))))
>> + (build-system emacs-build-system)
>> + (home-page "https://codeberg.org/divyaranjan/binder")
>> + (synopsis
>> + "Binder is a global minor mode to facilitate working on multiple files")
>> + (description "Primarily, Binder provides a global minor mode
>> binder-mode.
>
> "binder-mode" -> "Binder mode".
>
>> +This allows working with files in the current
>> binder-project-directory.
>
> "binder-project-directory" -> "@code{binder-project-directory}".
>
>> +Data concerning these files is saved in a .binder.el file in the
>> project directory.")
>
> I don’t think the last sentence is useful in the description as it
> merely describes the internals of the package. I suggest to remove it.
> If you absolutely want to keep it, I suggest to apply proper markup:
> ".binder.el" -> "@file{.binder.el}".
>
> Could you send an updated patch?
>
> Regards,
--
Divya Ranjan,
Philosophy, Mathematics, Libre Software.
PGP Fingerprint: F0B3 1A69 8006 8FB8 096A 2F12 B245 10C6 108C 8D4A
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-01-03 11:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-01 15:29 [bug#75243] [PATCH] gnu: Add emacs-binder Divya Ranjan via Guix-patches via
2025-01-01 16:40 ` Nicolas Goaziou via Guix-patches via
2025-01-01 20:13 ` Divya Ranjan via Guix-patches via
2025-01-02 4:59 ` Divya Ranjan via Guix-patches via
2025-01-03 11:02 ` Nicolas Goaziou via Guix-patches via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).