From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d4pTF-0008Tq-Jb for guix-patches@gnu.org; Sun, 30 Apr 2017 10:05:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d4pTC-0004ZN-Dw for guix-patches@gnu.org; Sun, 30 Apr 2017 10:05:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49674) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d4pTC-0004Z9-2c for guix-patches@gnu.org; Sun, 30 Apr 2017 10:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d4pTB-0008T2-Li for guix-patches@gnu.org; Sun, 30 Apr 2017 10:05:01 -0400 Subject: bug#26595: lugaru Resent-Message-ID: From: Marius Bakke In-Reply-To: <20170430144517.71ab0b51@lepiller.eu> References: <20170421213357.22653fcc@lepiller.eu> <87tw5cqlzg.fsf@elephly.net> <20170430144517.71ab0b51@lepiller.eu> Date: Sun, 30 Apr 2017 16:04:10 +0200 Message-ID: <8760hmhu05.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller , 26595@debbugs.gnu.org --=-=-= Content-Type: text/plain Julien Lepiller writes: > * gnu/packages/games.scm (lugaru): New variable. [...] > + (arguments > + `(#:configure-flags > + (list "-DSYSTEM_INSTALL=ON") > + #:tests? #f)) Please specify whether there are no tests, or they need something not available in the build environment, missing dependencies etc. > + (native-inputs > + `(("pkg-config" ,pkg-config))) > + (inputs > + `(("sdl2" ,sdl2) > + ("glu" ,glu) > + ("libjpeg" ,libjpeg-turbo) > + ("libpng" ,libpng) > + ("openal" ,openal) > + ("vorbis" ,libvorbis) > + ("zlib" ,zlib))) > + (home-page "https://osslugaru.gitlab.io") > + (synopsis "Cross-platform third-person action game") > + (description "The main character, Turner, is an anthropomorphic rebel bunny > +rabbit with impressive combat skills. In his quest to find those responsible > +for slaughtering his village, he uncovers a far-reaching conspiracy involving > +the corrupt leaders of the rabbit republic and the starving wolves from a > +nearby den. Turner takes it upon himself to fight against their plot and save > +his fellow rabbits from slavery.") > + (license (list license:gpl2+ license:cc-by-sa3.0)))) We usually add comments about what is covered by which license as well. In this case it's a safe guess that assets are CC-BY-SA, but it's nice to have it explicit regardless. Other than that looks good! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlkF7toACgkQoqBt8qM6 VPpG5wgAwnP+VHhrBX2/LYkmLwx1zsIUtgNaqKAZaYZ91vunpGFmNsi2upT4hHOb M7Xb1uip2Gy8gF8IMqs7kGgCMVVQBe09RrkJNRHIj0bmXuVkvldtfCgX5XUayEYO CTl/5YoqHm890j9ZQO/gJ8y9yt+r65yndE6jrxj9hyPU2WhkH+t1xpsIq9sC2ylt 2G97hGWZyr0QHGWFyGlYqkCPPtYIRuKKQtb+B5FrxGPgX4dwiJIkyyhdWnaKTmne iCNYAtwOr+eV1JxGAlo1uF7m02rnQSKrIMtwXAaKAAlyVlhAcHp7lbkun2GhI7Ko m8flLHwIs3HsXj4VYIq3psDcL31z/w== =EnUm -----END PGP SIGNATURE----- --=-=-=--