From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42907)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dstb3-0003Bt-4i
	for guix-patches@gnu.org; Fri, 15 Sep 2017 12:36:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dstb0-00056g-Eb
	for guix-patches@gnu.org; Fri, 15 Sep 2017 12:36:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34391)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dstb0-00056b-BL
	for guix-patches@gnu.org; Fri, 15 Sep 2017 12:36:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dstb0-0007cY-4i
	for guix-patches@gnu.org; Fri, 15 Sep 2017 12:36:02 -0400
Subject: bug#28045: [PATCH] gnu: Add openfoam
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.28045.D28045.150549334429262.done@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87mv61a2hn.fsf@gnu.org>
	<20170914154621.3196-1-pgarlick@tourbillion-technology.com>
Date: Fri, 15 Sep 2017 18:35:29 +0200
In-Reply-To: <20170914154621.3196-1-pgarlick@tourbillion-technology.com> (Paul
	Garlick's message of "Thu, 14 Sep 2017 16:46:21 +0100")
Message-ID: <8760cjudgu.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Paul Garlick <pgarlick@tourbillion-technology.com>
Cc: 28045-done@debbugs.gnu.org

Hi Paul,

Paul Garlick <pgarlick@tourbillion-technology.com> skribis:

> *gnu/packages/patches/openfoam-4.1-cleanup.patch: New file
> *gnu/packages/simulation.scm: New file
> *gnu/local.mk (GNU_SYSTEM_MODULES): Add module
> (dist_patch_DATA): Add patch

I went ahead and pushed this (with indentation changes and use of
#:modules as discussed earlier; please consider using
=E2=80=98etc/indent-code.el=E2=80=99 in the future):

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D8f21aa22bf4b731ed=
0e5631c371846028e5cec0d

Users who don=E2=80=99t set FOAM_INST_DIR will be tripped up like this:

--8<---------------cut here---------------start------------->8---
$  /gnu/store/4zqn4w0wlq0irdwh3dhrdbsr7i3f1dag-openfoam-4.1/bin/checkMesh=20
--> FOAM FATAL ERROR in Foam::findEtcFiles() : could not find mandatory file
    'controlDict'


$  /gnu/store/4zqn4w0wlq0irdwh3dhrdbsr7i3f1dag-openfoam-4.1/bin/interFoam=20
--> FOAM FATAL ERROR in Foam::findEtcFiles() : could not find mandatory file
    'controlDict'
--8<---------------cut here---------------end--------------->8---

But that=E2=80=99s part of the game for now.  :-)

Thanks a lot for your work and patience!

Ludo=E2=80=99.